From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C248734BA42 for ; Mon, 8 Jun 2026 21:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955261; cv=none; b=SMR03I1Q9HB4ZZXo5A2vbHpx9C+6d9u82d9VlFDO+ftwutwAYKzPZ3SXEmPH1TkQJE1QprOZgqSomDtk76SctCBHIkHShmTMPQjsOX08sGWlQXOVnJGBdcS4+ZmJkBgq5QfsB7eacG0hqJljOC4Nqv3wkiw1EwuTWTab4FhL03Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955261; c=relaxed/simple; bh=tdSiWKsxns6CPt/jy0ALFIb3BSWqQBL/zHu/FefKGdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KpR7jhNZvfU40O/hno/T9RgFO9/ImqOOgJ2xdx/FM+yI3w/aY1dBB95rLqM3+LjOcb/dScInOdcHf2xY/scC1McQA329TMEC8Gncx2NvymwVBmMGF0TLZ1xgyie9lfAKciknR6eg/w3eTDznrytAixMLnPKLd8irfa1KkTDpj8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJaxvwTL; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJaxvwTL" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36bb3551f6eso4230609a91.1 for ; Mon, 08 Jun 2026 14:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780955260; x=1781560060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TnO1pCD/ipOKWU15pcqCQJFHGQcWZGiwPn1ti26JNWI=; b=hJaxvwTLPHTIQX17oq/y8wttBdpmp0tzGiMos9h3uW0XryHxxPBfwoIhs5z2IXzB9y L+V+UUbaWmoiBq3DYE1/jS/mHzhVHAuacTnE0pAE0cvsBPVn+qHUCgDhFnXjyZ8y38Zr pKA0TXn3V+2RzUQvCcdR+2zuXUQ46zv8CHgwh3c1IDNysuutcmIAjoDLtNe6xsaDIYjN SUpdSXqT/e4jrcuyZ+DcZVKsxlD23iRqytzaXvvYq9JZwMQGqAN99xbq9TfiIJI890jv vca0ekpwn0KkIBBMLAacerymzCnh+rrlKERS8OIShCAVQNmaem5nW+TcWqZXWqK7l//J ++Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780955260; x=1781560060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TnO1pCD/ipOKWU15pcqCQJFHGQcWZGiwPn1ti26JNWI=; b=SId4Y77DtDv7E/5uBZdq6yP9B18+4yJJQDxriDXz3qyFlYJhlH3OBp92wc6eumNuY9 xIanYom0dVvOs+A+6WLYpIU8GDe3OY735MAChaQbZkZkFrVNTD5SbJO5g3P381s+YuCi uTnh5JE0Kcf+d/wZLSA5hiNztwUzygDWauPIQALkurbgtNE7RQUObrdD3EY9aoxdnQnK LQgK1nVOh6CRCJSFis7XMPRsoY6agTCxYw3TJQwQcXhz6cgT2JZHxAYehkmYKumWXxrV Teq5egZ1DhGappioq15NezYGLkN7H8XuwHokBTJrwwMV9L6Ioxc5hI7XeF37hLXTRF7O RgvA== X-Forwarded-Encrypted: i=1; AFNElJ/TSzfWzjr+iFSJRq+dkUfyUaoGIacd96IolkR9NxDQpevUKDAp2/7O4lsg/xbgwNVWHSjP3eERJY1hWxg=@vger.kernel.org X-Gm-Message-State: AOJu0YwldkAA59WNRN4rarnmsZ4ha/P16wi5fFmFsR4iwh0/Tl2hvG/c x7PcG1HnY8fuSquYk4S48tMZ7Lx/knmxAwVpVZosYMm7TSa6DiNYz/xhTU6oeL6S X-Gm-Gg: Acq92OFXKn+BrjbV+5yzU55fuob29l9WihZOIiya61KW5vkCt0EDLacExyvp98KqGC5 8wRp7ZinaM0rVSKfnjJ5PfHA5EISgP3zwEG0mV06hIMFZR6GDCgQin0jTJneLhqSSwNU+RmUYav 5kiqDF7DSDeukao7J+qOy53ibP4BtXl7Mkr//sZ87V9ejshIKqlGbYoq3aOR+Wy2trj6wyMplNk VLi2wdd1rRqEBUoXQDwU+wJrQzg2Hm56nT3t71PgK+FLqj5sN5/jwGQJQEl2tSiKXHf+qcR1oMD Bg5gnpP++D1woRr9d7IRuCrYmDIn/MXNFiJBxTR5lsQKUmS5LD7RC7x8wTNPPFR47ISKDj6Fyic 6GPAh0zZLUflL22NObRGhotn4KEwmpbm2jLt3lcCaq6fBixXU2IoIOuu6NrISjXWtFIXzd2nGGV 2PH8pZsL7kAPPOqhxQHvYUfoTXwkGMbvl2a582RGhACmITvt3fXHvQWECuY3ZY9zHB23pPTikXi WK75Ffb6q3Kxr4KHgHFyb1ag91U4tmGE1wrND7IHPIhsw== X-Received: by 2002:a05:6a20:260a:b0:3b4:6f7e:d0f9 with SMTP id adf61e73a8af0-3b4cccf74b4mr18969073637.3.1780955260157; Mon, 08 Jun 2026 14:47:40 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0b2ddbsm16016505a12.24.2026.06.08.14.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 14:47:39 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Julia Lawall , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/4] ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls Date: Mon, 8 Jun 2026 14:47:16 -0700 Message-ID: <20260608214718.49503-3-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260608214718.49503-1-rosenp@gmail.com> References: <20260608214718.49503-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bcom_ata_release() calls bcom_task_free(), which already calls irq_dispose_mapping(tsk->irq). The explicit irq_dispose_mapping() calls in the probe error path and remove function are redundant and cause a double-free of the same mapping. Remove them. Assisted-by: opencode:big-pickle Fixes: d01159dffa15 ("drivers/ata/pata_mpc52xx.c: clean up error handling code") Signed-off-by: Rosen Penev --- drivers/ata/pata_mpc52xx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index 9af0aa89a5c6..1246b705a411 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -794,7 +794,6 @@ static int mpc52xx_ata_probe(struct platform_device *op) err_free_irq: free_irq(task_irq, priv); - irq_dispose_mapping(task_irq); err_free_task: bcom_ata_release(dmatsk); err1: @@ -814,7 +813,6 @@ static void mpc52xx_ata_remove(struct platform_device *op) /* Clean up DMA */ task_irq = bcom_get_task_irq(priv->dmatsk); free_irq(task_irq, priv); - irq_dispose_mapping(task_irq); bcom_ata_release(priv->dmatsk); irq_dispose_mapping(priv->ata_irq); } -- 2.54.0