From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C98F43AFAE4 for ; Mon, 8 Jun 2026 21:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955265; cv=none; b=SGEMu+L8MfScPUyy8o+34s3R+R7pr67CLWCKBuIhlZScGwTQkEABDkrUg3LTkxk7lKFL2qK+SHiv1JJ/qQfrZLV0oiyHCFadQkzj844y9lzXT0n7Jn3KpvyGwvO7mc5N7d9P6e0eLCfiVkPVmaEh8m+6jrY2kDSWi1bGT7xWydg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955265; c=relaxed/simple; bh=lLgdyNzqPPEwWg0RhFjk7hX/lYGyZog4c3lOVR4ekdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lKJ9olUGhSdGsqvNiyz456hDSplDAB15xVHt3erAXrbNXqDEpX7BX+hPeY23M/IF1+2nmTW+ThpGj8T5irXsEcwzC21zGeKqLVA3he8Y1a00Q+E9kF2CrhBzphqCmMFFDuHy2C1Skr7vwAXJarBWaV8i/bUzeZ2vSm/mS6O/wFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hfZ9UXZq; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hfZ9UXZq" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c8629bed4e7so1218692a12.2 for ; Mon, 08 Jun 2026 14:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780955263; x=1781560063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c1aO31R9po/ToHJHFiNQQMCUQkh7948MgzIZhlOe7Vw=; b=hfZ9UXZq/hy5klis/llyTueSxRdJiG4xCHnnxEAkwFTV9aowjpIgLAKZattoxMnprS gjULy4RUGwbTRvY8nVQRWGFOseQS5w49e5i4dwO0VDUp5k6rjB9FuK5IOmbgX7F+5att 2B4b7rrWI+DmSeZ9auYNFLS73GQIsbrciyf6KDzbVE+X6FEANZ1gSG7lMC93+MbicfpM YGcIwO3FqRc/H7ICILIMtwfXST97P6s6U/ylAkxrb53+uc3gNGlNRs36YM7qOo2bMVnE 2PABabTSpqA6Bghk59vPcBa/7HCLD+R/631bey8WHAXhk8nDt+68G1RTHixrMv+EcPbI xf9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780955263; x=1781560063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c1aO31R9po/ToHJHFiNQQMCUQkh7948MgzIZhlOe7Vw=; b=fMi9hWKRB3ZRnkLH52fofRafVAI0uWTjeeHUhcEAATOOF5Yim837MDOQcHbQ/VMFde /yQBmfveQqYSOdokdlVwJ4VNbN+IOBdjCU4uoboZaun93zM2mSi0jgpNV58XAn1TNMaa iiilrd3AtMaXgdD4BbsERBgVO2w7DVfYJqqcXo78kL4Kv/nyFvzdWf4hNZM8f8Jgp2Z9 GIqveI07sRTVNCKoRnEeX3jHAuetnMubt20Ie0Iwn/3Chp3qqW6+kldrQqFWUSw2TSLm gicWvkwqGBBgJF9l71F3KDoAr4tgK7iHCKt2z9Ws+EBS4iXum4qtxfhRDW+46kSGlW9h B8Yg== X-Forwarded-Encrypted: i=1; AFNElJ/xNkY6MRaQIkvJDCL8QcOI+G/HSxChUUU6h/tRRzsUPU/ryHyOS815xx9u3ZrM5OtW3zIZzWeJwUlXbNc=@vger.kernel.org X-Gm-Message-State: AOJu0YyPGE2dYwKH6G3iVcE/SOjfPEfMPdbWjmatPsk2XzUTncFOrcFY GVcr3d+RTmanv01RUE2TdApLw2FvFPj1HWZ+yfNqpApeiJXclUib0pSamTPhRKZ5 X-Gm-Gg: Acq92OG7galyKGiTEV7O3FYCuHfBc+5o9clxkjvYsg5WGGZm99N85bXeLu9v8YjEucV HlSk/9mKjNWMx+JWPc86IVQmdhJiwsyrGrAxF/u0oqaOcmgY57ChmsaoqfHWZlnaoStqKcwQ18H T0HO8rEoikJXf6w4OkP+sgjyny5AuSDHk+kaEt0a0FiJZVN8t18n56lVmbr+Ca/R7ZQwwmBxsY9 oAcxwf0E+68Gpi2A9rgQLuDtwvGkRX4A+XQUduWl6duZXm0R7RU9ztHxk0rpzLsjPfctKCErl8b 2UWhouvMQMhRx/9aDy6GnAcfPjyNjgIDJQ0+XKdDNHN9qfn84TfLSAx7lU1o7IpsQc7RZfiuQ5l bD71wqG0CfK9Do4m+29nMcrYTvaI8wdLNFRyct36sC+t5U5i4w1NQiOCoYQFFH1av2Q4wlhAYo+ k8eXJnaHtreW4K8VULkm9/k+PY0Qk8ZbokdBR6tJe0GAm20QuLf9Po2t0zv6eq1jhKobul+GzDP /GjJkt5+H38U+95yeJC4R1OhZI+H+UIdNkAZAEZLc49vA== X-Received: by 2002:a05:6a20:b598:b0:39c:a78e:dba9 with SMTP id adf61e73a8af0-3b4cd05d32fmr20752862637.40.1780955263092; Mon, 08 Jun 2026 14:47:43 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0b2ddbsm16016505a12.24.2026.06.08.14.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 14:47:42 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Julia Lawall , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/4] ata: pata_mpc52xx: use devm_platform_get_and_ioremap_resource Date: Mon, 8 Jun 2026 14:47:18 -0700 Message-ID: <20260608214718.49503-5-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260608214718.49503-1-rosenp@gmail.com> References: <20260608214718.49503-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded sequence of of_address_to_resource(), devm_request_mem_region(), and devm_ioremap() with the standard devm_platform_get_and_ioremap_resource() helper. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/pata_mpc52xx.c | 29 ++++++----------------------- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index d27390eda98e..3c41a7b860bd 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include @@ -671,7 +670,7 @@ static int mpc52xx_ata_init_one(struct device *dev, static int mpc52xx_ata_probe(struct platform_device *op) { unsigned int ipb_freq; - struct resource res_mem; + struct resource *res_mem; int ata_irq = 0; struct mpc52xx_ata __iomem *ata_regs; struct mpc52xx_ata_priv *priv = NULL; @@ -688,25 +687,9 @@ static int mpc52xx_ata_probe(struct platform_device *op) return -ENODEV; } - /* Get device base address from device tree, request the region - * and ioremap it. */ - rv = of_address_to_resource(op->dev.of_node, 0, &res_mem); - if (rv) { - dev_err(&op->dev, "could not determine device base address\n"); - return rv; - } - - if (!devm_request_mem_region(&op->dev, res_mem.start, - sizeof(*ata_regs), DRV_NAME)) { - dev_err(&op->dev, "error requesting register region\n"); - return -EBUSY; - } - - ata_regs = devm_ioremap(&op->dev, res_mem.start, sizeof(*ata_regs)); - if (!ata_regs) { - dev_err(&op->dev, "error mapping device registers\n"); - return -ENOMEM; - } + ata_regs = devm_platform_get_and_ioremap_resource(op, 0, &res_mem); + if (IS_ERR(ata_regs)) + return PTR_ERR(ata_regs); /* * By default, all DMA modes are disabled for the MPC5200. Some @@ -740,7 +723,7 @@ static int mpc52xx_ata_probe(struct platform_device *op) priv->ipb_period = 1000000000 / (ipb_freq / 1000); priv->ata_regs = ata_regs; - priv->ata_regs_pa = res_mem.start; + priv->ata_regs_pa = res_mem->start; priv->ata_irq = ata_irq; priv->csel = -1; priv->mpc52xx_ata_dma_last_write = -1; @@ -777,7 +760,7 @@ static int mpc52xx_ata_probe(struct platform_device *op) } /* Register ourselves to libata */ - rv = mpc52xx_ata_init_one(&op->dev, priv, res_mem.start, + rv = mpc52xx_ata_init_one(&op->dev, priv, res_mem->start, mwdma_mask, udma_mask); if (rv) { dev_err(&op->dev, "error registering with ATA layer\n"); -- 2.54.0