mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: NeilBrown <neil@brown.name>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] filelock: update break_lease() stub with correct arguments
Date: Mon, 8 Jun 2026 15:10:14 -0700	[thread overview]
Message-ID: <20260608221014.GD2340474@ax162> (raw)
In-Reply-To: <20260607-breakleasefix-v1-1-658dce536d15@kernel.org>

On Sun, Jun 07, 2026 at 06:46:11AM -0400, Jeff Layton wrote:
> When CONFIG_FILE_LOCKING=n, break_lease() becomes a no-op. The arguments
> for the function still need to change though.
> 
> Fixes: 4be9f3cc582a ("filelock: rework the __break_lease API to use flags")
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606071029.DKCs8WOs-lkp@intel.com/
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build

> ---
>  include/linux/filelock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/filelock.h b/include/linux/filelock.h
> index 7a7a6e8a9a08..ec11cc6b4c58 100644
> --- a/include/linux/filelock.h
> +++ b/include/linux/filelock.h
> @@ -584,7 +584,7 @@ static inline bool is_delegated(struct delegated_inode *di)
>  	return false;
>  }
>  
> -static inline int break_lease(struct inode *inode, bool wait)
> +static inline int break_lease(struct inode *inode, unsigned int mode)
>  {
>  	return 0;
>  }
> 
> ---
> base-commit: 4d14e43b656c6ddefa91114975470a6a992b30ee
> change-id: 20260607-breakleasefix-3d5a9f1e1fd6
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
> 

-- 
Cheers,
Nathan

      reply	other threads:[~2026-06-08 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 10:46 Jeff Layton
2026-06-08 22:10 ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608221014.GD2340474@ax162 \
    --to=nathan@kernel.org \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome