mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Daniel Stone" <daniel@fooishbar.org>
Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	 intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	 linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org,
	 Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: [PATCH v17 04/28] drm/connector: Let connectors have a say in their color format
Date: Tue, 09 Jun 2026 14:43:51 +0200	[thread overview]
Message-ID: <20260609-color-format-v17-4-35739b5782cc@collabora.com> (raw)
In-Reply-To: <20260609-color-format-v17-0-35739b5782cc@collabora.com>

Add a function to get the connector color format from a connector state,
and a new function pointer in drm_connector_funcs to allow connectors to
override what connector color format it returns.

This is useful for the bridge chain recursive bus format selection code,
which does not wish to implement connector implementation specific
checks like whether it involves HDMI.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
 drivers/gpu/drm/drm_connector.c | 16 ++++++++++++++++
 include/drm/drm_connector.h     | 12 ++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 296195087a4c..95c65ed18709 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -3694,6 +3694,22 @@ void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode,
 }
 EXPORT_SYMBOL(drm_connector_oob_hotplug_event);
 
+/**
+ * drm_connector_get_color_format - Return connector color format of @conn_state
+ * @conn_state: pointer to the &struct drm_connector_state to go check
+ *
+ */
+enum drm_connector_color_format
+drm_connector_get_color_format(const struct drm_connector_state *conn_state)
+{
+	struct drm_connector *connector = conn_state->connector;
+
+	if (connector->funcs->color_format)
+		return connector->funcs->color_format(conn_state);
+
+	return conn_state->color_format;
+}
+EXPORT_SYMBOL(drm_connector_get_color_format);
 
 /**
  * DOC: Tile group
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index e1f6072ce7c9..4317166562cf 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -1803,6 +1803,16 @@ struct drm_connector_funcs {
 	 * Allows connectors to create connector-specific debugfs files.
 	 */
 	void (*debugfs_init)(struct drm_connector *connector, struct dentry *root);
+
+	/**
+	 * @color_format:
+	 *
+	 * Allows connectors to return a connector color format other than
+	 * @conn_state.color_format for purposes of e.g. display protocol
+	 * specific helper logic having already mapped it to an output format.
+	 */
+	enum drm_connector_color_format (*color_format)(
+		const struct drm_connector_state *conn_state);
 };
 
 /**
@@ -2619,6 +2629,8 @@ drm_connector_is_unregistered(struct drm_connector *connector)
 
 void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode,
 				     enum drm_connector_status status);
+enum drm_connector_color_format
+drm_connector_get_color_format(const struct drm_connector_state *conn_state);
 const char *drm_get_connector_type_name(unsigned int connector_type);
 const char *drm_get_connector_status_name(enum drm_connector_status status);
 const char *drm_get_subpixel_order_name(enum subpixel_order order);

-- 
2.54.0


  parent reply	other threads:[~2026-06-09 12:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 12:43 [PATCH v17 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 01/28] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-06-24 17:15   ` Harry Wentland
2026-06-09 12:43 ` [PATCH v17 02/28] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 03/28] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-06-09 12:43 ` Nicolas Frattaroli [this message]
2026-06-09 12:43 ` [PATCH v17 05/28] drm/display: bridge_connector: Use HDMI color format for HDMI conns Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 06/28] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 07/28] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 10/28] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 11/28] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-06-09 12:43 ` [PATCH v17 12/28] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 13/28] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 14/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 15/28] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 16/28] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 17/28] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 18/28] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 19/28] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 20/28] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 21/28] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-06-10 10:32   ` Jani Nikula
2026-06-10 11:42     ` Nicolas Frattaroli
2026-06-10 11:54       ` Jani Nikula
2026-06-09 12:44 ` [PATCH v17 22/28] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 23/28] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 24/28] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 25/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 26/28] drm/i915/dp: " Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 27/28] drm/i915/hdmi: Implement "color format" DRM property Nicolas Frattaroli
2026-06-09 12:44 ` [PATCH v17 28/28] drm/i915/dp: " Nicolas Frattaroli
2026-06-09 20:11 ` [PATCH v17 00/28] Add new general DRM property "color format" Daniel Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609-color-format-v17-4-35739b5782cc@collabora.com \
    --to=nicolas.frattaroli@collabora.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.yan@rock-chips.com \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=daniel@fooishbar.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sunpeng.li@amd.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®