From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F483DFC8F; Tue, 9 Jun 2026 12:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009195; cv=pass; b=V2gzgKqAJars6IsKm43LzhP4QWWYTUJB009+Bf32sZEemHT5YqP/dMs7AJmHoZJiA/dk0xEG/Koumfgz6emEFARUhv7wD7fsSHvkRiY498SK6HgQa1/yEkZoOPwAcAK0nqrE6k+rtzJx9ZE5nTZe5wsU1s7Zz34FX2uwBIeZNMc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009195; c=relaxed/simple; bh=6yOpB9Ash46pW/QJlLvIqQd3mfvc1i4Vkt2TOorcn2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d/nWa8vN0GTBRICjxleCf+gZoAFcJqpp6KhXZm2idykhjNfZCRJ4yW6vV60T1TNq/i2xLYgrfTGwpW8sGMdG8X+9cY9bKvevvcqE6UfsrTIEF8qqSBhQsDIEZTUbxrjdd5sl/sWJ+dZxqgmg1BIxzmap7VtOsx+CcTYm3dCnC0Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=B5NvwbUa; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="B5NvwbUa" ARC-Seal: i=1; a=rsa-sha256; t=1781009143; cv=none; d=zohomail.com; s=zohoarc; b=Yc6OyfwpcscwjjSDge3O05OI6ZjWVu+7+LaSFqY5ajmfHPbhnK5FCQgFpI0bkJd2lwc+lqYxJXR5IVvGQehDvAcKVOGUTvJf2MFI6nUnlmb4xw6jds/Kp1fFVIfjd5ehgcnObn5SW0kEoRtGOYHr+aooSuAvtORCMX6nYcQ21Gw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781009143; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=M6wU4NrUe+v4YhcSMo6XilsLOyw86ckxU6P0st+QPRE=; b=OpQOsefN/9nKtKLoZdi7rMl4tlPD4g+66jcMoJpUNYrDWFZ9gK7XakC7eUOGjMabcHxpnInvte0ECgdxnS9l5VrQ5VYdlq/J4efXT33UFes77hzsPxGMDT8X8tcy7HlSumW7QiKA4/t53+Zws+BTRRDeBbldpCd5VvorxIEyBQk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1781009143; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=M6wU4NrUe+v4YhcSMo6XilsLOyw86ckxU6P0st+QPRE=; b=B5NvwbUayVw4bV7eewT1D9psA6LdRbxKsjz0obMnlK4TMGs2xp/pMS6JIzhLK/C7 bexbDaasP6158GGU6D1dPegaR+PWTmoP8ulkUiiyp0XhIFBolh6e6Mw9dbdva4RWXLL 7/lL4xchNLU3UtpNgV8iy+au53q7f+AfL0/nC9Do= Received: by mx.zohomail.com with SMTPS id 178100914169789.36349059736551; Tue, 9 Jun 2026 05:45:41 -0700 (PDT) From: Nicolas Frattaroli Date: Tue, 09 Jun 2026 14:43:56 +0200 Subject: [PATCH v17 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-color-format-v17-9-35739b5782cc@collabora.com> References: <20260609-color-format-v17-0-35739b5782cc@collabora.com> In-Reply-To: <20260609-color-format-v17-0-35739b5782cc@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , Daniel Stone Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli , Dmitry Baryshkov X-Mailer: b4 0.15.2 drm_hdmi_connector_mode_valid assumes modes are only valid if they work with RGB. The reality is more complex however: YCbCr 4:2:0 chroma-subsampled modes only require half the pixel clock that the same mode would require in RGB. This leads to drm_hdmi_connector_mode_valid rejecting perfectly valid 420-only or 420-also modes. Fix this by checking whether the mode is 420-capable first. If so, then proceed by checking it with DRM_OUTPUT_COLOR_FORMAT_YCBCR420 so long as the connector has legalized 420, otherwise error out. If the mode is not 420-capable, check with RGB as was previously always the case. Fixes: 47368ab437fd ("drm/display: hdmi: add generic mode_valid helper") Reviewed-by: Maxime Ripard Reviewed-by: Dmitry Baryshkov Reviewed-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index 069f9bf2489e..ce17eeefc2da 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -943,8 +943,21 @@ drm_hdmi_connector_mode_valid(struct drm_connector *connector, const struct drm_display_mode *mode) { unsigned long long clock; + enum drm_output_color_format fmt; + + if (drm_mode_is_420_only(&connector->display_info, mode)) { + if (connector->ycbcr_420_allowed) + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + else + return MODE_NO_420; + } else if (drm_mode_is_420_also(&connector->display_info, mode) && + connector->ycbcr_420_allowed) { + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + } else { + fmt = DRM_OUTPUT_COLOR_FORMAT_RGB444; + } - clock = drm_hdmi_compute_mode_clock(mode, 8, DRM_OUTPUT_COLOR_FORMAT_RGB444); + clock = drm_hdmi_compute_mode_clock(mode, 8, fmt); if (!clock) return MODE_ERROR; -- 2.54.0