From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C11373F6C33 for ; Tue, 9 Jun 2026 09:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998461; cv=none; b=dmTWNZCNSLrzw20/KBNyC9Pz03ThHQhFhgploUS2AYlfJffJQ++/jz4RhibTGZ/9JLU3aiwG1FxZYE2ASMOyPVAjd+2M10k2UflCbHWPbMwOQQgdWqfx2kT6SoIuAg/kPF+5MXnrW8xqKhhcOGp92SZ4UOyG8TNCFcr8SL/Ni3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998461; c=relaxed/simple; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J8itmUFvSFDFzApe7JkplaHQhx0Y4QZ0Dkuq7NCcgD5DYDe7ehXIaCZfpgr1nH4L/miRDTNnDmin9CBDvyWybLG/t4zhS2n7LgOy/mXzU9fj6d4aFSpKnApP/47p/kSvKo3wURWHO7mXDUHtIFbrPL4UvB27BB+GLlitQkwR98Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OBv5PezH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AuCucTr8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OBv5PezH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AuCucTr8" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6597rbWb2034662 for ; Tue, 9 Jun 2026 09:47:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=OBv5PezHWAs57cz1 XWIp5N/xDSpiOHk7MJe1QJ4I4YJFx6ESrzTDWcofMItbt8yA8GQCAaRD2OllUsmJ NweKn2wbg/MEhMz/PD8Q0lLNGti2RDjGHdim6YXP3jQeMa9Zp3gvZwIxJX4fH7Xh IEIWGdi0u3MpOrvhi4/qVqkS2JII+CSuT9XSvnkxscFEBREfrwhXIBnRAQLaTr0w xIms7xyUu+imkg68mWNn8bAeo7M9DvW0/wqpaHRBDxxDtmcqV9YHpooclJcdXtZ1 jQMBzcQRbJWMPWZbpPbc8zhze2VEBT1e6edjLQvIawnUyM27u92D9FW8UHSycK03 F/Yfrw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeearjp1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:47:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9157a31ac37so605222385a.2 for ; Tue, 09 Jun 2026 02:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780998458; x=1781603258; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=AuCucTr83B2scdkIVwVvx6IXqvvfRqwBROFTbvmFCrgi4DGgBHa1zkEF45oRCyXldB WRFti6KInUzhPWA0QI5YYzUfIiKsSsHjWbTmyiFqnRz9nVaukJpd6baCHlGbQvsp+R+y Mn4F/cgYiAA7uqtHQBUD9buILyQKT5cJ4EHFmyH/xlTuwM2HgnqFcuDp+If9/QU8fKHx cZGOmA0t0KWojX6wCcCRUaoTepNJzhISZ8WpCVmeCtC0nIb+S8nlyp/U019RRxcjlo3N ZMRvORom9qSEe/15Wvovd6oHuvS0oYY2X1OhuJ/bxXpwTb6ML/IozkVtePdL4gzfsssD IwoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780998458; x=1781603258; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=URW6EouQV2fKl/Uf0dGMNDaBIBMni8VMZF+/72lJ3MVDZxLM0pej2KatoyFp8HlQqt 0E6WyQErkiFU8CXqc4xrRdYCqlUWwftdq9y+JuI4EHsOU9+L+1h/7nD80mEOlGSblhym 8hgU2R8ZgmO1xnVffK9zHTK7yPOBGQ0x3Jq+rRApWNAIFLxud6vdmG9b/RL1eU54Vt5w 3wR/+r5D0BXDmxTvss4bQYk235zjvmJxhOq6Qiwxn2LB3WXBLdW0JvILNIUVc5/rABbA TS5L9Yl0ar/J65YOi84kRYijSL9ynrfOTsR4nuwM9OtkrKbN2W4OmIkZ1BpMup4lo1If Dm8Q== X-Forwarded-Encrypted: i=1; AFNElJ9INVDrpW6OvJdFVOTjUxDelAKvTwHSIRzNfs4ce1f4/Qg9VPR5sMfpMPHhpHTH8mQY6bihO9c6vakXGnI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywou9+d18ZGWhA5ESe+y+rn508KzwvhIMYU//nbwtECHYsI0SN9 tP2zHcgxqewUApKiJkdFysxDvXprdvv08X1n2pheMV5IAMyW+qUAJGq6jnKr4m7vEpo7GtlrsGp s38spGX9KbVivO2150F5rePpSuW6XxdaHuquiwkpegrb4Ne5xA81xXJFabSc6CkUEUoc= X-Gm-Gg: Acq92OFDI6mY250jqpI3wAFPXw0zS0xSXBnuUy0M0p/8NwD/+vb5h0jzMEbpsxdL+Im Q1cgqBm53IpviMU2gCbAoJDxgJQLdO4XzKMOkqBJYSEVxzWkQ1J0ifby752sjt4uOJPjiRxEnDA JUdqg5cbyIos+N2981vB1B87+tvyGCoNql4UG/oM1Q6MUruh33C4JgFW5UyX2e9oFLyBHlvR5L1 3/909PTb1f25DcQUx1uKgOpIT78KkfEE48lKK3clYBKtVxyF34WsZuaLpK/G3UIAUZFeT6cLA3+ E1F9eldu6anHBqSh6vtzBI/UlURXYejGcKUlGlHWV78WVoZNfd2plSl9EI0lqzbCp7nNu/a2ITw +hZLA7g6ZMO/tfnTXKpC7lmhmCy5AjmsYXPpSI3kumc2P6Y8M/iNmBBaPXvv2zYZQ1op7B/eo1E +kdfairNjA/yvYxMffYQ== X-Received: by 2002:a05:620a:410d:b0:915:5930:94f1 with SMTP id af79cd13be357-915a9df2c2bmr3231751485a.47.1780998458175; Tue, 09 Jun 2026 02:47:38 -0700 (PDT) X-Received: by 2002:a05:620a:410d:b0:915:5930:94f1 with SMTP id af79cd13be357-915a9df2c2bmr3231748085a.47.1780998457753; Tue, 09 Jun 2026 02:47:37 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a00afafsm2047489485a.2.2026.06.09.02.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 02:47:37 -0700 (PDT) From: Yongxing Mou Date: Tue, 09 Jun 2026 17:46:34 +0800 Subject: [PATCH v7 12/15] drm/msm/dp: simplify link and clock disable sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-dp_mstclean-v7-12-ea04113e8233@oss.qualcomm.com> References: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> In-Reply-To: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780998393; l=1745; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; b=67mFLZcs9VBQqLt7xo15/S6j1IHHHZ3K34SenEqCrc5lvTHl07V13t6VKL+1o2FuYFBz0V8t7 2Dn5yBchox7BFFHn6ITXS4bw1TUlLoC5CURYvnEyvl8tl4vePoZanFU X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: VHIu6SpI0zj0RUzN1OXUCHL5IjfQVZdF X-Authority-Analysis: v=2.4 cv=Iey3n2qa c=1 sm=1 tr=0 ts=6a27e13a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=W1j8KJVysGQzs9t885kA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5MCBTYWx0ZWRfX5DyoOOVqZ/LE rA0ow2HciRWCLZvCQhqyicDN0wEmiYwpIuFEWVM2dXLLdeBk7rngk5d930ewpBQ7sDqllwsKg25 lBtTVl7WjyowikccQVbcIdoyhXlSWGq6ffO8QiP23ECdND1tsLiRW1oCU/GoKaFgBvdG+TvYVWW pbxo64wfyTnBqp3R671k0xMTtPazmNpk82WTBcaE2+ztlpo7ORrm8Qbi7ZL1hIza+1IGYM6MIKw l8tq0cmLs9/yw6u0ndMs0ySboulJW/B/GCvQtbawRtp2g59virTwjXv8cIc+GDxB6xRutz2Rm9a TkoRDTuOK5el0IEgDD1ATNZPisBooOEFQSW+nRwj10in8koiaBHqU2GtsXQpm5uh3XIrg1Fjx5A wtOXCk0yihHoPywRbOk+Ts2gczN1nNBR1M/DeoaRaov+1JD/vy9pVSrk/uSIFSXqatpOoA9uYKq i2lTiFVDcWioz/iU5RQ== X-Proofpoint-GUID: VHIu6SpI0zj0RUzN1OXUCHL5IjfQVZdF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090090 Move the common disable steps out of the sink_count check to make the flow easier to follow. No functional change intended. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8f472633da82..63e5b191f95c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -716,27 +716,19 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) msm_dp_panel_disable_vsc_sdp(dp->panel); - /* dongle is still connected but sinks are disconnected */ - if (dp->link->sink_count == 0) { - /* - * irq_hpd with sink_count = 0 - * hdmi unplugged out of dongle - */ + msm_dp_ctrl_off_pixel_clk(dp->ctrl); - /* set dongle to D3 (power off) mode */ + /* dongle is still connected but sinks are disconnected */ + if (dp->link->sink_count == 0) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + if (dp->link->sink_count == 0) + /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); - } else { - /* - * unplugged interrupt - * dongle unplugged out of DUT - */ - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + else msm_dp_display_host_phy_exit(dp); - } msm_dp_display->power_on = false; -- 2.43.0