From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05FA73EFFC9 for ; Tue, 9 Jun 2026 09:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998427; cv=none; b=kJsU2+OfP4dP9P48OZegHZweP7OZVuKob6k03QJ89waXeTLz5kqAXRekcQLXGk6iQRPhpSCu9msOjDC3p1gjrwXMHrWKJwNgNapSYlwhG9O8Qoue1gi4mkFBkcu5eg+PCMjyewr09Dm0EiArIOMoYBoZ99YK6XuCiSph1zKiOMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998427; c=relaxed/simple; bh=k2Fff3upCougTurRhx1qk32jaQDI5eLSE+rUossKmgQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=saW8xIVjT8jW4IgWZQSELSoy5u59SYvT8L5fyNmAbJpXRhhZEUVzryNmQjuyr2HK7CP7Rw2lBINdkZ0WSOxRjOYAmBE8xKRqGcItancNEnTkInmMLfHO38jH+iGwE2fhGXoIHebPdLm0Zfwc960fdBpfxrIlMSE9oo01Flm5SdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D+hW7hmP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K6TPNElN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D+hW7hmP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K6TPNElN" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6597rdtm1958616 for ; Tue, 9 Jun 2026 09:47:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=D+hW7hmPAwJOQP5X s5zO3sRRK6NmN5OGElUEjgIjgGVFMQoPO4+NTNn6Zr2LlKq4CxY9mfrQMqUtk0cL RBl1TbNsvsxYghlru9i8Qo3CIx8Zmqaqj6my1M261U7P5gdH3AbwTFTnePsX2RqL w2X3GtyAiRUlHZ6zLLkiXlh962PyVeJ6IjviCngCLYMndrqpasg25GXo0svumuCz 0gSy7uX5sNOi8LJfWuMiluGYr3Uia+SBF/GUUnNzQVyMQlAwOPyCIE8Q5Gpv90Z7 tjokGk6aGNnkwMYaMGZSpJYVQIv0ZQlVBuD3/zDQ/ZOYvE/TxH28qZGSj2bHfc9M 9nUb3Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epdds8vh4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:47:03 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-9157f1be083so1073967185a.3 for ; Tue, 09 Jun 2026 02:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780998423; x=1781603223; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=K6TPNElN8ZWAar1lZv3YQKIh+d+iKLQzdx1pMPKuNQRJLXpL97+xvm4nW1oUe6mZ5A CtvqgSewX2ZiVdG0z8JEQ4Fy/sKHLXYM/vx7ZCVbbPFYJiISQgTZV0CNvRmcYzKAUSdr 2UHa3/bdCnD0Ir18D7YQ0gO+wkPn4Gt02ujIY20ufM/a+Aik9cuce9Q24cOPLOLqyRP+ CcYO8i06OseqHOXKWPmDA3HrIFJojXEI+grdg8+Q6MYtFqrJ2G8KpRXVFRhkf48rQmoi f/Uc65mNmUFrgN/X/HY87r/D+QPWFXrpHJcGENDJ5zvZfVpAgYv1DtDfYdgQaqqqCdCC k0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780998423; x=1781603223; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=gONu5RoaoJXULGl6pzuQAasafpfn/5fdwD08hF6ZBNWH9SRImkY/Ni+S/YDadtJ4tn pHJW6lV5SUifHYdcfQQVNAasQkRAj2mLeDyT9ltA9ApD8ysaZn7cN4uuMXEZNzU4hnBF /6QyAXN3y2zYuzvlPwekVaLispC+cSK8htpY9yJmsNZmcdpbvEIeVc6NRhZePg3K+Us/ wuQ11zrJrCzJH896eQFfeJ4EDuqrtZuB6BTh6YEuAI03/IY4JC0Jy8GlBrauFkepujyV xlmQS1FLmNlK7OICjxUSmKKus0CXdBfBSlFJTi/wPdUz8C7UxB6aa3hz1bvugFaoew0o dfCA== X-Forwarded-Encrypted: i=1; AFNElJ8Bvl57j3zB2kiiM8jeJv1+SUYqYf6ATCmUsfm/lxPVLuHeNRqJWBelY75iDx+ziZCEmPzSufOP9C6U6O8=@vger.kernel.org X-Gm-Message-State: AOJu0YwSZ+O8y9z8J0uklIUdl5v0GAHlAWv72FTWc6pIEOUHw/vFT+JJ wQCSkmSED30b7JG2qb9j9vW17nbC6/LcJJONzkppvKoq3iiEPsHubqhITUQnaFy6R+IskruWn8Z U4Fh0vWVMz9cUlLIOffIvcT5HPlx51a7jpA4AHdq1tBdMFl7WFiNIru2+f6S04cSFedO0YMFH00 k= X-Gm-Gg: Acq92OHaNWN43d1GemRRFvmP6vNfm9Vivfl3P0GBI4VoasDdbC5tDKNfum0jkKYzF+h X4WpyC9hWkaw9mOY64OoPgke/jilmCe9RkdYyiL7jL1uzOPDZuGOdC797vM+qHfrJImyMUCkIac FWbcYpBNAUxvcMuBjK/Xe4ygtz8simUzBwezwdKNoQHMGgh2mONTI+8LTNWmusSudCHxafVV9hP zsKsBasBoOqwo7t752qTEloAJEzNTZHN5SbhAJVPKYCvt46rKJ6307Fmdbh9bpU5pZ8Op4mwTd8 /saGKOzA0RH550aCZ7mt7eBNhtyk1KEjy2uyIIAksWD/0l/Dhi9zBLYNP8KX4/ooJmshUsilNgS KVQEQUapXVXO0yKfiQFOIdPwQ7j7LpaLMW6Jy46cCpQqx/m8XInFkCKACMoNHIwbQpNJZrhS/AO HetLWJq5w4J80PglbQzA== X-Received: by 2002:a05:620a:6507:b0:915:9d08:94e1 with SMTP id af79cd13be357-915e831bbbbmr245011885a.46.1780998423361; Tue, 09 Jun 2026 02:47:03 -0700 (PDT) X-Received: by 2002:a05:620a:6507:b0:915:9d08:94e1 with SMTP id af79cd13be357-915e831bbbbmr245009585a.46.1780998422916; Tue, 09 Jun 2026 02:47:02 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a00afafsm2047489485a.2.2026.06.09.02.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 02:47:02 -0700 (PDT) From: Yongxing Mou Date: Tue, 09 Jun 2026 17:46:27 +0800 Subject: [PATCH v7 05/15] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-dp_mstclean-v7-5-ea04113e8233@oss.qualcomm.com> References: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> In-Reply-To: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780998392; l=2097; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=k2Fff3upCougTurRhx1qk32jaQDI5eLSE+rUossKmgQ=; b=xb11ZGlCXDEh1bxcp6TS59hAhz44+4Cx8Agb9A0zHrLtoMrZCIw9sWK1MQJilzjEp8GYmTx9D VTzcFfrPaTwBpb/CCAgH0oiIOEmPL0DUERHxacmp5TPFNbBMQLcOdIu X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: So9bXuH8INWlZUDafI7ftd_fjnpI35Wq X-Authority-Analysis: v=2.4 cv=EI42FVZC c=1 sm=1 tr=0 ts=6a27e117 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=TC1OlXllJ9dbkp4NpB8A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: So9bXuH8INWlZUDafI7ftd_fjnpI35Wq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5MCBTYWx0ZWRfXx9kKPUd0s53+ zZ+atSjUunrbPx+lAX+dkumIzkydpFt88p9rWrY9bcWstrU1Y3j57QN0sI9/8vDwMweKAx2EPDS G7jM3DlJxdLwsUJqHSnIPZdoi6NzCZNK/fhcNjTqphzscIzCHDwo1lbZ73xr7FdCRHyHIk4fYw7 G5nKK3406tHAYppqX6FVWP0cpMLsobQRaCkKrkGq4dUodEXbEuDngvtuqHzMe3WkFTOX8+6DCX6 7asVOwWYCLeCe42YMPmexhhu5LtPgJSlKUywJvjzTJ5cX1vzxr5+ZlIBVKWkcVsPcRYfy52z66J +jc8hx8/u4J3/ubztcJRdd96HhS20s9hmDuWiSeU+USuYtey+tvG8vIxC03sfnxaAw+SUC+mnJE AinKnorchQWMKalNhe8QGHlVK5ESd+3OINAuwGE9Yd+dsveia6h+u3+XmvZ2oaKgnOBSnN2uKwv Xt6wgD7pCZjguhJ78zw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090090 Refactor the MISC1_MISC0 register configuration into a standalone helper function to support MST. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index ed2ba47881fd..71d45b2c4daf 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -458,17 +458,13 @@ static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl) ln_mapping); } -static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, + struct msm_dp_panel *msm_dp_panel) { u32 colorimetry_cfg, test_bits_depth, misc_val; - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); - msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); - - test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, ctrl->panel->msm_dp_mode.bpp); + test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, + msm_dp_panel->msm_dp_mode.bpp); colorimetry_cfg = msm_dp_link_get_colorimetry_config(ctrl->link); misc_val = msm_dp_read_link(ctrl, REG_DP_MISC1_MISC0); @@ -482,6 +478,17 @@ static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl drm_dbg_dp(ctrl->drm_dev, "misc settings = 0x%x\n", misc_val); msm_dp_write_link(ctrl, REG_DP_MISC1_MISC0, misc_val); +} + +static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +{ + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); + + msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); msm_dp_panel_timing_cfg(ctrl->panel, ctrl->msm_dp_ctrl.wide_bus_en); } -- 2.43.0