From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6433F1ABF for ; Tue, 9 Jun 2026 09:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998430; cv=none; b=gNL4jfOtHgqJqOeQkCaoh4V62u0G5uB+HBZNKOZY9Rm+pHwZlnuNI3n2EI+cLXSndP5C9+jDjtLw7OUopFOxE6ZeuoNbMKZjkyPj1ONnH7/jkV9YyOjavzuKYCOPQlzSeYr+HycbN3rYGewS9Q0s+eMfgZltfmwZnAMUHmVcpWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998430; c=relaxed/simple; bh=ixgmYJIVCgIesw8IPUX+/UcnW6cdOBjM+XPZmes1+Eo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uX3SWU1BRSmvKTMBDfoZMsDegvusIM5eR9SOX7lxE5Kdoo9pRUkLjfCDHDNv8f9uAXXRCrCYcR4CXt6RH5/LqMx2TjuHqHVrlWed5bWFUkqkBAD7qeFp5xif/7r8pIwaUNdbUJ2qZ7fvTDt2TZ0UXIeVX+bYt9i9BlJ+0cOPWn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BjptCqzm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MNuBV7+b; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BjptCqzm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MNuBV7+b" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6597rh8c2034898 for ; Tue, 9 Jun 2026 09:47:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=BjptCqzm590Fu46S SjV8Z874hVOI+rjjekLFtOZXE+FSxibiZiuAXMkC17tU4aFExizK3ZTYazEtcJZm 6SwzytzkilEe5Keoea2/p06+1/aeI4NSX+Uf32stiHlMPAR9zbDTNU1QSa8H7RYE e0xvFhAc45JRq9zEeTWzJKj5YIVeyDfrSY2fPM0c3Xn9xjo8r2Xqgjrv1hmwTKRA DikfIdaAnQJ/pho12WAh3nPuKTnh3voeaLw2AFxwUeIfMjXVORurRvUfcVQ1Sh7U nn6EdL7a873RSbXiljHrlWu3N4ZqAxJ3gkLFkxJCJEefSWWfilCFVnJQeSXvQypt J/woNg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeearjkq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:47:08 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9157de5360fso1343286885a.0 for ; Tue, 09 Jun 2026 02:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780998428; x=1781603228; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=MNuBV7+bwW4gg9aoGCl3Y3fGOc9IpCZVHI28aXzNDUVG0RjTFkvRKCj4tjWj+kBzBq mV+U8wSRKdmMtmxm7hY+WCRWoSfiTEE0qqmimLNMp7nauIEkBmgDJG+FzvDTvn96UJDr HO3F0Y/aJmNbPb2U97KxMrsXHq6Yd2PZjdK/GuObB5Yxu4aaBnKJCz+EIot8Wyt/j9dj igNijsxaGMmkBkRTd/QzNFUTS8ludWwlue/GIIQ9x0YkKdPqvGPZZy3bIhz3LTsbTlRb cJ+3zzYr7pk1sPaGrOwiR22xLvOmM0MM8iDj8k9lGeuDYYPRJOf3auioHiZxiwftan9P 6O/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780998428; x=1781603228; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=AlI/4tsYHJqyU3ZVpiNLRLQbxDB1v/NdRT0A4HUPQSjfqrp+lM7gfGqsJL1i757EJo 5F/ZKeSa/xTWp7SlWDF3Ote26uon1ZWJRiM96ttNbS2ioFTVn7yYxHe1EyGhfeG6yJl0 5hjh98xT6BKBVvgdCoVtaUvbKvLoxOA9ZNjYew3pfXMKVcTgmzX6/lqlJYH5fVRaocqK HAdDyaK7Bq+xw4otU+EVzLBhM2ucpF8CCFTedlWIfsWPy253pCEZZ+S3c7eDvdjILhwG 8MFl51Iy9T1PgCB25n+PzhNgCFirT2ZT1ppNrxvOqRYU/OZgAUKyxG0V+KGYLvRh0uzf R38A== X-Forwarded-Encrypted: i=1; AFNElJ/WiUx9QKK9pSCSp7stF0nrY69gb5tmAJ/Fk57RMohWcgLxaA125e7p6gX6+V2263Y7fruUyGg0O2bXAYI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2pyFHrXIg7fPHMu0q50k0PFomQF85V2WAxUHyHVK7me9xQ9je nB6NCpvL8MfQ9asEbmVLda95S7UwM2jY5wjvyJqA6gLxQVd5faoTz2Kr9C6p088IhoG+RJOo+NS TmAKfPMGPnGv5qjI2pOvkfPwTsjcSDylWH1hrdXJ0B6ubQvESSkheoKabtHlEQLsYZNg= X-Gm-Gg: Acq92OHSodFHRLv35zltO5/gUha0UC88oGU7EoBfU+RrCY3KPlNVIot8ZaHuNdk9rSF tXldLvGp/M/9LMRwYRJTg4cpeoirXF2jxAPkJoUF4yqkWln0/7HEFaPbzkc3ynaSMTbCmh0yZOO v8botHTkyeoS5zm8r6sQtRu5prOInDg2/YH3AYf4lAXzgM9ttbGk+sUdvrx0TAPmVlYyXNwuFZu KVmFgrmG1ujB6Hm3mLbkAfdMwD0xm2ePxyg6aZWecArqa7QBpLH9JD4Ra1+ijeMouDrtYMsJAAc N/7Yx5pqJv4QtTBihenJtevGkv2SQItFwJfxTO2wxwqEAJoNhYKDF6sBF+oNlRUuv0e3D2W/M2q AESL8iIKs7oIGiTE12KUqA1M6w8qezHBZeLchDIDIeRjtxuHVxoqo1PLbBsEdtdbL9plmcv/y+O bQZOM2CcXhJL5NedV4TA== X-Received: by 2002:a05:620a:4150:b0:911:fba0:6d09 with SMTP id af79cd13be357-915ad1d400amr2109080085a.20.1780998428116; Tue, 09 Jun 2026 02:47:08 -0700 (PDT) X-Received: by 2002:a05:620a:4150:b0:911:fba0:6d09 with SMTP id af79cd13be357-915ad1d400amr2109077185a.20.1780998427706; Tue, 09 Jun 2026 02:47:07 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a00afafsm2047489485a.2.2026.06.09.02.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 02:47:07 -0700 (PDT) From: Yongxing Mou Date: Tue, 09 Jun 2026 17:46:28 +0800 Subject: [PATCH v7 06/15] drm/msm/dp: split link setup from source params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-dp_mstclean-v7-6-ea04113e8233@oss.qualcomm.com> References: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> In-Reply-To: <20260609-dp_mstclean-v7-0-ea04113e8233@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780998392; l=1402; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=ixgmYJIVCgIesw8IPUX+/UcnW6cdOBjM+XPZmes1+Eo=; b=cwLlDtMB+tR/WNLTbcbaBPeGshrJL5YHvytxQA6nVZvm9k5TpQRKKVCK7YY6UwRqok38qz1YJ Oelf+qdAe20DObx4b+EmSxo3RijvO0qKxdXDmMwP5DNx/Pd45ZvEhSa X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: PktIyEIqrGVzwtO0EIyIMvyy8gDXBtRC X-Authority-Analysis: v=2.4 cv=Iey3n2qa c=1 sm=1 tr=0 ts=6a27e11c cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=saXSvH3Ee-fMY4W8qR0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5MCBTYWx0ZWRfX+hMrS7nyKz+T RkVCl9L78bBti5xnqMYlw7rhZzQRhtP6SdnUasvrkPbAAOV2xhxV25B5V6LCIq5VguMfbVAAegd I4PBVd4wc5GEyVRZHMbhNRDZyVNglfcfTak5rWW+jztNJ/ZWcaCF3ZVRm/PstUec77DEYvtQflj wb+XBYm7Zmoa7tQ1eNFY33rvqcA3eDN8fZ7fnI9S7m9EuQtdVSBvTYoFP01tHd8jbnDjGxpH1np JFYFn8BctRrR6JmB5BReEztL6UZFQQXkeLcyfwuIDOdkDP1jKTHscPk7zO6Xd2hgG9Ph6qClMxz oDVnIRVC+FTcGiClatBENzkWjQJXC4DkiWT6xGp0W28sjtS1/Kvj7Ry36vwCalAtMLOOizwLcrw CSUUotQgrQj4H8rNWRTUBT+TdKVUO0I3+bQ9uhbBHgbfJe/EBLTOKD7GaT5ZTCHMWWlDYf0L5Hk Ae4zvQJB38nDGVGa7kg== X-Proofpoint-GUID: PktIyEIqrGVzwtO0EIyIMvyy8gDXBtRC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090090 msm_dp_ctrl_configure_source_params() should only handle stream-related configuration. Move the link setup out of it so MST can program link and stream settings separately. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index 71d45b2c4daf..1c2eccec6ec6 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -482,10 +482,6 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) { - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); @@ -2551,6 +2547,10 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train */ reinit_completion(&ctrl->video_comp); + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_configure_source_params(ctrl); msm_dp_ctrl_config_msa(ctrl, -- 2.43.0