From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3092135675A; Tue, 9 Jun 2026 19:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034906; cv=none; b=YB78HwElfkbiaWJiCutmsAcPw25PropiujJQaTea83GkCwNdgKMsAbS+/LsfCCXac2I9HPEK/wvgV5DZL88R85MX96vkgRiTT1L6Vu/nxCgTvKntMPUhIXfbw73HThBxG+1SB69I2nL7MS1Jw9ow4+hM5SIY+yPFH8BAvfw/h1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034906; c=relaxed/simple; bh=kEGtjVh7hYSVEwqOuOScXrJJdKHAF2HV0rYjMXUk3Nk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DxPLZ7/jNaHDBzdQE7m3JNQtROmplT6SSYEjr/s4oxIcc9mcd65/BpUoRnh8YiYbKPzCDWeIQPhdVsizohH9hdZiIDh9Pue5UHbEwcMhZ145H4DZRxa13fRoGzYPcWIPS0iRltyAOyddYX6gSyt5NIMCT3fD7MJh6kh7qbfBHbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mrqlhrls; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mrqlhrls" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF1541F00893; Tue, 9 Jun 2026 19:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781034904; bh=euZno7GZr+Jmg5WizSgIMbhpNKl9ApCStT4sFxS+cFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Mrqlhrls3LdqaIVU1g64Wu2SiYFz2mLopQXvHtAsrgcg3Pc89rmXeHrO3vqEWV3YI 03K6M+reJZaQZ/WPOOu4i9P2dZYGPrl3L9vpQMZioWuUe3tzh86bBDnBDpUmYwsBWK XjfmM0s6F7eKxLySUq8CJ+33N5wSu0d8sCEVb5RUaTHZbxeItD7Lz3IugeVwHSf6po kyBprH79O6I/lEjWZs2t1G/AzfBW5qWnruqgHHqFPkqqaYq7UlMH4GiKVppqiyzM6n pcB+TPZUZBkGM63FTH56XNFiIAcjeZXwyVeMW53Jt4M0sMoxRNO0Pz1CUEXiIMTNSW Czw9Sse+q86ow== Date: Tue, 9 Jun 2026 20:54:59 +0100 From: Conor Dooley To: Guodong Xu Cc: Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: dmaengine: Add SpacemiT K1 PDMA request numbers Message-ID: <20260609-freeload-luckiness-7a143eae62f4@spud> References: <20260607-b4-k1-pdma-req-macros-v1-0-5b2a3955007c@gmail.com> <20260607-b4-k1-pdma-req-macros-v1-1-5b2a3955007c@gmail.com> <20260608-dazzling-hacksaw-dbe84766ec76@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ss8ao6rj68qSdhm9" Content-Disposition: inline In-Reply-To: --Ss8ao6rj68qSdhm9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 09, 2026 at 02:55:59PM -0400, Guodong Xu wrote: > Hi, Conor >=20 > On 2026-06-08 18:33, Conor Dooley wrote: > > On Sun, Jun 07, 2026 at 01:41:30PM -0400, Guodong Xu wrote: > > > Add a dt-bindings header that gives symbolic names to the SpacemiT K1 > > > PDMA request lines of the non-secure peripherals. Device trees can use > > > these K1_PDMA_* macros instead of magic numbers. > > >=20 > > > Point the spacemit,k1-pdma binding's #dma-cells description at the new > > > header. > > >=20 > > > Signed-off-by: Guodong Xu > > > --- > > > .../devicetree/bindings/dma/spacemit,k1-pdma.yaml | 4 +- > > > include/dt-bindings/dma/spacemit,k1-pdma.h | 56 ++++++++++++= ++++++++++ > > > 2 files changed, 59 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/dma/spacemit,k1-pdma.y= aml b/Documentation/devicetree/bindings/dma/spacemit,k1-pdma.yaml > > > index ec06235baf5ca..0d4ac9849e27b 100644 > > > --- a/Documentation/devicetree/bindings/dma/spacemit,k1-pdma.yaml > > > +++ b/Documentation/devicetree/bindings/dma/spacemit,k1-pdma.yaml > > > @@ -35,7 +35,9 @@ properties: > > > '#dma-cells': > > > const: 1 > > > description: > > > - The DMA request number for the peripheral device. > > > + The single cell is the DMA request number for the peripheral d= evice. > > > + See for the list of valid= request > > > + numbers. > > >=20 > > > required: > > > - compatible > > > diff --git a/include/dt-bindings/dma/spacemit,k1-pdma.h b/include/dt-= bindings/dma/spacemit,k1-pdma.h > >=20 > > Why does this need to be in a binding when there is no use of this in > > the driver? May as well be a header, particularly if these are numbers >=20 > Thanks for the review. You are correct that these are not referenced in t= he > driver. My change to k1-pdma.yaml should be dropped. >=20 > > with a set meaning that are lifted from the TRM, rather than made up > > numbers to make a driver work. The former seems likely, given you're > > indexing from 3 not 0. >=20 > Yes, it is defined in the K1 manual [1], see 9.4.3 DMA Connectivity & > Assignments >=20 > Link: https://www.spacemit.com/community/document/info?lang=3Den&nodepath= =3Dhardware/key_stone/k1/k1_docs/k1_usermanual/9.Top_System.md [1] >=20 > I will fix that in v2. Just in case I wasn't clear (and I think I wasn't), when I said "may as well be a header" I meant a header in arch/riscv/boot/dts/spacemit. --Ss8ao6rj68qSdhm9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaihvkwAKCRB4tDGHoIJi 0quDAP9NVs88iuV9CNHJrkUTyg0JS0+g4jZfML658Gh5VCV4AQD9HAvgmQaWFy28 V+fx0E0a2bXDRTY3o0eZOk3dv/55WQg= =3h5W -----END PGP SIGNATURE----- --Ss8ao6rj68qSdhm9--