From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21E036D512 for ; Tue, 9 Jun 2026 12:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007487; cv=none; b=oLcqV+h3/UCgqT869I/3fiTjfbFU4KhRCTBzKLOPYXP0FC2Bz3EVRbSAIjeEFjdZfttdMtod6qliHpIfySJYSXpqj4Twfttx+y6J9eincG2qnvJvgdQwvYnyNd5hsTKDU/ZnQAsh+fQ0bgQCKspvi97ZtAh9tJMf15DknMVA9/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007487; c=relaxed/simple; bh=vpvheKlTBoot2ZMcih6CkjDKeodophG0KBV9Uk6d5Mw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JX0c36mvFmVaTwnhy7yy7OdsieH+Ta0fdo9pCrKM8LIvbm7AjYLfH9l26HUx7nyTzh0L74j0fORuE5u89esLcMZ/yyHHRt/JoCZHZzUFa9ewS43Jcx0c9qtH8qtxNQLCue4yvAXXnhh2YQUjpcyAncqjc+WYZsgk5N/RPoa0u8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VVF+vU5z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DcTg/ir4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VVF+vU5z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DcTg/ir4" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659BndV72155570 for ; Tue, 9 Jun 2026 12:18:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CYtc7yUlRHBMopjDIVJ27EmySD3hBTepJZ+260m7f5A=; b=VVF+vU5zM0DgAZTu sKgc0MpPCzCptJub3hVdZYePRLpa7B8DAnLOt1FT6OqGL7b19WC6PiUG+k5s4wtz a/JZSRLgNXUGHamVyP0f13/e3cuebxti/mK16vQwSp3HqIjPWri5PXphJ7Zc37Jj DzQF7IY/5+pmu353g6OF1ejpJP84uGHJxVkSU9kgVhbobKWtVBzLTE3mcU/dNJUn e+c18jdzyCMQOrkG72JVRm9EdtTNdNNOLJDPAcFR7sDJ+zgvfHtA5u2xVAZNopiR tm+W31lXYDi/u6+zt7NHuXGbWouLeJzOdWFLhwKBC/OZrWOJREdA81gKmFGEHlV1 jjv8hA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3jrpq2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 12:18:05 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5175a1e32e3so152283431cf.0 for ; Tue, 09 Jun 2026 05:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781007484; x=1781612284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CYtc7yUlRHBMopjDIVJ27EmySD3hBTepJZ+260m7f5A=; b=DcTg/ir4XxreDMMpt40gvJapWWeyhRqR9eyx9DeKA8xh3b73waOnCDubO81dmonHu4 GI2AihG2j2bCX5pNwsQwmt7/j3WkYQBCUGSglvFnfUmvUnUqS9+ASyepLCARKFnOdPYC J3S3NC3WpDkJ27NZau53SrBW+9SDrwxw2JcBBJejCOdqSwJgXoFnveJ80Y7Ij1ClOCqq P8zUtlHjTgJQeFfuWDMSoG97yHWn4NM8KbXbUoVlwUCD/Oc857nnHtHV52dvKSPHNgbl OHd+AB8ZBzXRYwqEcsSlaQfIbRXtSNTQm1+C4UQhpYDqekETTKafnxqP8Ank8k166CV8 pqeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781007484; x=1781612284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CYtc7yUlRHBMopjDIVJ27EmySD3hBTepJZ+260m7f5A=; b=nSwTzgJeCOn2ZSmdYzt+VF/tlk+vmDACXDR/9zV0AyOJ79oIevZHays5xOd/Vitv3R 3laMio4/sjPz2piKrBX9mtCHxWDmEUT8pfsgkruwGNRW1IFwqJ/y6DB9TuzoiGhOrXSu eSeBsFCNY9eivogoHtbl8bpY3J9aE6UyKjyx4tA5XtwFsnupJIvcLZdFmmnD7RoYrKR2 7JejuVflNHa/ySxubyuLTOXTW1S8lSeZz/PBiq4jeHYmud+9lOGJupL/IoO1ZkLFi69I CSe8gkMcXE6Z0J8pAgYvtFr6dOWSTnDiX4zCbGiitekkNHDUSGaGM7rwFb8YNs5+/VAX GDQg== X-Forwarded-Encrypted: i=1; AFNElJ/OG15+gdezCaDCJtyzpyXKP4cacOojXGSG5qZyBCfuIcIR2YII1niy6usxYg7eS36Mkwh70Q80xeQahas=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/G4ke/58SDV/wEaJD0wWp6vqX8YIBjGdY/PN063ez7lnaQDp+ v7WKsppZ50EuU7yfXrg2Tk7EDXUm61TOAOtv1aD/hkQpGDbVzlRCmIv846Q/+DgBSXJ5DaEskkF yA9/DG5zGm99YS6eQJlZzFl2cHGEbn+93F8mV944dCNMZLL1LUEHi9av4r7M2orTGdhA= X-Gm-Gg: Acq92OFYIOzpAddhMlGpvRZoHrO+OsZU3GOrtRg+iqqXyzUaX5yduccqNEptrZsnv2i ZKRJyIMOjSUQJqQzPdQDJuldgtY0ERU7viNPcoYIWAPuTV+xIayWzHlxkU6jZ1H7mfHKCyTaBrT AYXbySvPvaZouCvo2POnE5uFQs58STFFAirK+tpR7fUdHALBinrm7t/AZlHRiO3c91r6NQsoiKG 3WMiIOUC3zDqM3nC6DwLUE83c/HCHPhyadbhjm+0+LrLsqMrf3kqNY0CPldXefKpmZ/FAkqcb/t PFVpCzPUucqG9WVagD3Sl19fd6DJS4j3Tmtr4lmvT8oDM1jfpMXzeBIPIyoSVXcHzfvZdse1PNv VygHtLfD2wljOi1wVQ1a//ipph4/sfqXHWWKLVceQ2cwbzzrfyAff6TC6H+HzOg== X-Received: by 2002:a05:622a:2516:b0:516:ddfa:23a4 with SMTP id d75a77b69052e-51795c8e01emr311466531cf.41.1781007484282; Tue, 09 Jun 2026 05:18:04 -0700 (PDT) X-Received: by 2002:a05:622a:2516:b0:516:ddfa:23a4 with SMTP id d75a77b69052e-51795c8e01emr311466011cf.41.1781007483889; Tue, 09 Jun 2026 05:18:03 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:7c63:2aa1:b7ca:7546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc412sm64099018f8f.4.2026.06.09.05.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:18:02 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 09 Jun 2026 14:17:50 +0200 Subject: [PATCH 2/2] gpio: fix cleanup path on hog failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-gpio-hogs-fixes-v1-2-b4064f8070e7@oss.qualcomm.com> References: <20260609-gpio-hogs-fixes-v1-0-b4064f8070e7@oss.qualcomm.com> In-Reply-To: <20260609-gpio-hogs-fixes-v1-0-b4064f8070e7@oss.qualcomm.com> To: Linus Walleij , Bartosz Golaszewski , Mika Westerberg , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1110; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=vpvheKlTBoot2ZMcih6CkjDKeodophG0KBV9Uk6d5Mw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqKAR17xZyEC8KmVRAnb9cYVliFx0Y4/d2npMC6 ip3bRmpLd2JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaigEdQAKCRAFnS7L/zaE w3ZREACREzkHDT7I2kGq94l6E+Jcc/b4P6pswSBraw4z/LD4RyyEM3rmlkheVvBPDbSNCCng7D1 8LxgSWkU2lQvAVhq/yGErojuG5vVwLOI6zAPcm8arw6jcsvgdVwU8035OkXMpDvtDlE3GiRnaAe IXxM+RyLO3mxsdI5fVjWLaaMuCA9fOuPbdJSYtsPhCnmtxSPEcHpQZJYooxjT2tp9tCiFCrJL12 ubSQC4OvzeZ3HcWjlL1DexLuDeY9o5/2se6exU5NGT9ElSqpQTL+8Pa3FNnrAWOtOGqrHJ8tNWP XXdrOFDJ7QM8C0xl2xHU2Xt7VGvShslYhVyCXP3186Sbw1iCYa9H4pbFpo6Kp0sgWhRzAg/OmfJ cc42oRxwPih2qagbiSCgMASCjO9RrFCd0wMuTeGEEERPMLDLcnYC4MKPKyIzPNUJX5Q0uN+Huzo IyeNxjqhAJ9c47f02GM6zN6BeBbkxS6PKubjz5z8BbmBNA2lrDFnWnAg6rJEnpIAwvosWZwdhkD x1ND0E2ynUZeAz9O/n10uWGTvCKV2jamSv9ZUQT2h56oDvWapO5db9JsczIpkOzsBvYXDTmCijb pyXyHOlYEfC7FspzHhgWAwDGP5tx3ec/ED/Fj6bw2579LYKER3MtiqyxCfqIxQNt7d9+xeTGCCL 1uESGmBydHzwINg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: aEM7BEHD8Gu_ejuAVjiGzWFK_QdtmET9 X-Authority-Analysis: v=2.4 cv=aa9RWxot c=1 sm=1 tr=0 ts=6a28047d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=c92rfblmAAAA:8 a=3oFxPOZCAAAA:8 a=EUspDBNiAAAA:8 a=xCZgURHeKwfaKp8teoIA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=GvGzcOZaWPEFPQC_NcjD:22 a=LnykDHEuWDBM7K51tcvE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDExNiBTYWx0ZWRfX91+Cl258j8Dw xpIJ3LpWWZ8G4c41K7t71OjJJLVe3cJc25Ni7VQfv+vR313C7hffk0DN6vep8JR/4ECleWInPZB pAshe8WKX2SOphOwSvt6/9YsVe6rclEit4I4NMR7y+UibYsvj5WYV+t/k1QbtcyJV7JrrmAUL9W 6Bd9HIj06ogTZg01rGeuiEpk2IZHINDYzV7cya6BGlkTxwNFivKQMyFAPr18YNTDLZBQb2Xy3DB O8A+ih0F/DOMm/tiTLhrRglY9E1OL7Ec8rfL/7vt8wCdf8K++S2sNp//ifSYh4ADLfStQ1IfVKE iaKEXVCHEVK2vFlSW2ubl6o7NShvEy/iO6yVvV8HlDAWEYxkvDgL0d5IEfQiTocYsu4510h+1eW eHaXrSkG4/vfkNBOBdgkEzfPFNRe2rxlwGeHDaxc7V8GoKArWK8hP/ASNhyzm/HHpEzQwSmfmDi BMzxHysVFSb+P/bwhIQ== X-Proofpoint-ORIG-GUID: aEM7BEHD8Gu_ejuAVjiGzWFK_QdtmET9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090116 If gpiochip_hog_lines() successfully processes some hogs but fails on a later one, the error handling path in gpiochip_add_data_with_key() jumps directly to err_remove_of_chip. This leaks resources allocated earlier for ACPI, interrupts and hogs that were successfully processed. Use the right label in error path. Closes: https://sashiko.dev/#/patchset/20260608210108.36248-1-dan%40reactivated.net Fixes: d1d564ec4992 ("gpio: move hogs into GPIO core") Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1fc7ee9e1158d21f7c75e6cb95c33f0af44835c8..0cd79906d95c60035db1f6adc49bcfcfd3cc751b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1316,7 +1316,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, ret = gpiochip_hog_lines(gc); if (ret) - goto err_remove_of_chip; + goto err_free_hogs; ret = gpiochip_irqchip_init_valid_mask(gc); if (ret) -- 2.47.3