From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C995A79B for ; Tue, 9 Jun 2026 00:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780964284; cv=none; b=RTh4WcT89aFRfAtovMTASdrRuXqqysDK6mQ128OuwoBr+323fe+BgykCq8NqhgKqqSdqyU+l3JTzI0uYJrERVcB5r3WmYSOQ4M6cZNBzZ4paAgQGePEjgEWMWdSG7tFHEH7mC1l0l0HRVwO/gKEk7sd2CE91J3IqnA5zCm0jcS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780964284; c=relaxed/simple; bh=/BzsQnwRFrK/hqvtOlttIJXnp8XCgsxJk1C9zu5/bt0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cpd2lmMQ4qp3hEclZXPuK8X7hzSlgFu2iKq4nE2V4Gfh/LlhQoaKtQdyxOcbGn8Q3MaVLn/WLQw5FuLLT4SdsZ15yLF9fuuwoVPWzFeLeuGa1nXJ9stvFTeS4wNRluKAhSEH3DsxRsnrFOfRbtrax7JyDe8tWEfwP3tSfvlAFvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=WmmoMbXB; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="WmmoMbXB" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-5177ad0cc67so39585451cf.0 for ; Mon, 08 Jun 2026 17:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780964281; x=1781569081; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MJrcrd97RrpK34MMckrW+u7pfPo1y7Snw62FaBcwTvE=; b=WmmoMbXBvNvVPgbb71bETL3s/1UKzklb9atQ7RRspFzvrzVQBRXbGcyZov3LFZOTQH bYvFUpR/jxHCQ+HNX/mk+5UL06R9iDwNyiggJkZ/MkEqyE9FiKp7C9tpLgzpQRBaHETd ntSPDBeT/l315+mhftpcN7Igk+i2Snr837FZVL/O0VWH6RqVSaiGe46D8DbLjPbLCOjh oOQj0C3HcfqT1rHvZlkCQtB2KOCLXc//DYGshbBo1JUYQwD9YDTHuKMMHRGAdZiIIMdD DGDYKkXe/MHhKQyenuEXRYsmzsEHKbbXjICic1s6i+BiTT0X7p/V9MrNtNrCdViwIu/w c/hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780964281; x=1781569081; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MJrcrd97RrpK34MMckrW+u7pfPo1y7Snw62FaBcwTvE=; b=dCFigG2REtiuaQe+4Gd5p89I5hOl4S4NNIE6D0vbqa35gb1GkDXJGsQkzX7trAQldm /RaJ6WF9uyxQbJtC7DHni8GtiUBi72hiAhOxDdwWWRn5LU8jBChWuEd9rHQwZdLHHG9H 3Ze17Nfc2DfVOOivesYb9cavbyAAcYb0ftvt68jbdSNIBLy+hexQE/8MVofn15MGDaec dCwd1iiN/XS8IxJgQf6IEpjeZWhGhFqcUXZ+XI6hrOLxj8lh3mQtqG8N8vz9Hl7ZWwa8 FSyVtoDOEcXHOo7hNhJBabUzfNROla3VB72ZVo9QTVSBGBhF6dHFuyHVTqeYgRHdvtSq dM4A== X-Forwarded-Encrypted: i=1; AFNElJ/X3LsQhsmBTHQ1+mPSRzmAilz30qqAeuP7OjWgwXZFuDMfa8fDK/XD7tlsK1htpVEZJ+uFKAe96JePrl4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0UzjezQ4cNUtq5qUssz9nJaTJqcR+HJmmYdYLybjxZoA2zcv7 Wr9EFgyjgNEGW/htT4DE4RM0SRciEgyaKbcw6njYWCd3Hf5k4lZu0wvqy7eUP4JPXog= X-Gm-Gg: Acq92OEyepu9jNFMRzaP7+glz0XZ8Gyx+Sh0kUqDNKxkpJmYQYIy6thto1UDS//XXyE zD2FR68qBqOnbIm9HGk11Z4hY9glNjxnmjg2yVaibdz8yuY4nsz8/Cww1fyAPkafzd9PCKIy3sy YYS8ecFkH+yUnsJpuuIhY2ZxC6uSDBxDScgAdOw439nCMBENhgFmfjf6JeR505bQ4qV5GIP04Xq QKMaplwRZwgW9Z+pkziUll470gjododtOqLUbN1fPeQSQqPB8LAuDOccOyBqD63Qadb4Wbhv/MQ mm+Y00UJpAj5DGuPoxSm311naM2k24e23/Mk2lFBUCcIsL6UvEofK/sz7weT8cYiI1dK8BDRZ4j HL/ZF3JWeirCcDITE9lh+YV6ud+bxE1ztylf2SxSXPqi7ol+1Lyjn3XqQDk0Ek37IYcYC0vxUO9 6zTOvhbnKc03lLk37jvckGzyK0Sp8KPghZRUbuEcVVI5RJeAC2O9HmO3u0VGekMzLoDwZR3d3Ph f5KMdb5t1I77ZGKKj5FhI8e0d8= X-Received: by 2002:a05:622a:1b15:b0:517:8f31:df0a with SMTP id d75a77b69052e-51795a08705mr257391641cf.8.1780964280672; Mon, 08 Jun 2026 17:18:00 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c4d7absm165652141cf.11.2026.06.08.17.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 17:17:59 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wWkAI-00000000rFN-46mU; Mon, 08 Jun 2026 21:17:58 -0300 Date: Mon, 8 Jun 2026 21:17:58 -0300 From: Jason Gunthorpe To: Ankit Soni Cc: Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Leon Romanovsky , Vasant Hegde , iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommufd: take dma_resv lock before dma_buf_unpin() in release path Message-ID: <20260609001758.GG2764304@ziepe.ca> References: <20260526111034.4079-1-Ankit.Soni@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526111034.4079-1-Ankit.Soni@amd.com> On Tue, May 26, 2026 at 11:10:34AM +0000, Ankit Soni wrote: > Take the dma_resv lock around dma_buf_unpin() in iopt_release_pages(), > matching the iopt_map_dmabuf() convention. dma_buf_detach() acquires the > reservation lock internally, so it must remain outside the locked region. > > Fixes: 8c5f9645c389 ("iommufd: Add dma_buf_pin()") > Reported-by: Ankit Soni > Signed-off-by: Ankit Soni > --- > drivers/iommu/iommufd/pages.c | 2 ++ > 1 file changed, 2 insertions(+) Applied to for-next Thanks, Jason