From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA6D019E97B for ; Tue, 9 Jun 2026 01:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780968117; cv=none; b=l0O582ape9Za1+SpsDq87mdXRKWA8SDqiAQbJJhax+5qW1qD3oP7BF5QTEtYgfF+Tx12FI0hCgI43nneoD0hMitepCn1uig2IgmAiRslOpxm11pm1GgP1dRDV705xWUQYKwOUXOy8trPXlhnVxIdwVr1CE1nMO3qGwDVFvOjQpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780968117; c=relaxed/simple; bh=ClVmOPRDZbczQeQTMQJc0gzFE+32iWL1PtVo27XcIw4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=E9EDPNlnyWaUz0P/b9ns8sXbLfI2pDmRREF8xrcBr5GI9uTy3nENEQbeAhJFB3tMAYWlPh0tF/QrwtH1dpoUlbREGEnPFEJAeBrVpyRLJQRKt+x8TTqqRhKm6YKm7MbgkhkzV/pdRV1bwjyFrHzbzi5XIqXzcoI6EkYjbmrSpus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o2rg8Aof; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o2rg8Aof" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-304cf518c9dso6096800eec.1 for ; Mon, 08 Jun 2026 18:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780968115; x=1781572915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1T6M3q9vWUARIrQ+Jhsac3VXCz7mYnZ7/30iC1lOPm8=; b=o2rg8Aof+GX0BAkXmin+9+kdWDKN5R4v57nMD6EazZ9RRqUY7M/M9ld7wHmjGyoA4R o10bk4QyRiAEtBHi4Ad2/+ac7ChTAqP2JKVSORkc7Y7yTS6uOzcneiSUFsyn+Zcjxho1 MdJYZZc4614iZteo7teDhuLhQ5tPeei7/NJzqaDMyUZ7ctgNkarvtEuydobtIB2wIW2L ecYsBpnzwNiYaaL+S/L1guIWKuXr4vu/YbWA+3/FJbetOsDRn7zunYH2j2L8lVHFcFuZ PXcc/Ns13XjYjXlfnn6RdkzokrdJiWhTCwlZcIDNTMm/Gs6TZrDPywsgCR0dPYJKND+o 8asg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780968115; x=1781572915; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1T6M3q9vWUARIrQ+Jhsac3VXCz7mYnZ7/30iC1lOPm8=; b=CW1vx1LX/rZjm/OnLn44T5sXjWfd/NfIGWQ8QreLJ4Rs/MJwiwuavKFFvLRqGto/ZV +RRWobWMS6YRs9UzQDu617JiCmYXP+9nqrGQ8oAapetHylE+/AxSsaHS+8JEsx7UntNk gldoR8YMMtLUjTm/d7GZvvwCppf3ooKf0hbskZGaRgexiOqcSHgZ9j6ReUJLAcTHsj6+ BxfOypxJsbFqs6rHNw9Q/mKB3L6svMJhaWvxsiqP1G40LIZWWr/YozGqKH7N+5TUH0N9 kFugIwJqy8PSmX6k1/7qJ7IUVpAaVdP+qZ1Xcmqd7/5NAzR6dCZKfp+WV9uHT+aerTeD 8uyA== X-Forwarded-Encrypted: i=1; AFNElJ8/Jruf5eU2d1wTV0w+GOzreFxfKiM6JVIrziYQvFLsnrYbBNt4WFyMg4GqdZbtUIvagpMu6cIe8c+hSII=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx5l/B3qTR3uKQE5ikUWk2dkcykFKnwMjWx5VJ4MwvIJkuhhhy HFdhn+LTBLnug1PG50tJQrZpBv66uVuUrcZZneSe0CWLhe+Htb7VSBae X-Gm-Gg: Acq92OFL8tHgyKsZrm1cERSlCro37T//Xi50p1kKwmPAbXf37Trr2c+ertirp64Fmsh +D25SNjKHRVy1WRp0rLT5YfSrYGMF2UF4wVWf8sc4vm/I7/wQDFHkULmlYqa2s9kv700EeqskEX PDfkRWJPnmmHWX1XhkTFNlJ2sFUA3xH2ULKY+qZufGFHno3foziBHLuVHRqMDN9aVQ/dYG3Q9AI EMPbB4xEuXBcZ0J2US1evvgbwVGQfci+P245g8Mbw+EXNvXWPgsmNI4bEReOE/A8fTe01uR8Jv8 zruIUtdiGdcszjLbN6ZqRDiCTsvXfQ/9eqZTEiR5yi/pCx33S/0xvoiZABGBuvXShJW0hdU9m6O jipiDmKSEN4VeYNvQ3DeJfBKAtz/BeRGhGZMw5+FfwNzgqfCQA2oqx3ruu2zor3lHBzLJfhrnuZ V7w2GiCEBQMt33zQiIVnXiEFkziJMHIciV9SsP5ZqLGmW2NOYFyfrhhZ6mSDKpcR8ZaA== X-Received: by 2002:a05:7300:7488:b0:304:ed85:5f43 with SMTP id 5a478bee46e88-3077b1e1aeemr9735492eec.24.1780968114755; Mon, 08 Jun 2026 18:21:54 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074df48671sm19638913eec.24.2026.06.08.18.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 18:21:54 -0700 (PDT) From: Hungyu Lin To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers Date: Tue, 9 Jun 2026 01:21:45 +0000 Message-Id: <20260609012145.87180-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace open-coded bitfield operations with FIELD_PREP() and FIELD_GET() helpers where appropriate. Also simplify bmc150_magn_set_odr() by returning directly from the matching table entry. Signed-off-by: Hungyu Lin --- v2: - Use FIELD_PREP() and FIELD_GET() helpers as suggested by Jonathan Cameron - Simplify bmc150_magn_set_odr() by returning directly from the matching table entry drivers/iio/magnetometer/bmc150_magn.c | 33 ++++++++++++-------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c index bf2551988008..716b6a088c33 100644 --- a/drivers/iio/magnetometer/bmc150_magn.c +++ b/drivers/iio/magnetometer/bmc150_magn.c @@ -245,14 +245,14 @@ static int bmc150_magn_set_power_mode(struct bmc150_magn_data *data, return regmap_update_bits(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, BMC150_MAGN_MASK_OPMODE, - BMC150_MAGN_MODE_SLEEP << - BMC150_MAGN_SHIFT_OPMODE); + FIELD_PREP(BMC150_MAGN_MASK_OPMODE, + BMC150_MAGN_MODE_SLEEP)); case BMC150_MAGN_POWER_MODE_NORMAL: return regmap_update_bits(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, BMC150_MAGN_MASK_OPMODE, - BMC150_MAGN_MODE_NORMAL << - BMC150_MAGN_SHIFT_OPMODE); + FIELD_PREP(BMC150_MAGN_MASK_OPMODE, + BMC150_MAGN_MODE_NORMAL)); } return -EINVAL; @@ -290,7 +290,8 @@ static int bmc150_magn_get_odr(struct bmc150_magn_data *data, int *val) ret = regmap_read(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, ®_val); if (ret < 0) return ret; - odr_val = (reg_val & BMC150_MAGN_MASK_ODR) >> BMC150_MAGN_SHIFT_ODR; + + odr_val = FIELD_GET(BMC150_MAGN_MASK_ODR, reg_val); for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) if (bmc150_magn_samp_freq_table[i].reg_val == odr_val) { @@ -303,21 +304,17 @@ static int bmc150_magn_get_odr(struct bmc150_magn_data *data, int *val) static int bmc150_magn_set_odr(struct bmc150_magn_data *data, int val) { - int ret; u8 i; for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) { - if (bmc150_magn_samp_freq_table[i].freq == val) { - ret = regmap_update_bits(data->regmap, - BMC150_MAGN_REG_OPMODE_ODR, - BMC150_MAGN_MASK_ODR, - bmc150_magn_samp_freq_table[i]. - reg_val << - BMC150_MAGN_SHIFT_ODR); - if (ret < 0) - return ret; - return 0; - } + if (bmc150_magn_samp_freq_table[i].freq != val) + continue; + + return regmap_update_bits(data->regmap, + BMC150_MAGN_REG_OPMODE_ODR, + BMC150_MAGN_MASK_ODR, + FIELD_PREP(BMC150_MAGN_MASK_ODR, + bmc150_magn_samp_freq_table[i].reg_val)); } return -EINVAL; @@ -800,7 +797,7 @@ static int bmc150_magn_data_rdy_trigger_set_state(struct iio_trigger *trig, ret = regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, BMC150_MAGN_MASK_DRDY_EN, - state << BMC150_MAGN_SHIFT_DRDY_EN); + FIELD_PREP(BMC150_MAGN_MASK_DRDY_EN, state)); if (ret < 0) return ret; -- 2.34.1