From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233673BF692 for ; Tue, 9 Jun 2026 05:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780982816; cv=none; b=ifJVCMykVlNBoV3a9covdajJ381WE0/E/STl9u1ZDvi0l9zaUG2iT1CNgQ6lsIB6bVzj5BI3A46Tnph5vfoy745UY9KdBaIFMPbci4jXAjTJelIRlsWeZWlX+P/BjISOB1zxXGCKjOTKov6nWLlPFPr7LYOBMGctmH3FJqE4mrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780982816; c=relaxed/simple; bh=zdzZZWSAE4fs97+W2zNJ/zcK5e29/VZ2OnLKUaXHvtY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ukAUaIdNcTLiSQAoR7TyxGd3kSxxwgTYjyBA8mfIKlFKeGtF2M9J/f93KoLgmpHakoUSJdQB3N79TUip9Xi8BSkVbOY+Vxb//k7Ao4zHFdLlzg6ofUGeHrQ3hUsRFytVtFRFqGPLXqu3rPTzUGIvffdg/8SeB7Wny/Ap4H8iV5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hSwghVD/; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hSwghVD/" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8423b08b293so2187808b3a.3 for ; Mon, 08 Jun 2026 22:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780982814; x=1781587614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PsT1Zt8eX96C5Vy0ysyPoJWLG8nBvHsoCwEXo1y0+xg=; b=hSwghVD/eMdrgsP9cy378ip/0AFk2Xy3PnLLQ2VDuIZ7jFQSeYrPBrMeulw8uBYHli 7xpU6Y4yEis1sn+x4QMFDZbgistbxgVEv6a4fNZD/Qi4FPXZ0niJqvLzGSsZdhu8U8E/ MYyTDxa+41TANOYhYfS6yZsenRlbxbpHf9P0WaCZA9DPbM1W1ZaEv8gWFsDMqUANTG1N Ym1748S4mBcE2ArZLA9yMWUsymgIvad4nMlm4WCF8DJZBTPPEUcslQ0tNotp4cuJdajI TcdOaZSlZeYnQKUn9wJM9XXqOo+4qxISdigPjzz9S7RHHzXRznVnfTCM0V7NO+HLd+On w4hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780982814; x=1781587614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PsT1Zt8eX96C5Vy0ysyPoJWLG8nBvHsoCwEXo1y0+xg=; b=ooQh59SZ7TATIw0c3OOx4DApUbxh6Rtw+/juck9y60hOdJVLmByodCM7JV/3C7MQ9z rxCJMrc780luiOuQuqTKQwVmM2THjbh+9K3iHvqkmm7VWzZo4YwPbcy2r/HQECH6PNq+ Wpjpg8dH3husH27p/mtfpYQ91bIuSeEM8KkOTt17fn+UP3WCV1b6kRkIyelhEOnarJvS sCqTJGe/C7fe5eCUpq18pb+t3k9qpd9gO+K+/ZE5QZdgXKtowBwDHyhQtbBaeQ6f9PD2 632quG+I63edUwUaF2Akwn8INbRHH2sMp2sqp5JIhwvlUuZ215Rp9gWAXP5eTSU3Ze7E 2efg== X-Forwarded-Encrypted: i=1; AFNElJ8Hqir3CNwIFCkUusooyRCvtI3k018H6ccDWmh6HtzdLJPwef7Ww5gd3a1j8WTthVnyFFgCjpiRxzUr+5A=@vger.kernel.org X-Gm-Message-State: AOJu0YwNrg+n2x2h7hdrjzGwCdL6z9wGj5CNCLpa5OztoDSk+vCqb3Q+ FbiYHCcDrqGTAsr/kS5c8pXw8hUglCJFyS7O2MP2FMUz2Gs53iFP36Mr X-Gm-Gg: Acq92OGMndy0Se+67bluZtzttgoLJYd0g0B23+PY49cL1Lln4FVky3vhXpFVg3XDq+U 6Xd02VbQW2A9/QmEolb6HgidyQlbIMnHgkLamMgkeeRkcvL/kp6uoKYlMlUTDs7ZywVkE2D++IX a0utcJMv7V3Mm/DllJEg0b7NtUrID36pB22/xV1ImBWDaDDEHB/iTsxJ8M2zUcBXOW2ntKFytMv aZVNCr5MQ2c7xJr0p7ivJxpzY0BKAbb+Y9mLmg3GHU+An9teujLtf4zoNGODsPl3v1KXDVCPKx5 y/H+du+WjO4SWv5v2EgyVk4q4J/rlmZUb3SED/hKRv4cRdiqZENg2WgRU0/qN8GPYA1DkOglXh5 QycfpLn8ctjNSgXCc47pxDO23iplVnnAKRCLga64DtJD4G5AdPvQ9atq7g3gsJDc1OUDhMe8x3o NFww23PptUWhUAeoWSeT9GI+mbmXzhLN9+Z/N/4wvbJv/n20Hlt1QOHg== X-Received: by 2002:a05:6a00:1d84:b0:842:5ea5:5fdd with SMTP id d2e1a72fcca58-842b10b2f1dmr17770012b3a.40.1780982814465; Mon, 08 Jun 2026 22:26:54 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:37c9:44fa:729b:6aaa]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828e21c8sm23445657b3a.49.2026.06.08.22.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 22:26:54 -0700 (PDT) From: Ruoyu Wang To: Mark Brown , linux-spi@vger.kernel.org Cc: Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] spi: meson-spifc: fix runtime PM leak on remove Date: Tue, 9 Jun 2026 13:26:47 +0800 Message-ID: <20260609052647.5-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error. meson_spifc_remove() uses it to resume the controller before disabling runtime PM, but never drops the usage counter again. Balance the get with pm_runtime_put_noidle() after disabling runtime PM, matching the teardown pattern used by other SPI controller drivers. Found by static analysis. I do not have hardware to test this. Fixes: c3e4bc5434d2 ("spi: meson: Add support for Amlogic Meson SPIFC") Signed-off-by: Ruoyu Wang --- drivers/spi/spi-meson-spifc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index b818950a8cb7d..e2d19c3873f71 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -351,6 +351,7 @@ static void meson_spifc_remove(struct platform_device *pdev) { pm_runtime_get_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); } #ifdef CONFIG_PM_SLEEP -- 2.51.0