From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41EC23DA7F6 for ; Tue, 9 Jun 2026 07:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780988874; cv=none; b=fZNBDnNIUJsHV29SqlEnluI4rhfk2xHOVEb6VihlUIc+jEjgb0WlmszPAGeMUltsgff/laL6uWDbc8SvD118mkwKMoog0z8t3puU8XK2WUxVSq98BXc68MMxrHzRoOnSKo2xnIA+fS1UUMG5/3LOOcVmPRwb6/9p+tYvOYDkWSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780988874; c=relaxed/simple; bh=CPAJiqP85MtVfxcVBaEaPWgup7ptDFM4XkRTGGxiA4A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=R8c7t2JIoww+jdw3u6pTDQlWhztg4zvGlHX3jyWjhbHiM6X6bgqGR8SdGZwx9JzjOPXHeAToCM40lSzzmFOX9NHEmXwIbE9A6hyljbt8Ak7zu5cnTjOa+/+RooxYh1upEWxCqAnFlA4PMDrivYkRXyd8mfy92UfUUT4STj6Oh6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gERMhvN5; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gERMhvN5" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-3075fa5a407so6244473eec.1 for ; Tue, 09 Jun 2026 00:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780988867; x=1781593667; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=/nQ6SihkTIAHNVuQde+l6sb21AGloI7WP9qqXJPRNAs=; b=gERMhvN5QejjHKWnqBtTIgLDfsnKA1CIJtwjc5EeiN4jGhXgowkFaTm3RGJKnFmWWW 7DIIQ41C96CDV1Y6nQ2E7v6KY2nX/vcqm6J30bUiFvKvDKqvMkeTKNRPO1zRrJRUghJc tFijML/zz3YjCPqWGvcfQHtb7cM6SGhg5BadAXcmYZ1Oe5+9FZdPLhpmV6FsZrkavlfX wpjR8rgjljAqd666iJddwujH6svvdZ44ww8PwAOaK8zBAEPcDk15FkoBwZYzfaJ632W8 FlTy/k+sjJq5GLJZtJDtuwNg7g/iqqV7yCsy2ppVr98D1Ck4s50HUCbNGFR0EPaCJThZ PCNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780988867; x=1781593667; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/nQ6SihkTIAHNVuQde+l6sb21AGloI7WP9qqXJPRNAs=; b=rjtM6HNaZXVuaIyvMtEkTMCYy94KX21EdP1xh5NZPa/Nc8Yz8CXTcBB3+X3coq0m2f sPDFeD7eFhlnfB038P5GDxyXCGQPC7E7UAEArDq4YSKzvYq2k1YYv7VScwJOVJ+Q8Dxc VNeVFERgegw5p0guFva+otYBnIobsKKQjSw4yPy/qdH0mfo+RlEYB3jCbkjtKSXdTcIU u3EFL9HcahEtBwheesp2gwAWqO/SJNnaw/TJMOcYpwmqWvHlxJldAkJ9Y+a9dkS4nvFR fXuQNhA3EzyaGHUQInZuHg7aQZIpPr80HcsO/6Z8MIZsc+y2qqOQPPXDVg2lDOJ8hCrk F/rw== X-Forwarded-Encrypted: i=1; AFNElJ9rSyCwLLHywxaHrmzEW8HZEZYDiI+2urjSwVseOI9k7Hnvc8n/d4dO7FOXw+0xcxB+4GsGch1mylm/vcE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5LeqY7omZb9jumD+CMdNy1xKBlAkTF/YBZQx8Dy9Al66zyCmd DJuukfIyPosO5/h9vXQhT2Kc8rCFMTQH7M1Jv1Y6pFHZfqg6r24/4dA6Fr6wkE6fwL3l6zZqNoy aUR/ZHnfgZg== X-Received: from dyaa27.prod.google.com ([2002:a05:693c:40db:b0:304:ee01:7777]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:834d:b0:307:91f5:9377 with SMTP id 5a478bee46e88-30791f63488mr5547656eec.9.1780988867157; Tue, 09 Jun 2026 00:07:47 -0700 (PDT) Date: Tue, 9 Jun 2026 00:07:29 -0700 In-Reply-To: <20260609070732.545416-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260609070732.545416-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.1064.gd145956f57-goog Message-ID: <20260609070732.545416-5-irogers@google.com> Subject: [PATCH v2 4/7] perf annotate: Add --disassembler command-line option From: Ian Rogers To: Serhei Makarov , mark@klomp.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Nick Terrell , David Sterba , Nathan Chancellor , Tomas Glozar , Blake Jones , Dmitrii Dolgov <9erthalion6@gmail.com>, Alexandre Chartre , Costa Shulyupin , Yuzhuo Jing , Michael Jeanson , Leo Yan , Tianyou Li , Zecheng Li , Rong Bao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Add the --disassembler command-line option to perf annotate. This allows users to explicitly request or override the disassembler preferences (e.g. --disassembler libasm) directly on the command line. Assisted-by: Antigravity:Google Gemini 3.5-flash Signed-off-by: Ian Rogers --- tools/perf/builtin-annotate.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 8a0eb30eac24..57a88adfb130 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c @@ -699,6 +699,7 @@ int cmd_annotate(int argc, const char **argv) .set = 0, }; const char *disassembler_style = NULL, *objdump_path = NULL, *addr2line_path = NULL; + const char *disassemblers_str = NULL; struct option options[] = { OPT_STRING('i', "input", &input_name, "file", "input file name"), @@ -782,6 +783,8 @@ int cmd_annotate(int argc, const char **argv) "Do not display empty (or dummy) events in the output"), OPT_BOOLEAN(0, "code-with-type", &annotate_opts.code_with_type, "Show data type info in code annotation (memory instructions only)"), + OPT_STRING(0, "disassembler", &disassemblers_str, "names", + "comma separated list of disassemblers to use"), OPT_END() }; int ret; @@ -825,6 +828,13 @@ int cmd_annotate(int argc, const char **argv) return -ENOMEM; } + if (disassemblers_str) { + memset(annotate_opts.disassemblers, 0, sizeof(annotate_opts.disassemblers)); + ret = annotation_options__add_disassemblers_str(&annotate_opts, disassemblers_str); + if (ret) + return -EINVAL; + } + if (annotate_check_args() < 0) return -EINVAL; -- 2.54.0.1064.gd145956f57-goog