From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6082F1FC9 for ; Tue, 9 Jun 2026 07:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780989366; cv=none; b=ouoCpAw+x25yJ/g7VBv+hr4D46qpdrXunk4DotFRDpdm2V1N+tNH02rsmYNYnACiC5aBjQNk53/+PxinxaQSVJo4epZ3C0uROA1Qg4XJhdX/FsR+ni0aQY44nSFN7Sav+9JMFh/kQLW1M9QwAt6GWzY1yFIYd6c1yLIEvxSRadw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780989366; c=relaxed/simple; bh=hh8plpyDLmp7qYUu71tv3I6n+HRBSPfE+afzPnmPQiM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XcKTKKs5EMiloPuKKXFxyfdjdFZLItLxgd2mXJdK4YLsmuHMDZPuZigMx3hxVLz8yDmUdoK8XvoJblyxi9mX1gzqy9HHnU8oV+lqeiOq6s415A68SGhK/vvmZGzRlfrD9VM4kMMc1NumaaaxyD5PNFcFeLQprBki/7z3IGl9rfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y+Ne68ze; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+Ne68ze" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-372b4330deeso1533742a91.0 for ; Tue, 09 Jun 2026 00:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780989364; x=1781594164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J+WMj06VweuHxnnE2/mbYxrsGIb7CGFY2jdVSiz7USM=; b=Y+Ne68zeZu6b3jU4TF2p0IPS0aG+wg8ZFMfWS7/3HIoDgev5xmm5TN0mp5pR+WAO3X dNY6YiTfgrVIyWZpefkDUb1L8IioQoPwobHfUxF9I1UecXg3MKYVb8JEUUsxcj9tqJkl XgH9rWrddDnFhNdS9HsFYKkFlhFkpIab+4fNKZu5C6GjF1NJ7dQPjnvVYDDWEXP2aKXg /GYLawvL4PiIOkX/A+RZ24AU4BYfcV78+6OzkXF5+iNx48tWEW8ufEXPQiuPonYlOGgb RTP7q2LXyIalJnNm5MjtBcac/km0rzsfLMK28tpeoTzFEDfOGk6vh57Kr+nnkplkYcfx YJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780989364; x=1781594164; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J+WMj06VweuHxnnE2/mbYxrsGIb7CGFY2jdVSiz7USM=; b=Djg/ZElAN2JgdR/QUVMN4kk1b6MpuYrJqNaO52WQyfufiNz0FOjszfvWWV68GpOJxj I7Ivsv+U2mx/H6PbBzjjUPK0YEdTa1+7pogLeEAhxJHakmPUEeHV/3pckNv17AZst7N5 FTf9L1/Izxvh0EkUqF6cVFrM1XLlplc7VrAyJ8kP1GNv8oJ1j8yTWM1t1By4hjHkQOcs e/DvMvOoFZPzLTIDh5EYyyuYK4UgJodXnCLbWdAdIaDEm6BKFk/Og3yTyqVmTXE7fN81 LngLGk6I3rd8YMUbB78ZkCyuz6u8HmraZe6SXidbHHFambpHEEXqobFw/+yez367YY0/ GrlQ== X-Forwarded-Encrypted: i=1; AFNElJ903QN1h5IK6w8XQ/mJew9wfgIi3+Ftm4c4ShmGQ1AVCnBoRCdHnqvqYNbUcJ0T83eXB3LqoFY/0NKDnhA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2edZp8G+Y1U5+CfP4u+NUEfWSv7ScJyoT/d3Irw5zgTJ43Cf4 OEFxcNURQV7v7aDvFa2SZGbVqb8Zbg01IEz3TlhPq50z2c52XrU3YhA0 X-Gm-Gg: Acq92OEsVzJv7KMsHFjqKVxFvvDwYvZr0qfrVbeokn76u5Oqzppo9o+60EzSbJOQ4/t 9yqkK6ob9I9cRuXLGu0+m6hL7f8uFVrFlaTcy9LiS5dxw8VkETJUHKMUo+IK6vjMLXt3Y65m26u 5m9yITOsLOi2vhPZ4UOIk1xzJB6ICl3P5Lkd0nnT6k+sw50p5WCOe1JDcY1Dxu7GgVFlVUp4Ci3 eZ1npHGuNQeVWoh2zQNPj85KtYp/bZMrr08r6jMzqdVO4vrodKRPCFfYs+uM7MxoGUma4XapOmk hWjANd2uRsxogX1a28drS/5CPtMibht03fowMfHppRSPf1gmn60/N9xsOy8lzgiHDzfg9/sJgcV Y22VhJvfBXVGu2NC2iRbVUS+rW+YLQm6/lwNwONTtQOii5xzVzfnSun6ll3Z7kX0aqondJ1cJEQ 9enOtR3y+FSfBo7QXUsAjdfDago/rPY/hvlxFEjpdQW0JdElQ8JZ4P2A== X-Received: by 2002:a17:90b:5747:b0:36b:9798:4f67 with SMTP id 98e67ed59e1d1-370eee03facmr18953062a91.8.1780989364319; Tue, 09 Jun 2026 00:16:04 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:37c9:44fa:729b:6aaa]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6d1fec5asm18109501a91.10.2026.06.09.00.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 00:16:03 -0700 (PDT) From: Ruoyu Wang To: Chandrashekar Devegowda , Liu Haijun , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH net v2] net: wwan: t7xx: check skb_clone in control TX Date: Tue, 9 Jun 2026 15:15:56 +0800 Message-ID: <20260609071556.5-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit t7xx_port_ctrl_tx() clones each skb fragment before passing it to the port transmit path. The clone is used immediately to set cloned->len, so an skb_clone() failure results in a NULL pointer dereference. Return -ENOMEM if skb_clone() fails. Fixes: 36bd28c1cb0d ("wwan: core: Support slicing in port TX flow of WWAN subsystem") Signed-off-by: Ruoyu Wang --- Changes in v2: - Add Fixes tag. - Return -ENOMEM consistently on skb_clone() failure. drivers/net/wwan/t7xx/t7xx_port_wwan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wwan/t7xx/t7xx_port_wwan.c b/drivers/net/wwan/t7xx/t7xx_port_wwan.c index 7fc569565..01844d067 100644 --- a/drivers/net/wwan/t7xx/t7xx_port_wwan.c +++ b/drivers/net/wwan/t7xx/t7xx_port_wwan.c @@ -106,6 +106,8 @@ static int t7xx_port_ctrl_tx(struct t7xx_port *port, struct sk_buff *skb) while (cur) { cloned = skb_clone(cur, GFP_KERNEL); + if (!cloned) + return -ENOMEM; cloned->len = skb_headlen(cur); ret = t7xx_port_send_skb(port, cloned, 0, 0); if (ret) { -- 2.51.0