From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AED3DBD7C for ; Tue, 9 Jun 2026 07:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780990401; cv=none; b=Zva03rT1oKWzdHSZcbPdRxghW2Xb2b0iDrFYoDYpLkNQSXA2m6ppk0gcZRn7ADLlwejkma2W6uTPUrrZGX0wlxNPU3DdgmtJ/Vy5Dj25Mq4xqjTLHwGfYXED8TEGnTtmOl1RLr4FPu/sET0C5MbgJAb4YQbpvyyfVo3iClMI2Ps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780990401; c=relaxed/simple; bh=RWkA0L6Q2phcYPLAt9VvFae3fkF5zlose9aOWTUDao0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a9CrIPD3/4AKhyVXH5sjqxWFm4VmC2QYDdO9sS7LmnvZYsAFKywKnxVvLYmL3oeMLgrLsxaQsiflQifGQBUswNaLYhVnkPyJtpYsbt6H2LCOre4D0idC2HZBX7e3IU41ci5fqP36hDjGg0avqlAWGeR8gzkrNLa/zsda6bdeT9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HqMYSfVS; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HqMYSfVS" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c86214eead7so968380a12.0 for ; Tue, 09 Jun 2026 00:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780990400; x=1781595200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EZxhU2iD6PdOyojyjLvdXFMxCVOPuNzGVXqMgxsvNpE=; b=HqMYSfVSjYbnFcQNHI7CGVcdGJkSxy77f5Ip2TId1N1c9/PYkZPZ4aNLH5b+PCzCZw lL7LjQFQOi/QgKh/kH7AKcCRVU1TFsR+PTLiVLNCZas+1wfJq1+i5xDVjneVHfOtX+PB Ryx1b9pXxkk3iVNsguhSuN6RhD6/0nXxcdc5CYal/dRL/nQXVMHLE7wEtV2kVLWKj23E Bu86DZgZf6JiCfIKeTXhn+XsxkajKBPEnHP2qLbzDD+6jE/WeHh1mGyo/8fTMzNKp93Z nPoXt5rcodkFO3CUi2cqUvQhT2VOmq6SCTpEuHDzgg/jkpltiJIrySfBZxZ0wTRNdegH IDQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780990400; x=1781595200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EZxhU2iD6PdOyojyjLvdXFMxCVOPuNzGVXqMgxsvNpE=; b=Cf4F75enosHFo5X7DRjZvRyxK8stj1gDr1ztJSFezJCTQ0fXdmc0BwwTz6rJ20Ruix rY4FA2lbP6mmbOjzOM2UcYBujzXU5Ybjz15FdkLV+NQDC8UePPB1kFfe8GXmsubmYgcm AnsiROXkVlXGnHWe8YLvHr/gLNYPqT0+Zp8r1tvm/DfMOr2iBYDRpMhELnQPRBVCfq4m rYadgl7AgsctXxcHmayUxm5Hu2dkmw1jNfvcQEhjealS0BKo1fBZNdJEuZk/bUmMcT5U 80KAuw7Phsa9hVyu5pMU47gL+/W01y5iruzr6nVWDP2hSXcShkrovQLLjo8kPNkY3zrx v8nQ== X-Forwarded-Encrypted: i=1; AFNElJ+sO4nrrNXMut5+wr3sFR3dVvhygf/ycOT1yq8VO88haUSmamOWR0Dqh3Zh7JS2nuLmut1zfMqAwajEduo=@vger.kernel.org X-Gm-Message-State: AOJu0YxiDpSfhoYfYQdEkUgBYKUPfE/egMKFv6NkpMTPeGtWgBxKdNKD rJse+E2/75sska0I7zu00E1rdJ5y0WWVJ5e15BVSpf+tccmEtaFcBjwlv4kySY+I X-Gm-Gg: Acq92OF/8z9iYX5aYvr6foaD5KL/gNHZHlZxVkdOBe9Q7aSzv2KvLi7M5c0hYKjCvhb lumEajtmGEe+VDwI3hy3AjVDSitSE2j8uC8h4UVhEz9ndgOB1jKU/gCWE+osPvrf/1WraTm80ef 9rxHchNEblxykOhmo4t3DgZqJDMWrMzwASSDgt9abcYhki8B3FaFihlWvlXNB5jKU4Qz4ES8qvG MAAPha396sdwnPvfEBAqmnkNA/yQEvWRLtbbANQ9pwu5aPZC75coamj0mpIHMdFuBUJIWXHZB+R UuKy295NpW+gKLP3ViAA5+lpDFlQJbNxcOMyByLngAQCkP7YrhjUjpraLhQBEQUlnbKxdbFbpER RJdkNiujyuyc32UIve6q4da+IpT4dXLwU4ouGiXvYUjy4ffwKBvojTzOyICG/sTgSv3CNoOwTq0 7QFlScQ2ArSyS7Pu9ovq3aXY5ges9zyYVRow91DOgwQXnuCBSCIEJWDw== X-Received: by 2002:a05:6a21:7a9b:b0:3b2:86a4:acbd with SMTP id adf61e73a8af0-3b4d39ff987mr15436890637.2.1780990399495; Tue, 09 Jun 2026 00:33:19 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:37c9:44fa:729b:6aaa]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df034a2csm17670712a12.3.2026.06.09.00.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 00:33:19 -0700 (PDT) From: Ruoyu Wang To: Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Linus Walleij , Bartosz Golaszewski Cc: Harini Katakam , Soren Brinkmann , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] gpio: zynq: fix runtime PM leak on remove Date: Tue, 9 Jun 2026 15:33:13 +0800 Message-ID: <20260609073313.5-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error. zynq_gpio_remove() uses it to keep the controller active while removing the GPIO chip, but never drops the usage counter again. Balance the get with pm_runtime_put_noidle() after disabling runtime PM. Fixes: 3242ba117e9b ("gpio: Add driver for Zynq GPIO controller") Signed-off-by: Ruoyu Wang --- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 571e366624d2a..fafca91128b2e 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -1014,6 +1014,7 @@ static void zynq_gpio_remove(struct platform_device *pdev) gpiochip_remove(&gpio->chip); device_set_wakeup_capable(&pdev->dev, 0); pm_runtime_disable(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); } static struct platform_driver zynq_gpio_driver = { -- 2.51.0