From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F4A13C769E; Tue, 9 Jun 2026 07:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780990826; cv=none; b=iubF6MEFfZjToAXml1Ck7xH6FU4eKDGvhk9xMwGpveXwvtMyvREfWFCuXzBleWSHza+7v/v8HjP96KdiaV+PU2kJS6PyARFI5pzwAj9vajKVi9BcS9XMTk9X6iWGiyl4+gJzKragGxPBRhj/sRtxtps43diw6y5q4n1hSIcum1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780990826; c=relaxed/simple; bh=wLJGk3bCO/WNdnkcwu1xkiHmrhwjxM4NAwi6zjwPgQs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nhCw4v5W/GX+E+6AlhMQ6gvxZnMJEjP2FIdC/yokVhiKEOpcMu2UG+tUpTrBsS3fa6SvgAMqLuZtMh+ezdM3KSiN0CXPKtrdILQ2ESVGe6hsrupJTxBVO7HxiBsKRPqSy5tzY3X6wzIbcXFfrN22iT2Quhk638hdKTyjrzfjWyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowABHkcRZwydqsYDNEg--.13811S2; Tue, 09 Jun 2026 15:40:09 +0800 (CST) From: Wentao Liang To: olteanv@gmail.com, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] net: dsa: sja1105: fix refcount leak in sja1105_setup_tc_taprio() Date: Tue, 9 Jun 2026 07:40:02 +0000 Message-Id: <20260609074002.204113-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowABHkcRZwydqsYDNEg--.13811S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF4DtrW8uw48WrW5Gw1UAwb_yoW8Aw48pF 47WrWfAF4fJry3Xw4DZw45uFyYqa97Ary5Krs7Ga4Fvw10yw45Jr4jy34j934jqw4DAayY krW0yFy3ua4DAFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Cr1j6rxdMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2 zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT nIWIevJa73UjIFyTuYvjfU7ku4UUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwwNA2onpjNyLQAAsC In sja1105_setup_tc_taprio(), taprio_offload_get() acquires a reference on the new offload and stores it in tas_data->offload[port]. If sja1105_init_scheduling() or sja1105_static_config_reload() later fails, the function returns without releasing the reference via taprio_offload_free(). The stored pointer is thus leaked, as the driver will not clean it up unless a subsequent TAPRIO_CMD_DESTROY is received, which may never happen. Fix the leak by calling taprio_offload_free() and resetting tas_data->offload[port] to NULL on both error paths. Cc: stable@vger.kernel.org Fixes: 317ab5b86c8e ("net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload") Signed-off-by: Wentao Liang --- drivers/net/dsa/sja1105/sja1105_tas.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/sja1105/sja1105_tas.c b/drivers/net/dsa/sja1105/sja1105_tas.c index e47967b12d5d..96cb5aa04910 100644 --- a/drivers/net/dsa/sja1105/sja1105_tas.c +++ b/drivers/net/dsa/sja1105/sja1105_tas.c @@ -575,10 +575,18 @@ int sja1105_setup_tc_taprio(struct dsa_switch *ds, int port, tas_data->offload[port] = taprio_offload_get(admin); rc = sja1105_init_scheduling(priv); - if (rc < 0) + if (rc < 0) { + taprio_offload_free(tas_data->offload[port]); + tas_data->offload[port] = NULL; return rc; + } - return sja1105_static_config_reload(priv, SJA1105_SCHEDULING); + rc = sja1105_static_config_reload(priv, SJA1105_SCHEDULING); + if (rc < 0) { + taprio_offload_free(tas_data->offload[port]); + tas_data->offload[port] = NULL; + } + return rc; } static int sja1105_tas_check_running(struct sja1105_private *priv) -- 2.34.1