From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384C93EEACE for ; Tue, 9 Jun 2026 08:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780994202; cv=none; b=k22nIv7hpLrXKwSoda81nm3Q12D55NzsEVXSUnrPAhGbuZTytX+6CrshnOntTVU6uXHRsTg3DidO5ZJ8OqdW3a3OpkUd0v90v0NV7fY92JirIzfPxnq6sZ7nCB7pyEAwu2ZlWBc5hpeGnZnC8v9cwk4srOqbI4X+ABEVjchKH4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780994202; c=relaxed/simple; bh=DcpQEqxL6VjzNEy6H6MpSbYXkllGlA0MV8DsAI82J3w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d/attQIJDCg2U677PqjrCKByATIjpnardHItppI/lDGm0DpGH3bJIlh2VkTW8njKDAQCXN3cL40h/nByQtJ6Q1uqxw6WJHQFMlRbTe22qZ8tY4eakGJ/02Mg5pRIxw+NA0d3XlO+hi5W9veAhkq9JCwgMkMKwgBr7VJMOcbWEAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=h7PyS9Sf; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h7PyS9Sf" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-36d5b11201aso3357816a91.2 for ; Tue, 09 Jun 2026 01:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1780994198; x=1781598998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OCz0yvzzGM7N6CWaoUKNULteL4WQuTdkelNtOhJgFD0=; b=h7PyS9Sf6TnTpErCMUDjKr+qgfUt0+W5+3ecJLvR1JiujGcwyx7rksN4ammWs2q+oR FkNnFGS+p0p01RY0zfJDN/jbsf8iOY0vCWufp2mKJEYftjrhpkFBUb8ySb3NHBdKBS+n hAu9L6KB2i+26h8w/ay8Hp74nHAduNdFDYg0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780994198; x=1781598998; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OCz0yvzzGM7N6CWaoUKNULteL4WQuTdkelNtOhJgFD0=; b=ef1WiMLPVKhPivH4yBr2HaKHQHVUFyYwLP63eZ6qyvqFA9BkaOSZWZUIntovGEgfZj AUPvX+h3JuH7il6J4Sdfztnh74AalyHAHckpVnYhefnQhIoS23KLDWRp6EBjar0rz+Ig xlW0H1Xqmcx4RyBLDqQ38fUsLWkS9euStb6joiqXnQcd6tAArzwVkLwzNFEQNR7UL2PV Skp4B0Yun21/lWSlDXaxfkFbCiDC4j+bd1bP9gN80JACm8hfNcBX2m7lnLdVRIguL61M qmE6wfzGavj+5kjEZzzaj5BEkJpiowlYTvgp127NVHkjhIDFlFJ+8AcKu2G/mTD2x4CE m+6g== X-Forwarded-Encrypted: i=1; AFNElJ+MsnIC2zNF6RmsQpFA2ecONCkq0OmfEVkUYG37XAotcJfVPVEFlvxIhhRsIziGAQcVen1IVu3+Gosp3fo=@vger.kernel.org X-Gm-Message-State: AOJu0YxrH3wX5KrX+UX55tJxIXk+Z073bRPEOIcB5c//jNCdgvR5kzTP cM44NK+LEF0493bTwdjCXK2R2wxISB4ebL5x2TlLtJELwyRkYAyQPvzNSfL5biqWJw== X-Gm-Gg: Acq92OHq277f5ZOZSB3AFl9h+PIXiKO989Htjx3u6l1LgAZcs1e84ajtfIAMNbVBMxC pEymcSpI6LFiH1Az7Fwykjb70iJ2QhwxiFn+SdpoISjb5U3RmYufyJkIFGBDaiTV+r1UtG7wBp6 ehkOwc87rGKM+eKliYAMQh2D/rciUPLonPom3jt66YgTUANATr56QCMw5YYjZyXs/r4N+mZH15r Nsp+LtkEQb1q7y/lyLniZJquHoj4fXiWDhIhXFvC9Nm3VWNWM4AF0g+jtfOOBtUlW2USg/HewyW 12r1nIhR54gQ9mhjlRPqyzff/iBiURb1ZYIQDsnccBB6G7Ph+qqZDhGAus2JjkuY5h5lsRfHtuS c2KnXQx1kDkNqwkYZnnRaHj7htLI2yRjTiF0A9jqBJt+FuKjgwl6ibCbZGyyec/Axr0X+DC92pB D6AZpP3qngyRYHU6qe49lza7fY22KXPOq9+NvPUjmOkiUDWtozk1f+YxozkLm5/IeST4aPFTGLH tx8zVE/hINd93iC9kA= X-Received: by 2002:a17:90b:3c02:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-370eeb160ecmr20413100a91.10.1780994198511; Tue, 09 Jun 2026 01:36:38 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:e2d3:e3de:692d:5f7e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf903fasm18211629a91.2.2026.06.09.01.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 01:36:38 -0700 (PDT) From: Chen-Yu Tsai To: Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] regulator: mt6359: Fix vbbck default internal supply name Date: Tue, 9 Jun 2026 16:36:27 +0800 Message-ID: <20260609083630.1600070-1-wenst@chromium.org> X-Mailer: git-send-email 2.54.0.1064.gd145956f57-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This issue was pointed out by Sashiko. vbbck is fed internally from vio18. For the MT6359, the default supply name was incorrectly set as "VIO18", instead of the supply's default "VIO18". In practice this still works, but it causes the regulator description copy and replace to always happen. For the MT6359P the name is correct. Fix the supply name for MT6359 so that both instances are the same and correct. Also copy the comment about the internal supply from the MT6359 list to the MT6359P list. Fixes: 10be8fc1d534 ("regulator: mt6359: Add regulator supply names") Signed-off-by: Chen-Yu Tsai --- drivers/regulator/mt6359-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/mt6359-regulator.c b/drivers/regulator/mt6359-regulator.c index a27427974186..d9afbcc6a97c 100644 --- a/drivers/regulator/mt6359-regulator.c +++ b/drivers/regulator/mt6359-regulator.c @@ -706,7 +706,7 @@ static const struct mt6359_regulator_info mt6359_regulators[] = { MT6359_RG_VM18_VOSEL_MASK << MT6359_RG_VM18_VOSEL_SHIFT, 1920), /* vbbck is fed from vio18 internally. */ - MT6359_LDO("ldo_vbbck", VBBCK, "VIO18", vbbck_voltages, + MT6359_LDO("ldo_vbbck", VBBCK, "LDO_VIO18", vbbck_voltages, MT6359_RG_LDO_VBBCK_EN_ADDR, MT6359_RG_LDO_VBBCK_EN_SHIFT, MT6359_DA_VBBCK_B_EN_ADDR, MT6359_RG_VBBCK_VOSEL_ADDR, MT6359_RG_VBBCK_VOSEL_MASK << MT6359_RG_VBBCK_VOSEL_SHIFT, @@ -947,6 +947,7 @@ static const struct mt6359_regulator_info mt6359p_regulators[] = { MT6359P_DA_VM18_B_EN_ADDR, MT6359P_RG_VM18_VOSEL_ADDR, MT6359_RG_VM18_VOSEL_MASK << MT6359_RG_VM18_VOSEL_SHIFT, 1920), + /* vbbck is fed from vio18 internally. */ MT6359_LDO("ldo_vbbck", VBBCK, "LDO_VIO18", vbbck_voltages, MT6359P_RG_LDO_VBBCK_EN_ADDR, MT6359P_RG_LDO_VBBCK_EN_SHIFT, MT6359P_DA_VBBCK_B_EN_ADDR, MT6359P_RG_VBBCK_VOSEL_ADDR, -- 2.54.0.1064.gd145956f57-goog