From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51763ED3AA for ; Tue, 9 Jun 2026 09:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998757; cv=none; b=V8J85jji22u0HSXCGCX5HRXoG3o+zdFXFtFxpF45lrhA4+FSGG7KWUV6MCYkJKwUUVljmLp44tgM7/rsldp/V558mZzZA2ZyZ//G6LkSMdDj6tSLb/s19tlrZlQiihG6DR6xltW/OpCVEMUfSgYQEblDmGOtYYmCrbPiW+yp2KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780998757; c=relaxed/simple; bh=8qluRMxg8XjIHb//whowodtyirdLh+q25aKG3zPxL6Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HU+5eI78G2a5IPvhZnpg95QjVd6IAUT4AewkdjVuGGafRh4lkpMIfegu8M9Bu8aGg1GhpuW/KQFiiXECnEP1/BNRJKloLc8ceqrNa0UpumgGcj/DEWzqru3KiEo6xbqG1t8hdkFXS1sWvmTmPk1WvIZ5SSsNlxDqalvyM52/lvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y1U/CRJw; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y1U/CRJw" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36b95eb4bb4so3326001a91.3 for ; Tue, 09 Jun 2026 02:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780998755; x=1781603555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GtRmLzA0ZT60bBVMGm4lGXTRSY/cD/E4T6nl5lxjKr4=; b=Y1U/CRJwdtkrDg2kCkFD6qLcLVAGYHgxQK5dManPcx/WM1q6JG9dWmNH7ffsPumsyK +OzZ5zSsMgqk5qW8pD7tahFrJmM+jRI5Xfcwq3C+gWXlekSPIduXi24uOOyBA9rN3TKN x+jbonjKJKRZN95iRFQFUKtJPEqxfmEOlbQwkkkTwlmOxmpIHEGNsXE6Ly1xmqi8yFyA xO2O1eDq/unt7t8Dbmutxl89tAGsFaT/hQMMFBipKdXbb+x4/g8uC99/i83W5IiwydXh 143g5nSTvlO+kaIpFsCfL+1Tfk2VsG+TOzYIH1rnbACrkmooAflXNXXwHOtEW4xQK3s0 iZUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780998755; x=1781603555; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GtRmLzA0ZT60bBVMGm4lGXTRSY/cD/E4T6nl5lxjKr4=; b=nTjq4XJfoySIml1l7c/UXK+Q0gD0ISIXL1r53TnabsA2bXxIF1abpddrFOZOhakDQS htGGWTnDkxjmuG/bplA9NzdjZ1LQbeHXbsvpBi0tt8TH7SFxcbYkFtitrx17uvgvHhuT IFlDNNjWoRjYExcenUm8Jz/q63ozeoGO6dVk9nhYxjw9DThLWtuCJDpMRSR/SVkeUPDq W7kKH/y5UI1r98vrUQeuQ++dAMqZc9QBEhAUOlu+CimiZ/ZeDPG09nvQHS4cqvsyxjSW +ypUevFwVMixrFayiHtIcRImo0Z90WqUbs0Vg7dVo6NQXIF8jqD7ToFayw/igcWJfIhV EOXA== X-Forwarded-Encrypted: i=1; AFNElJ+8ngpLjAaaI7e03kW0Kt4TkKeRpPHrG6oB1JM/e+Jd2OJUTgRf55yuJs1oAT1PFJM5N7tfBZvyu03n62k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6K6oVRNfhZOqSGZGEQgHkPLzUH7VXkEd72xQ9c5xe6leX5RPh N9tLaaJuFZwttFS7tdr2ivghbA4tRT/AquN7eusnmg/JFmgrumEk16MJ X-Gm-Gg: Acq92OF2wj3cWnHE7ULrMDUM1hbMx8ToNWiLQ6qXMihItQUZ7ZTFBP8G0GcPVn/eZCE eLPukIm5JVWErt0llJ/3sb8AEu9FI2Kgc8g0SoXQQAouPJs7pW35/rYXNFQ23D8LIG/2Tyh8ZtP Vm1YDl/GvG3jv+iYAvycWvkCDaiLIrRIx/Cg6GArLeVUx20wIk3bVZm4YNZJcGI0DRmwcK29j3H 7sbK1gfCdpV2P44zHFvK96NzTCGbtTc0+dsAtFDvudCA5JMObUyILoD1K+f0fuhvuFIctDd9FYu yEmyew8ZkaZIdft23rrwMVBSZSD9LrbGSd9YC0u+D1v4oEWtzzsxXdMhDnhhp6/fxvhmfYwsZcH DogQbQpW4nYenc8eDTIjAcwiyU0Zni2rViqcflf09ynrZmvv9rBnid2LE2TPkTos1JwnTIVy7/g ZI1Q++qHBd/wDjBUkDTvglqYV2NIBBTys2TFIPtq7YD7G3QOua0mbJ3FcH6OAtxgaR2AC2ngrUI 7MjppZeUrfY09JN81lI3Ab6CFP1IRGRN4x7WNFHIRfUf7FRohS0sw== X-Received: by 2002:a17:90b:55cd:b0:368:ac5f:d31b with SMTP id 98e67ed59e1d1-370f0770bcemr20382207a91.24.1780998755286; Tue, 09 Jun 2026 02:52:35 -0700 (PDT) Received: from localhost.localdomain (n49-176-80-106.mas22.nsw.optusnet.com.au. [49.176.80.106]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3713346cd9fsm13185172a91.2.2026.06.09.02.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 02:52:34 -0700 (PDT) From: geoffrey To: Krzysztof Kozlowski Cc: Alim Akhtar , Marek Szyprowski , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH 0/2] soc: samsung: exynos-pmu: fix of_node leak and refactor regmap lookup Date: Tue, 9 Jun 2026 19:52:22 +1000 Message-ID: <20260609095224.1706036-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Weigang He exynos_get_pmu_regmap() leaks the device_node reference taken by of_find_matching_node(): it passes the node to exynos_get_pmu_regmap_by_phandle(np, NULL), which with propname == NULL uses the node directly and never drops the reference. Patch 1 is the minimal fix: drop the reference in the function that acquired it. It is small and safe to backport. Patch 2 is a follow-up cleanup that factors the shared PMU-node lookup into a helper so that each public function owns and releases only the node it acquired, removing the need to pass NULL to the by-phandle helper. It also makes exynos_get_pmu_regmap_by_phandle() reject propname == NULL with -EINVAL (passing NULL was never a documented use of that interface). It is a cleanup only and not needed for the fix. The leak was found by the static analysis tool CodeQL. I do not have Exynos hardware, so the series has been build-tested only (arm64); runtime testing on real hardware would be appreciated. Weigang He (2): soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap() soc: samsung: exynos-pmu: refactor PMU regmap lookup helpers drivers/soc/samsung/exynos-pmu.c | 71 +++++++++++++++++++------------- 1 file changed, 43 insertions(+), 28 deletions(-) base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 -- 2.43.0