From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B2E3F2109 for ; Tue, 9 Jun 2026 10:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000597; cv=none; b=adoSVyjndbEKMT0I3fOVTcglBp8ky9GZ4DRVbBWrApBu20BDAszW+Pf578iLqFBIP11DUWsOPiCAyKka1IQWPcp83U4EcLEXEUpGe3JZYW+xUSUyXI13i6wIFhtVkC0q7HD4cdlusHGeRu5dLoLOOwou5iW6W4ILErJvtjrXyoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000597; c=relaxed/simple; bh=+m+mpXWx0qfpLvIco65ulPyu0TncN6QNo9fHPseAIRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OzToPGrbCzqKD7kCnaRRm3wrSDK0SnUoDQybPql4k8j+i48E3yMmiEjJy+bP76ky2NbjX1WLQggeabI3+jIn36jiTyUy54wkkQDn7s43pudSSPi3KryaV/Y8OdvLja2JM9fFOtpySvE8qHnUV60uB4P62DzmIClb0+9rt3vIot8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OeRapUd9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NPuRCQsG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OeRapUd9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NPuRCQsG" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599vD5E264353 for ; Tue, 9 Jun 2026 10:23:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=dhkZeVLQqF+ ONSXF+cRa8H02HY1dCnDBy0f3fSDbGfM=; b=OeRapUd9EzSWMLpzlpNY5I36rc4 aZbI65x6bZGyAyQqODhG4McT2gUUUP5CnNbEY7ylj3Mrftm1kJ8eP8OP/7Dw8eCc Qx032MGBwDMFS+bueFpLaz6utnJtuwzaJ/ZvFeGiJaVt2fd29dxBZ5pMIBkdA98i fNVUWJQIUc3n/tgWOeb+CBkXkJbezUyy09O2tM2wFAMr2tLibjj94vIh5U4p9rto eUEXLn/cPbps1s10YY+/tjKfEtjoKzBoui/iI+nadZQGY26ssBQ5PuWirVwmRO5o +X3pDIm88yz/Ob5+mbs8vDHwHIoH4+HT39GkYhdf4adjhkoD/vh4QheKUnw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epf0srj74-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 10:23:15 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf3636d6c0so57291055ad.2 for ; Tue, 09 Jun 2026 03:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781000595; x=1781605395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dhkZeVLQqF+ONSXF+cRa8H02HY1dCnDBy0f3fSDbGfM=; b=NPuRCQsG5FtPL4lMGAsOpcehwn/bJsl2+48pUeBufMuT8JY+YdBqmLBWnrvzn/8+p4 itNmIwKAhi2RTpAjth4bw9v/bUslwK+CiL58jpPyrslLodjnAvPBdM7vGa87JbSsR7ii XMYfYJ4KZJrYTvUhQDN4/HQsjh8hexeajGgNJ9MZIeW4NvwySPvWfQvcjvlLk/qKpIvx vFrXuSLL9ewxctXw4ggu/SfnrcE8Rmf0vx4x97EL9RJ9o/hlE4X2CqvAmx78c3v29GiK m9suj7FArE8ykTkn9CqkTatc29E1A/FioW4xU2dBVwUI2zCZQNjiMePpmuGJH0tcQ3mD F+SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781000595; x=1781605395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dhkZeVLQqF+ONSXF+cRa8H02HY1dCnDBy0f3fSDbGfM=; b=F35Xn+1ECeJt3+RbamX5voKK4k3hC2UIJU2JSxjZUXP5sa6CE+dJZk7tndJCyV2bHY kA+jEU9VyjTPTD/UGL4Uy5z6SDef+v8gJTczraKKSIn6szAs7kDTv2gXr0uTCqK7ZvnH Em2I2ZLPKW2tZOt+amYk9cphy+8WnmztqOyrdpNloXKJ7ciAzrV1WXSmYGjlOzzVUxKf 84gMkS5mggdXRKKP5vZJ8sfDgaDEq8R8Gh24vkUa/sW9PL8gSi1H1J2UOVENUxD7exMX kkPio57I1f8Rs17UhfiyhLpIwBgomxHiJcEPY5EsIRSR0ZC8nmSCbzKmb4SQ7m8PhCLz 4h6g== X-Forwarded-Encrypted: i=1; AFNElJ/r449ttuG+QRBmozDO6XYdtpxpirItPsy2lBwL5gbtNshpRJzvezWyFAFmndvKqPpzt751c5dSsU0xJGg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKcyPGaBfhBU+sKclnoVczqjlzCHRbpFIaVdoFsc+mfzu7G7IO GW/kU5o/UmFYEKydq0g4FcCJ/bzK7fkx3QbYhSK5J/t2vFS0+MpC1NjU02CWERs13fr8pPAbwoe e+S37VLxvdEMpzAj9EskBLsDs1Qy6sUleFMc9Q5EJsBcbn7tGRubugjQIMg1xD2Ar13s= X-Gm-Gg: Acq92OESWPQHxolVsL5cuSpFFzkvrnGbv2oIuWwLnrsObaAslBBLrfgmV4pybN664gl O8AjoSH088L2l0YUlDfdGtuW01r81+U3ROLY+jd4zfrXKH1KUN2UzGfLPzMHMMnalqRKD0L8UhD 2nMdYcrGc858q6b8PepFb4FSGWX9LMzPIMNokTEB2/vk3Y6mlTGVeHaJf77n0mL6s2/VvpB5y8K bI8/RqiVKKw7K2wFRXXigjQruy8n8aV8p/NIS/oQ9Y8vT6LOrpkFVVOri6luI4eOSZFlbDhyQAg y8WTZUp7FYk+ILI1ubwruj8j9bcK3hxToimryY6FCHorowoWBmWYFU2YDY5qVxlZgDYnddvxc/p HQVKDPjIKutKJfZ25dCp/KDqT5A5bmJIscRzn2SZIK7T/8odMAXG/tJJvckY= X-Received: by 2002:a17:903:1a70:b0:2c2:245a:3366 with SMTP id d9443c01a7336-2c2245a35b5mr173911655ad.27.1781000594843; Tue, 09 Jun 2026 03:23:14 -0700 (PDT) X-Received: by 2002:a17:903:1a70:b0:2c2:245a:3366 with SMTP id d9443c01a7336-2c2245a35b5mr173911375ad.27.1781000594271; Tue, 09 Jun 2026 03:23:14 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6e86dsm213121685ad.8.2026.06.09.03.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 03:23:13 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Mathieu Poirier , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Mukesh Ojha Subject: [PATCH 3/3] remoteproc: qcom_sysmon: abort stop on unacknowledged shutdown Date: Tue, 9 Jun 2026 15:52:53 +0530 Message-ID: <20260609102254.2671238-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260609102254.2671238-1-mukesh.ojha@oss.qualcomm.com> References: <20260609102254.2671238-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5NyBTYWx0ZWRfXyPCArKCQ/7Cx +pw7ru6VWlM8Z2plsKNQxVEt1DTnhFDICHTpke1C9mWf6ECDgkoFHkCwMcI+9rgtzE5TL/lzy4u Gdu7fB1Ltu3ETe+eiKTN3zAYpFbgczY17dW5yelzTcnIsLKO+HWee/Mk+nDXxGDjD68pYVFydXw zLV/PeUSJ6K9sJgb19JbObONR0cfPhwdYpJOa2ZxOqD/1yOh0nm/hQOV/SaLIXdW7qagytd4389 AcDd75iK1mwoWtu5sand1WGjArd6jXj267sREt2EoluCzCG59G/lmZbQeeBkULdhg98qK8heDc7 uB2I9kwvr2DWaDzDqZoClTT49MwVzLXNj2vJsPJDPGDFyI2ZXIXB83Tgi02RmbBdrI36s/NDRfZ 5jKqij7GBDM4YTuUcHJoYQ5gJYzuKCYE4RS+OOsdou4v7xJjIWwPeBsTzQj+Ocl8JA6tKfjDrik BztsrY06cbkUGdGBbow== X-Proofpoint-ORIG-GUID: wC1NPj6lDiq_bLSRsbyRYz2desgQxIaU X-Proofpoint-GUID: wC1NPj6lDiq_bLSRsbyRYz2desgQxIaU X-Authority-Analysis: v=2.4 cv=GeonWwXL c=1 sm=1 tr=0 ts=6a27e993 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=i5RmczF_S8wiUxY00XQA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090097 When a DSP hangs, if a graceful shutdown is attempted during sysmon stop, it times out but sysmon_stop() still returns 0. The stop subdevice loop then continues and tears down the glink and ssr subdevices, which unregisters and unmaps the memory regions attached to rpmsg device. If the remote still has DMA in flight against those regions, the result is an SMMU fault. Fix sysmon_stop() to return -ETIMEDOUT when a shutdown mechanism was tried but the remote did not acknowledge it. With the abort-on-first- failure behaviour already in rproc_stop_subdevices(), this prevents glink and ssr from running their stop callbacks against an unresponsive remote. Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_sysmon.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c index 44b905a7e129..a29084cf7145 100644 --- a/drivers/remoteproc/qcom_sysmon.c +++ b/drivers/remoteproc/qcom_sysmon.c @@ -559,6 +559,11 @@ static int sysmon_stop(struct rproc_subdev *subdev, bool crashed) sysmon->shutdown_acked = ssctl_request_shutdown(sysmon); else if (sysmon->ept) sysmon->shutdown_acked = sysmon_request_shutdown(sysmon); + else + return 0; + + if (!sysmon->shutdown_acked) + return -ETIMEDOUT; return 0; } -- 2.53.0