From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10DC4408608 for ; Tue, 9 Jun 2026 12:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008775; cv=none; b=gjNSZnLaVB3BigQiayxDENSrTHlLlBXwcAOheAqGPICJB/0bVEC5dlWCixdakvRQsjvay7yz1KuOUYMmlziDApjyfGm+ClZqZJsUq9mmcIGEh7p33Q6J5QmJIGwmHsiSdJmfP8YtTR3pb1EqrO7cumTT+GQ+rJFmeIlNES+9h6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008775; c=relaxed/simple; bh=tozXJIoJ9ZyD/RgdiDOWZGrwfePx22dC2RLSdUqWzX4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nHZ6+PAKGDuYf9soTo6FVWdQswodDsi3EbZBTUDyGhhZs4lyeGGMnnAvjDUZWqcauXIl1eHxblK4AO6Az5Yx6sneI407vuz1uH08LCIedxPR+gELpLov5x4ppIMZ18lRGE+ff/IvqtAPEFlgy9SrO5RxSUlJSWaA5end9uopbvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=htVp2YLR; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="htVp2YLR" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8ccef25789fso37851196d6.3 for ; Tue, 09 Jun 2026 05:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1781008773; x=1781613573; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kxrUDiRatz+tvaflvzMP2hSJHLTXJP3cEZpHwize94E=; b=htVp2YLROgRbbRYQOfJ3UjeXp0fnux9dOrYMQEVdgNnfOEPoU0BZEfYGbwnkPkkPbb WtjxMWlwd824E//d/OaZiDERzHr5HcTLDzUDYvRjC97n+ycH1dr2XpWBKsdTc+Hle4Ud P3HFHQs98sECqqc7rNI3KE6Rl3wfP10dnC4MmwqKKtvENxzOtAG5ai5G3aIPn7xg5/cx zNYzsjQcFMXaHHqwnoX1g39Be9bDKJCXI+FwFKj82jxCjY5szkOx7eex8sH6f7PjM+4R gHNkv4TATVmEWYOK6l09ECyUPEEycFdB0J07sWxep7UVsB0GM183ooYaFPfgtez1037H WObw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781008773; x=1781613573; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kxrUDiRatz+tvaflvzMP2hSJHLTXJP3cEZpHwize94E=; b=YQPUamIeFCkQ1gg8mVIFYKjYrJn2hKne+OCzuWP8+PpDf4jZP6SEz0Uy1Y2bcJsha2 FGuO2jVioIvnKbNy0w0CfLfU8DOEU8IHVs6Pib3B3XbU+g1zK4gr7fx2VZ/NIs6oDlkC e7t0nE1LUS8vhHvDnykyyxnU2zHfJmkKeEKFQyvnJosYqZsYWptz5IWjCdzxqWglW/Js +SXD4EQeOUqy1tP15ajbWv2ccak4jEakKUBabIjo4UD5mjtcmAP2rn/we11kK+qy53BR LpEx1EVbiu9/7AuWdnwuQBoZP0VE430G5eHDu3KlAOOrYVeoqKHNwtRytcf/paDgeexL MChA== X-Forwarded-Encrypted: i=1; AFNElJ/WLTXok7qisgqRnr/2Pir267loiw2bH9IyK6sY5vj0tXZGkqsBNjdZWySGAV+z+7K3SPFlcbFpdH0Z8o4=@vger.kernel.org X-Gm-Message-State: AOJu0YyB3pDaZG/CJRplte4Th+kqDlkHNPPl105Fm0ZegBIkNhxfBesc I4QJqMSuQawYPJL3H+UjHaNlAY095Hv5fxR+FdmIH+/JFgFYzUFTJn8AVldcyT5MOYQ= X-Gm-Gg: Acq92OFzxCUefJ7E9lVc/r/xYwEJsxtbRy9XpW1UBNfD4tT2uza31hDS8Px64Y7XY8Q Uc6/0UZiHJ8fPMv5dsHP8CfDelTPTHsOVRuDUe/bqI9dCCJDC5G/n2u2UoSUpoUptyc41LW+tf9 qJ5vcAIVZXmwlm/LZq61P6c90ZtrTm8RIGuDCbJwrc7jF0pgD7HeehMX/IzS2U4uxjO6sRPTgES Xzw+2s+OvJwW/SkFcuvLQlFJYnnPxKNKFnb49LKkcJf+WGljaUkr/RQ+i85D8d4weA6NPRsv75I u80/1jbwF1FizMw2/SP+kU74gRj4MYko9Q3FYPqgFPvjc55osxmbYQtIatYLOsWsvdUq2KU8pK7 He3zHZ/GEw8q0YRIP2Kl5VToeEbFkU4u2QJQ+CUiT1w1z5ALzLkhRObiPYXNs0zP03QbZojySjX mMVCAIauA5zalJOUT+IyJCAIB66ILnySt+y55LDaWoOK8VbUv8MtjvYULSN/xQWrwJEkEijuA/u KZ7MwN5rwc3ktPd X-Received: by 2002:ad4:5be5:0:b0:8cc:2a92:48f2 with SMTP id 6a1803df08f44-8cee625246bmr334792646d6.39.1781008772803; Tue, 09 Jun 2026 05:39:32 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd051d61sm201134896d6.29.2026.06.09.05.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:39:32 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wWvjv-00000001sjW-2NnW; Tue, 09 Jun 2026 09:39:31 -0300 Date: Tue, 9 Jun 2026 09:39:31 -0300 From: Jason Gunthorpe To: Konstantin Taranov Cc: Long Li , Konstantin Taranov , Shiraz Saleem , "leon@kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH rdma-next v3 1/1] RDMA/mana_ib: UC QP support for UAPI Message-ID: <20260609123931.GH2764304@ziepe.ca> References: <20260520100656.875006-1-kotaranov@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 09, 2026 at 09:40:30AM +0000, Konstantin Taranov wrote: > > > +int mana_ib_gd_destroy_rnic_qp(struct mana_ib_dev *mdev, struct > > > +mana_ib_qp *qp) > > > > The function is renamed to _rnic_ to be shared between RC and UC, but the > > request/response structs are still named _rc_. Should these be renamed to > > _rnic_ as well for consistency? Or does the firmware use the same destroy > > command for both QP types? > > Sure, they can be renamed. In the firmware, it is still called RC though, but it can > be used for all QP types (even UD). So, the name _rc_ is just historical. > > Long, do you want me to rename it? > > Jason, can the patch series accepted, or do I need to send > IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA first? Yeah, that's what I want to start seeing And use the proper helpers too: + err = ib_copy_to_udata(udata, &resp, min(sizeof(resp), udata->outlen)); + if (err) + goto destroy_qp; Thats ib_respond_udata() now too Jason