From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E9B419313 for ; Tue, 9 Jun 2026 12:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009218; cv=none; b=pdLuCRRJX8shA1b+wRDI3Gj+elKf+rVlPvbSDrl1GStxhu3XhsqtjbzNadN6/i6/p9g4/e0CmxR0NljuxYOk4PLgGC7HkRwWAn5jFBrqELeFIoUI8tzy74Ue5EGYwUSQEyu17rn9kPR+xeo8Rz00gCK2qHcyc1Wu9vxGG52iwK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009218; c=relaxed/simple; bh=LGdH7SQSWJPZ/qtGT8hyfndTly/ySuClfSPo1vU0LNU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ukZnLL4qAwOY4z6bH8cHUdAXS1ZHsdbJAGd+WPHWFCbMN5sKT13Y5I75LxoNGX/PlnMI9+6IFxy1jiiYG48W3QiSupz/WYDSI1t4QmPMC09H37x75DQ9DzJ5BY7j7zVqIhnMnHX/9A7hxVY2VMbvGKzwbbMkmIWTJnTdjEO6JCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fouk6iBU; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fouk6iBU" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bf20f6be6bso42258195ad.3 for ; Tue, 09 Jun 2026 05:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781009217; x=1781614017; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7/afz4nvXIRfi2Pj8KLVrX3BWxOHZHkPj8mzuPbQSFU=; b=fouk6iBUUTdFxF/OmMB4XP0pvPvPoKMTA3iEzD4mH8DvKWJZjyEnz5uvy9s4YNk8Ar MRO9XvonE2tDwN3F3sj7SPA0NnnB4bIK0t700q+DA+PCK8alfBZ3thyTslSF76f6i5c3 H1gE7FvH1KhdgP0HcATWmN0jZPfgNwsUx3ulLLjmY6WrQRWVp1r+a4H/DGmC3xRGjrws su8DpyUovOt5HyfdsauZYKR99Ni6qwjRKAHILkEA2QHEEw9Spu6CcJcTwhTCvE5cs43N 4Q/NdE1TMIt6/+A9XitXfyugPj4fy2ILOe3rc+7rEnXA7yabm2GgwC7bFRqP0nBRykk8 rthQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781009217; x=1781614017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7/afz4nvXIRfi2Pj8KLVrX3BWxOHZHkPj8mzuPbQSFU=; b=YztM0Y7zow6xYPp5+s9+bU9X3JP/qnsfa94W0h3fkH9MMMRC2VpICOnSuHGif7VaUM MmbqNaKz6tOm2klnPUE8LFwajP3sV4VBB9of/aJqCeJL5SgMqqbwZ0/AA3tYPK05XJoU 6jMFZfFBTJ7qSDgm0jdL5DDjHoK6GT19XI2Y3ErVGhwP1hb3u7KNu57PYp1qNZ3+EGqJ lG5Jgk2t1oupHczg1HeMZ1lf6TPeex/oAtUcSuT52OZw7qycLZuZ8jUbBb0vqg1hkOw5 lVr6Es9y2HavCASfgrEK0XQWLW3O14+V5jdtGPByhsqIGI81OqQlMpqfEKflngIlAcMD Fvdg== X-Forwarded-Encrypted: i=1; AFNElJ+axoDlhKxidZM85ExjqWXVDg681e1P76ICbpHEZ1T4/1qj0n+2Ou2lEVNKDiJPMil/ArtsymWENRE9ZDY=@vger.kernel.org X-Gm-Message-State: AOJu0YyC+lLLx5OycSc1WjcGs0vJG8CPL3AsZcS2hTGAgsQwO5I0hOLQ ZiRLZGFlInY3zUOapHOEudCzhX/3ZuwHg9/aGK0ljbouC+eOdXJeIuiT X-Gm-Gg: Acq92OHznwaTKkRA/j7yw9aSKi40yH5q/3eYpQO4aIjyJy28+d+EeGKRJAKk/7Ad1se G8hSmskXoaWYoPWgl5g8hIRFOzPD3Xb/5iFEvNnyCzcHZMm3M21rkHEt22HEBeDHS9ZJOsA9yOD qfssbrQrGn+xPPDWckCRV9c41jRskPDzLXjx/3tJTOv0stS5tlMbguOu/f1a2qrYW87J1l0RYaz iRAp4912q9UZ4DBwsam6ZiLnRidZIxoE+vot4KSe0RNImtjXhvOThvdQryhTUA2I7HbIVVwrMTc NP0dfp9FtCW/9xVs/S+pM544qKNFuDcGxE+HVCyg5J9QwrwRyiyFttH6M+7v+7TmQyrl4/pGsMZ 4Ojl2LkxHFS7vNlM5F1Uctk2kvH6t7/aUCp110dhrEHkB4su/dC1nZGNkZezQ7Erxu8opW/84b1 edEbhIsVTufs1c7zUr7f+yAwdCUidfJLglQE9PaJIvX1L8YX6r1v0o1xDtfoLIaZ1r5FPVsH7GI UhqmDGjFH2/Ht47XxsjbjBXuN8= X-Received: by 2002:a17:903:17c4:b0:2c2:b6c2:9daf with SMTP id d9443c01a7336-2c2b6c29e60mr3304995ad.37.1781009216876; Tue, 09 Jun 2026 05:46:56 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d40asm204686345ad.64.2026.06.09.05.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:46:56 -0700 (PDT) From: HyeongJun An To: Mark Brown , Liam Girdwood Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An , Jeeja KP , "Subhransu S. Prusty" , Vinod Koul Subject: [PATCH 1/4] ASoC: codecs: hdac_hdmi: Validate written enum value Date: Tue, 9 Jun 2026 21:43:13 +0900 Message-ID: <20260609124317.38046-2-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609124317.38046-1-sammiee5311@gmail.com> References: <20260609124317.38046-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hdac_hdmi_set_pin_port_mux() uses the written enum value to index the texts array before calling snd_soc_dapm_put_enum_double(), which validates that the value is within the enum item range. An out-of-range value can therefore make the driver read past the texts array before the helper rejects the write. Move the lookup after the helper has accepted the value. Fixes: 4a3478debf36 ("ASoC: hdac_hdmi: Add jack reporting") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An --- sound/soc/codecs/hdac_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 2652fcf2a3a3..3220f9226e0b 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -911,12 +911,14 @@ static int hdac_hdmi_set_pin_port_mux(struct snd_kcontrol *kcontrol, struct hdac_device *hdev = dev_to_hdac_dev(dev); struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev); struct hdac_hdmi_pcm *pcm; - const char *cvt_name = e->texts[ucontrol->value.enumerated.item[0]]; + const char *cvt_name; ret = snd_soc_dapm_put_enum_double(kcontrol, ucontrol); if (ret < 0) return ret; + cvt_name = e->texts[ucontrol->value.enumerated.item[0]]; + if (port == NULL) return -EINVAL; -- 2.43.0