From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872BA419313 for ; Tue, 9 Jun 2026 12:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009222; cv=none; b=U+APoIXLS/u7z8MkZq0qJxkCDmCORRMXJxe+K/WMh9Stex7bzV5yuJohvGequriVWqHLkZusm6uWkMlcfXtF3lw8gENVEtHDm0aZwkC+fK6VEinz4WahrJ6nw2r4AGhsCvdKONXnFXZqisi5zLgSTL0meptCeSXn2MUeloA87WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009222; c=relaxed/simple; bh=zuslSjBhbtwOo+02kXcRyWg4AlDrGCMRcK6xgfcuovQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kx6PBa9N+FxXQ9yRM6fhVcCXE44neZgbCAbM9htyaatv9zu90t4BaAR17XFEioKAJtZw5WL6bu6KFdui7Z/TBI0erGqEGshR4FBQUojoFNPgKTDLCgwr2ou8QHUxeEEK0iv7P2IVtXXr1VybakcY5IhCgm6Fqb717644IsKYfRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TGlFOTpE; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TGlFOTpE" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf1cda2b17so40072945ad.1 for ; Tue, 09 Jun 2026 05:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781009221; x=1781614021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ehwC4+p6kz8win9+9tJOLmuWLTHCo6mGAGt8WUYA5c=; b=TGlFOTpEaO77Doo6fMGdC1JhMKsHh3gFRjkzhHy9NIabywGM0wufjbX31wKIwOWUkK h9esoXSl9+XbQiFIyxgEXg1wCUuU/FhrcsrlzOWNMRTdzpRITH0/+RGGk1Ddn1g4Bf4p 9hKY2h3EhOjeaIHgEi19mwevsovkphXGvCvtb2/kJMHMu0zJUrpDay1lrAwk7O9HJ2P6 lJfY/K55h5bnQq96nyZ5S9Z6r9LE1/FlYu1uuwdV+pjhkhTOyRzVcpz2jLR4tqn+IwLk OxRDqUqYWBrZjjYyeP3ZmaNjAygw0f3YTeHZTFeJ7dLdTmj3RJjcg7OG2u0x6VmddtYF 3Tow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781009221; x=1781614021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3ehwC4+p6kz8win9+9tJOLmuWLTHCo6mGAGt8WUYA5c=; b=Gg24+KgWZqMVBMrzo3Nw0B7ydMCK/tZ/uxhVdIVg6YYXS6cJLzhf49EO54sBvvcM+T YW5CjrJEbZCc9i96z7l1VAxWiqFOf1t55DBo1xP5gSx1W0U5S9o5hk8ID/khUMu2trnJ IohTgTShtga5KEcI5E3A0Qaj9cQzSUEPAKEjLYbQ2p7sHn8Ei1DLhqL/YyRasWVY/iec hCf++Y899STysuauWzQTTT8ipLzY95tdp4M5kOoGB7IBBLfK7Qe9fkKhSayqkx51ITs8 NTQFQxDAXKmW4Yt9xPu/mHMw6wIWEd87scx0/ZffKHbVrkErgPDnUnPV5FZw7DaUggLC qO2g== X-Forwarded-Encrypted: i=1; AFNElJ/0q6u4ezUPsXVTPHoyLlSvNiFAPM5IowxG9hYqon2kBJ9JSVLbTnfPcVLNL9zcWBWNQEW9MHcMPC4Ma1g=@vger.kernel.org X-Gm-Message-State: AOJu0YwlD4AbVo7z4WSw58rmQdtxuLXOo03vhqhp9vlTRSgD/xKHE80g TFKQQ4jSpcw0AsriD7ApWPb9+KebzYcv/lCOiI3hneXPSkcc+oUVwHtR X-Gm-Gg: Acq92OGH08vcXbFW++rgRAySTsN+GaXlDqeEYivsn+Uw+2oFaC7FO79nzPp5e/uWHkj 3GE0PCxkabbNiR54kMfSADLtHz8Z8CeNOzc1luLW1LVJ80C+QP+4NOYFOevxBhyTygW7wysoG7P koUpAdYUSHAL3wezaYfLD0ddbWsQ8dDtBKI9Rn7Y/ceyTzAzQjnwohT7bwmssTrBMBvQaZ985Fv E4DoDLAKFn/LyJT0bBE3Q3Ekw47fjMUnoqZuEFMPsuxXD4ZzQjCaJG9HyZaHqOofmHTrAvbb2kL zuE1BMIo2PvsQSvdSWlICd6KCRCA6/qZyMNlEL8QJB7oli7FsKNoGJPONkoty0Tu9z9FhA0et1J AdZo1yHzwXSWccOLGuk90pgbRqRhG7Iq3kRAfIh8VGhvCbDIKIQfotRfInl9nVFhI2xlRnWGZ3l 9rRKWPjo4/hH7i1aEbUfrzUDF6I4HK2YXStfKRznnRvBzUhlBPAEkROF783X231CwM+WXSyv6lF raQd6zRl4XDPRgdZtjyP5Uj848= X-Received: by 2002:a17:902:f650:b0:2bd:2c3a:2a36 with SMTP id d9443c01a7336-2c1eb7476d2mr171953745ad.0.1781009220767; Tue, 09 Jun 2026 05:47:00 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d40asm204686345ad.64.2026.06.09.05.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:46:59 -0700 (PDT) From: HyeongJun An To: Mark Brown , Liam Girdwood Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An , Jerome Brunet , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: [PATCH 2/4] ASoC: meson: aiu: Validate written enum values Date: Tue, 9 Jun 2026 21:43:14 +0900 Message-ID: <20260609124317.38046-3-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609124317.38046-1-sammiee5311@gmail.com> References: <20260609124317.38046-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The AIU HDMI and internal codec mux put callbacks use the written enum value with snd_soc_enum_item_to_val() before checking whether the value is valid for the enumeration. Reject out-of-range values before converting the enum item, matching the validation already done by the G12A HDMI and internal codec mux controls. Fixes: b82b734c0e9a ("ASoC: meson: aiu: add hdmi codec control support") Fixes: 65816025d461 ("ASoC: meson: aiu: add internal dac codec control support") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An --- sound/soc/meson/aiu-acodec-ctrl.c | 3 +++ sound/soc/meson/aiu-codec-ctrl.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/sound/soc/meson/aiu-acodec-ctrl.c b/sound/soc/meson/aiu-acodec-ctrl.c index 483772ba69cd..94c5d6533523 100644 --- a/sound/soc/meson/aiu-acodec-ctrl.c +++ b/sound/soc/meson/aiu-acodec-ctrl.c @@ -36,6 +36,9 @@ static int aiu_acodec_ctrl_mux_put_enum(struct snd_kcontrol *kcontrol, struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int mux, changed; + if (ucontrol->value.enumerated.item[0] >= e->items) + return -EINVAL; + mux = snd_soc_enum_item_to_val(e, ucontrol->value.enumerated.item[0]); changed = snd_soc_component_test_bits(component, e->reg, CTRL_DIN_LRCLK_SRC, diff --git a/sound/soc/meson/aiu-codec-ctrl.c b/sound/soc/meson/aiu-codec-ctrl.c index 396f815077e2..60bb4cdfee52 100644 --- a/sound/soc/meson/aiu-codec-ctrl.c +++ b/sound/soc/meson/aiu-codec-ctrl.c @@ -28,6 +28,9 @@ static int aiu_codec_ctrl_mux_put_enum(struct snd_kcontrol *kcontrol, struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int mux, changed; + if (ucontrol->value.enumerated.item[0] >= e->items) + return -EINVAL; + mux = snd_soc_enum_item_to_val(e, ucontrol->value.enumerated.item[0]); changed = snd_soc_component_test_bits(component, e->reg, CTRL_DATA_SEL, -- 2.43.0