From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75734218A5 for ; Tue, 9 Jun 2026 12:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009226; cv=none; b=FMgZIjxoYxkNVJCQRzAB68vrq/lm7f5AqyR0XGmcvZs0aUJ/wzZR8vJhZaFpH7UiroQVrEkXqmTVJ0g2qGcQhh+8/hAyPgyQXDbY5Kh5cKzG9UMPB91kzsUKa/fslvt5mBkCJjCw/TEv+HN0I5bqMXcuRMpVE11e/IB882jg0Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009226; c=relaxed/simple; bh=oddDzn30hz+MNqvf9DAzenvLYi1pG8FYsLnwMwtd5D0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qAC7xdP9s+CLoj2J9AQsCuaKzyZ2chVCIV7f6B6De7XU0pvpKBKY9I0EddFVALvrZ6/RnFYK2aaU07yVrOdmgSFbKXJCsBQuyXJLanNFhMyhvyXuUIvleqmtHtsSqweQQEzXkCKrFpsHGGAfQRSduajGipnhLPugTgByXu8biy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A0WcYAWI; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A0WcYAWI" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c0a5354da1so44454385ad.0 for ; Tue, 09 Jun 2026 05:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781009224; x=1781614024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=keoU58MOi5VGqip4nmTurg5eYjRQQf5+ZFnAVokgfv4=; b=A0WcYAWIpYdee98KYm7mS1THocs35Ex/2t1qzdV7LTOgz+ieRj6+Lj2QSVqAj+gsN6 wxNlDRBaUGZ2BDTvAv68A9jMVD+u05YTkzC0f4J5kmnNSDhU1f/3DqMAhn7bIruY3mt8 ZWfKT4doT0wWCWyQbJRYGqEXHBWOrZzxVYFSfABmIxeVv2EG+xi/vUuLOqpTG30kkNGj 65Xm3Si0wfGvmwhVAKL8cAlRfhskZ0Ih/SFtt2EFp+lRa2ln2oHI3/SWJFhv+FVsVOSt Ny2jKV4GvzZbh3kilg0rdErXOMHze0POw3z0muLKzHUvwcK7FPdUdrZiyE0Bn/n2UqOb Ja6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781009224; x=1781614024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=keoU58MOi5VGqip4nmTurg5eYjRQQf5+ZFnAVokgfv4=; b=on5OVox22f4hT/41snXIMP7FXVYAfHWlnbTCUl7t/aAu9csSuKhnf/bL1xXY2kVZ0H g8qaeU7K97HEWHXVPqW+LVYQDZQDLAly0V4m28BA51vscAxV/zi284EN7tQmCYDqyC94 2dOscaqcODV+sBiTUf/DY+dzJEBT6EtW8zk5lMkZQv+3HgPAf2JtC4rIuEoWW2gX6FP4 JdESg3xHTHKVWDy2/byXRSCHeRcc9n85iVvhTWAWzRILM6SPNVmH1waXtOu0WTtRiLHM SQzD6XOhufx1nT/KrFR1GVTVewC8pgMlAVAfLACE3wKbNnskHPDTRJuvLRNgMpaqEYLE MFGA== X-Forwarded-Encrypted: i=1; AFNElJ+hOqvnqAvWeZxNp9+GQnPQcO+IzWt3R009oYh6vh4UnUA2WBC093d0ke0mnviXB/xATBqEAoCPJ/vPcss=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Ie0HaCsCs3rI7UKYQ83vetYBZbc93PnXSU2Sl90VJFoFDpgd nBjqN3VLXCE/0G8X+9LTaMkusuV0l/94KjWpaKI0LZY70fywcpL1HACN X-Gm-Gg: Acq92OGYImtDiS46XEffO8es9Iv7OILyTSeNxVUSfqiopY55Mgm77m1at/YrgREu2pT TbG2Tj0hng6+Sod8QsrdTZOt9EtLwl7RXpyVR6NIz3jkmlR2kCFt9iVRhUEkoShL1DDJhWAhQ4x y0PKV0x4kIbEPnvKJEeAIKdFmNIvZ59sEkChFAPoqeo7GoXna/q04SYFdzKVBMyDknyV3gRYRJ/ F9NzHUEJjPJ9IISKE48QodV9Ao9o3I4e9m8P9937mZOnBYtKumfQ5E6l3fYa/MYyOUNVed+PRyr EaognpI4rR/OpPxIL3seS8ugL6zm8iE4aESa0k4PHAX2hBk2p1VAJN82onuZffnO/KLmyJzn8dp ek8+5sBVDP2I50nNklaOVD4m28HeVTO4tGpoP9OsY/95pZU1sdPhtyxme3U2TOGQA5pFA5DXOhD 7VKaJy2OLFB76bAWKw4AF1jjpIx/FgM7q7xAvXGWwr7aMGSSKpq8Uissyza48wIaq37LlOyQkyO MexQ+RFWAu6Rb6Qys3XdSZ9Kdg= X-Received: by 2002:a17:902:d2cd:b0:2c0:b74f:a58c with SMTP id d9443c01a7336-2c1ec7972e4mr167544185ad.16.1781009223982; Tue, 09 Jun 2026 05:47:03 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d40asm204686345ad.64.2026.06.09.05.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:47:03 -0700 (PDT) From: HyeongJun An To: Mark Brown , Liam Girdwood Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Viorel Suman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 3/4] ASoC: fsl: fsl_audmix: Validate written enum values Date: Tue, 9 Jun 2026 21:43:15 +0900 Message-ID: <20260609124317.38046-4-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609124317.38046-1-sammiee5311@gmail.com> References: <20260609124317.38046-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fsl_audmix_put_mix_clk_src() and fsl_audmix_put_out_src() convert the user-provided enum item with snd_soc_enum_item_to_val() before checking whether the item is within the enum's item count. The generic snd_soc_put_enum_double() helper performs that validation, but these callbacks use the converted value first: the clock-source path tests it with BIT(), and the output-source path indexes the prms transition table with it. Reject out-of-range enum items before converting them. Fixes: be1df61cf06e ("ASoC: fsl: Add Audio Mixer CPU DAI driver") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An --- sound/soc/fsl/fsl_audmix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c index 40a3b7432174..f819f33ec46b 100644 --- a/sound/soc/fsl/fsl_audmix.c +++ b/sound/soc/fsl/fsl_audmix.c @@ -117,6 +117,9 @@ static int fsl_audmix_put_mix_clk_src(struct snd_kcontrol *kcontrol, unsigned int *item = ucontrol->value.enumerated.item; unsigned int reg_val, val, mix_clk; + if (item[0] >= e->items) + return -EINVAL; + /* Get current state */ reg_val = snd_soc_component_read(comp, FSL_AUDMIX_CTR); mix_clk = ((reg_val & FSL_AUDMIX_CTR_MIXCLK_MASK) @@ -157,6 +160,9 @@ static int fsl_audmix_put_out_src(struct snd_kcontrol *kcontrol, unsigned int reg_val, val, mask = 0, ctr = 0; int ret; + if (item[0] >= e->items) + return -EINVAL; + /* Get current state */ reg_val = snd_soc_component_read(comp, FSL_AUDMIX_CTR); -- 2.43.0