From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4F04218B9 for ; Tue, 9 Jun 2026 12:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009228; cv=none; b=fcFQXcgLAkPkqbrGITSkQ5Ne8jULRpnwvyQtsQCFLqTwPXYL0qJCtDFKMCKAFG2S4FwoS031gcvWhqxkRL+hbzohRNj5C309IDpExGhiJURqNEZOncfleg2rosB2jsu7cjlHbuiTUmJHhTTFWjk7sbhV8YzmugSZVAiN8DMjzds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781009228; c=relaxed/simple; bh=vmpPHzWQcVKPEyter5TRYy9rNPMmYOgmdhkqsB+Z4QU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WZvS8Yz1zg5jyDg4f0ljmy47g7ZJZIrWSVsMjf9qHLHY0PBYbaJKZWtViXfXNL13DViGKMVR/DxlsVBz+PP9o6NzbBXvQ5IOyA42CR3JEJm3qr3WvVyH0yp0NU/zhpejh0ippgUbzS/2oeNWpAIEeyi/Ov1iKYTIVXiwSj9w3dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LbA9x+9s; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LbA9x+9s" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2bf1cda2b17so40074335ad.1 for ; Tue, 09 Jun 2026 05:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781009227; x=1781614027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TISoh0w7BDB0zbR5ef9JxLmIW0ux+sRqbIVLhaxSqQg=; b=LbA9x+9seDdhI0vz7BEA7oxGbegNymDMWyqfWIaI8Eg4wM43W6g3Ca2AVfA3wR3a+g cJa4T/tS5vRJ8wqL+KRWZjViDXEFDBYGEfeMb7x2GCfponxVs+w2UPpgATRXutns8BRB dkkhcXZnjaPY58Hq+OVO0iHSZn6F/munVS06sUwdcmEcZHapXHgIJvIpmmGJsd1Yx996 TMMDgTs1yhNh7RxgvmlcsecGMqVhU10N8/D1NHTvbogdryd273tz+1AZnoDMp4ZXY+hy K9+LFkqpfQPHhANiymtyd68qqHMja0M/4IdPRZEO4cGFMXYD1Rv4Xe8+D7j2NDd1NXBo NR3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781009227; x=1781614027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TISoh0w7BDB0zbR5ef9JxLmIW0ux+sRqbIVLhaxSqQg=; b=IXqhpmktDE+emTIOsgSGAURlpgL6urOzmHGmIoP8ZeCWhVvrhLMIfMem+HVW8gJpoa seU0+Rqe6L4ge2aEtBYW829EWPdjziISKoNliAFNYZ730EZpUcTJbCXvJDjfwaSbtExM 7XwKmgwElq/OhjxrezxfklyCQoR0RKR+qvS0YbXNZ2OcZFRyFPn1EQD0ZwzU8L1Mh1Lq YGTXiYDSrU6a85srZwXIGn/WBn2NiGzdJToY3edtYt7eEaO+mpmahJevE/tPc2s9ORwL iw3YjRwP96vxmhRVSPPEA1+vi7KMLUWJmaJDkSgG8qY49NnlIDwYn+Hjl3PADPoGKo66 PgLw== X-Forwarded-Encrypted: i=1; AFNElJ/s3P5nvKWJgfraxURvW1Qg+JhaKmtsjivAxkVJlPIqm2Sw2jRTbjcotceg+IdD+JTvuu+5NTzyRV9DkwM=@vger.kernel.org X-Gm-Message-State: AOJu0YxhcXqwzbuTvdAURC1yeQsLy//8Ph/fD8B4UNLrjQvcGXJRB+kl as/4hExnJy96f/SElDNvcUBnRB2NnN9cB0kTfT9q60dbOMLLy8MjbYD8 X-Gm-Gg: Acq92OEqkNjnVMKUeXvO/u5becIjPtFx3YetKdHgZ+EyFFyZ/0dGFtWyTdY7l63J9L5 6Qp2K1xM2Q2Rk+mm7t9+MSJzTVBkKtonIRM9/pf2b1imsTNYa7frxCeN/Tvviq6iIdLkpu/bD9f zCG4ZZhU6HwnzCGBJNlMbf/Ua3qBEcZ37b65y3rkV+CR6rYOMpL6XCMF7lx0+4UM9hTcvAnKOn4 FcZ8XptnhrOXEZiOx9w4uyMyRfVR0Bh270c4fFirvc1A0aEaCPa+ETdzBqoJgBn6Mfls/+fMdj4 IY3Kug0LMEhZDY4cyQ87ClEsqkeSSBr5dfnv89ZqmDiglU5qyxgyeIbolAI+Rs3ITvSzhBlY5MC 8YM47VFCpWV8nHPxiQWBIS2pYkknoAbsK27m1KKITJ2z8pp2MoEzRE9w5cZIlDLFU5kqM+/wPin zZDcNA2d/BSQ6vB/1n5x/c7TI3IDjoBAnRyHsBJIJ+Ne5kw4U4/6BdToyOLCtbL+fIfOiGSOxE8 CrZjj7iJfKuHD8zV9fZUJTku5c= X-Received: by 2002:a17:903:94d:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2c1ec508177mr181898005ad.7.1781009226863; Tue, 09 Jun 2026 05:47:06 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d40asm204686345ad.64.2026.06.09.05.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:47:06 -0700 (PDT) From: HyeongJun An To: Mark Brown , Liam Girdwood Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An , Thierry Reding , Jonathan Hunter , Sameer Pujar , linux-tegra@vger.kernel.org Subject: [PATCH 4/4] ASoC: tegra: tegra210_ahub: Validate written enum value Date: Tue, 9 Jun 2026 21:43:16 +0900 Message-ID: <20260609124317.38046-5-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609124317.38046-1-sammiee5311@gmail.com> References: <20260609124317.38046-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra_ahub_put_value_enum() reads e->values[item[0]] before checking whether item[0] is within the enum item range. The existing check therefore happens too late to prevent an out-of-range read of the values array. Move the check before the array access. Fixes: 16e1bcc2caf4 ("ASoC: tegra: Add Tegra210 based AHUB driver") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An --- sound/soc/tegra/tegra210_ahub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c index ece33b7ff190..efc8f3388668 100644 --- a/sound/soc/tegra/tegra210_ahub.c +++ b/sound/soc/tegra/tegra210_ahub.c @@ -62,13 +62,15 @@ static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, struct snd_soc_dapm_update update[TEGRA_XBAR_UPDATE_MAX_REG] = { }; int val_bytes = snd_soc_component_regmap_val_bytes(cmpnt); unsigned int *item = uctl->value.enumerated.item; - unsigned int value = e->values[item[0]]; + unsigned int value; unsigned int i, bit_pos, reg_idx = 0, reg_val = 0; int change = 0; if (item[0] >= e->items) return -EINVAL; + value = e->values[item[0]]; + if (value) { /* Get the register index and value to set */ reg_idx = (value - 1) / (8 * val_bytes); -- 2.43.0