From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 642A3419305 for ; Tue, 9 Jun 2026 13:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781012131; cv=none; b=sP237pFFhvuLFggee9K7faIKyX8AfqIgjVT1DW/AFsfG2Ud3UzZE6MRXqmAL0KlKeYBs0CYNX/c0zRkpQMa1ffhjZD9fJTlCkezAkMEwZd9b2q6InUq4QAWV8mja9EDPDuSG8EMJHQ1f1gDAacqAgPpZPjpxyYt8q5Rhw/6wNcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781012131; c=relaxed/simple; bh=jpxnrGycI8rKTjiQaBOGwhUXMd0O9eLBVdSkKkFGyEA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PpCpHtjZWSjlemLvo0CUOw/WfOgB/iv0t6Smw7dc4YIkz8cWmj39vO2QNSEzjy9IGuWYO52T8mLk2D5LzdUCEjKjfjbHEwFrLQ+9pHbG4YPNlpLHlyTkHT17cLyybS4mRsP+QYIf6rVT60e1Uy3OBunLiWGLOJQIedoLLyXzfr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YHuaSFE2; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YHuaSFE2" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-36ba3ea5c46so3256198a91.1 for ; Tue, 09 Jun 2026 06:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781012126; x=1781616926; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZcKDdH1yhiVL50Qlb5vKMH/mf+UgMoMx7KZoBbcwRZQ=; b=YHuaSFE2tmLhSiPEJEtCfTcIfHf6qoucg5x48pSSuobOq+WsqX5h1k444K5BC9nCGE q6Xr9gdDAewmKbjGVfbyz1y8ZeDBeHHFIXLWQRijEyMr3Iv42flflVAVcEW0gOQY8nwv NoTOtchlCBjFqpJSguTcOa3CIzZnEP0BrLI1ErkyGV7m2wXGFcTh+9n6u1pCLYOtk+6B RHrlmU4ixp3fGiQLS3xuNEj1hZTSGhI/oH8uzg7pb5Yo9CyLdtVpIdQfebdv8lJ7XvgX FJrJhNIsrIiJfq9AhXyllkI7sCNMalVO+U+mdwuSv+H0F3cdr4mdsR8HXe9f1OWtUXDc yUTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781012126; x=1781616926; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZcKDdH1yhiVL50Qlb5vKMH/mf+UgMoMx7KZoBbcwRZQ=; b=fOZdh5Neo7qewdKWAJnt02JelkmiQPl6uQYuJoKou1Km6mBtvT6XAQraJ4tT/HZGxV r9XVghekljt3eSQWjo9TjyjlyCzvpOPF1N+sME4Ph1ViS/eMTC7XxAJkPmotxWjXs5uu 61TphNhUpnoy6lcxnr+yEfzsSWailuMr/Omzooq5hpxs78491viOxdSbluSRgq0yTjHG 1i3918T+nNb2oLkderSoGEVePlwuNXtUwKXShUeFVNjKeHUciR7vLr+ZwrwIMmGMztrf VQMCGrRpSRxKpbjROT68G4EqttgqyIFUU+vPQZm/pucyRfanlQlkiz0W2eo/tO8GoF+f 6gtw== X-Forwarded-Encrypted: i=1; AFNElJ87tNGfb2aa/JhI2p24Vm1ZZxXE2nlITQOUQFghzZW8pC9yzz38Q0FyQm0g1/Yg6dKkej8smTFt1vWkk+w=@vger.kernel.org X-Gm-Message-State: AOJu0YwZE6VK3u8qQ+isRzWcWpjhmBLqMGYovUbcBqjn9cIXXp7HO69Q vWrN/fPVuqm/+jCSJMbk3DR/ED57RAEj+SN5jVaV7eVk29pxyJX3TH01 X-Gm-Gg: Acq92OEYDwxrRkkKbzsD1P+bZzR5TRVLITs/1rSWly2geu2UTKoiOSRPo3HtjdIoO7x 36x8tcQ7YrK88rVNWssGVgR7F+rTVwGldLbnO1CK5YGMOnyGOuir+fILTunNUIc3HT4H1o/U1Qy nABAuYJdsOC7E4+FSNv+Sd9P7J6p1oF99qaaMrP06U3tX969wlR7914gq25KWWjRFC8iMKOYayY Uci02KlLluQt0LuWMFVkVaERJsHIa1mZPbre7AJ+zim1VCJTNwBhJaumSWaU57JGEipFECQOGqx vfkhjwBL09taxrLWwrazSf0hiPglepQqNuluhU7K5DzbIPUtd5scyHWF5qz8NXCddbsVzpWRoLx q5sXtFxCwuNnrr2e5k2oRHdhO/Ivdjpl9Z2505N838fCGee7aj8f1hnW2nwStE/kP5Yonlk5Sah l6M3CWsZ/1K9ZjM9+sZeJxERtuDy5ZkGlg5GBssHLXu/U20thkwnJMVM8qew4wShjU0MTpb9JLg 6xtq2HGVII00ph0kip6P7Zk7xEL/6UN32hJQMM/CfY5J9ocqSgYv+O3Sma0fWtj X-Received: by 2002:a17:90b:57c4:b0:35f:b647:d98a with SMTP id 98e67ed59e1d1-370ee64373dmr21339868a91.5.1781012125708; Tue, 09 Jun 2026 06:35:25 -0700 (PDT) Received: from localhost.localdomain (n49-176-80-106.mas22.nsw.optusnet.com.au. [49.176.80.106]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf827f1sm23628719a91.3.2026.06.09.06.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 06:35:25 -0700 (PDT) From: Weigang He To: Krzysztof Kozlowski Cc: Alim Akhtar , Marek Szyprowski , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH v2] soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap() Date: Tue, 9 Jun 2026 23:33:20 +1000 Message-ID: <20260609133320.1748882-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit exynos_get_pmu_regmap() obtains a device_node via of_find_matching_node() and passes it to exynos_get_pmu_regmap_by_phandle(np, NULL). With propname == NULL the callee uses np directly and does not drop a reference, so the reference taken by of_find_matching_node() is leaked on every call -- including on each -EPROBE_DEFER retry of the only in-tree caller, exynos_retention_init() in the Exynos pinctrl driver. Annotate np with the __free(device_node) cleanup attribute so the reference is released when the function returns. Found by static analysis tool CodeQL. Fixes: 76640b84bd7a ("soc: samsung: pmu: Provide global function to get PMU regmap") Signed-off-by: Weigang He --- v2: - Use the __free(device_node) cleanup attribute instead of an explicit of_node_put(), as suggested by Krzysztof Kozlowski. - Drop the former patch 2/2 (regmap lookup helper refactor); with __free() the leak is fixed in place and the refactor is no longer needed. v1: https://lore.kernel.org/linux-samsung-soc/ (<>) drivers/soc/samsung/exynos-pmu.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c index d58376c38179b..265a095316079 100644 --- a/drivers/soc/samsung/exynos-pmu.c +++ b/drivers/soc/samsung/exynos-pmu.c @@ -167,11 +167,13 @@ static const struct mfd_cell exynos_pmu_devs[] = { */ struct regmap *exynos_get_pmu_regmap(void) { - struct device_node *np = of_find_matching_node(NULL, - exynos_pmu_of_device_ids); - if (np) - return exynos_get_pmu_regmap_by_phandle(np, NULL); - return ERR_PTR(-ENODEV); + struct device_node *np __free(device_node) = + of_find_matching_node(NULL, exynos_pmu_of_device_ids); + + if (!np) + return ERR_PTR(-ENODEV); + + return exynos_get_pmu_regmap_by_phandle(np, NULL); } EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap); base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 -- 2.43.0