From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D070133F5B0 for ; Tue, 9 Jun 2026 14:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014554; cv=none; b=LBcVX2pXQh1g1BQXke6BTi7cPuIaICRjLWc8ak9Ro8jg3XNm6bxGD/CMg67d6UC++bOtpwdZq9OAHrK1NkE4+Z/NgRv1dA7fxmZUowYromS84N1bUY+aku79a6PGqsDWOQRUv+pE6wbqdjg+Qbj6PJi9uooMoVmtIbtoooEjfRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014554; c=relaxed/simple; bh=MmkUJTtuyXY3s/7sXM+BP/PzWFzsXVq+eKe6PElRRWM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uglIWKDbIT7mEAy5LGe63Kiej0SlRR4tDAyckMQNfGsSomDSwXJb4Bss5ObOY6HKCzBY7qc5q2LnYq0NudMUdtzr2YgSwPgHkW7bpgS8hI5wP9VKXD56Rm2l77rHRca0f0bHzPm9yi5PQzW2PlP1LBzxE3WJtxMOsOz1PkKR1uQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=aaM+VksD; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="aaM+VksD" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8ce9df31130so87736126d6.1 for ; Tue, 09 Jun 2026 07:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1781014552; x=1781619352; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/t/KVtkqwokTt2oNchcdf4xUUArUEApR4RsM4t4GGaI=; b=aaM+VksD81FwB9qeScW7Sviahb1dkjb/ysJ4WiEyEGLyTs0Z6cGucYu+dxVqbdpXRi f8gbU9i+o6e3FfWrmod8ExT89VcRLxM2HRnfSfDDzhaduA3uN4cR4Vd0tWpLyYtguRHR boHXaNm4jeKhWgSqym8XL+I7kQxM37q/Hctx7UNd9wCj0vbFATeAYasZ+qkq4WEdzXHH 5xdTUaUOLnZKWZG0z4Tu/QKNDdjdQT+oR74Il5Vmx3mmgs58Be40v5pIqu6YzMnzzInY hjSMgGOfFHBJocJUiljwGsMNozPcr0jeQdE6Q2PLAcQtj/hi+jwCnC0dTaLYm+rkFccJ VYzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781014552; x=1781619352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/t/KVtkqwokTt2oNchcdf4xUUArUEApR4RsM4t4GGaI=; b=Z/9qZ65ncAtjrjmvHsDGMENkKU6KR6YMtOLj8xES7LL4Hx1WwxDHY6NOhsKSttUy+5 vjSwohgUdIoVNK2eP++UdsVTqvMtQIzojkbj7EH5DRX8QPVWwjzWLnmLt0L7YnT4io9u SGv5T7wUVrY0QA4k4lttRHF9STwd5uD6Yy4KbXgUnuhGgSxTfltLb2KnhzxKnRKXF67+ ETzjq9c8krvCXv4Gzss9ZeRel+jo+QO8JpYsWlsT66tDcrTira4BPP1gbVjZbicJWY/B ogF0hYrZsc83YO0gBkiGHfX5UmtYEagMjpbjyMyVkQoxUK9ghqRLT/FXbvQtlm/zvDGS TDOg== X-Forwarded-Encrypted: i=1; AFNElJ/CZ+QgpJIMj81PwJtVtxIEVWWjix7cLGEGmZ7ZbTu7a0j1gulwfxocAn94gN3qhtnc+ytVPPpmlIitA8Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3IJc9541w33ncaSSGwzrIz43LlqQ4qMBJszM18fz5Ad2DbqQA VMG33qj1K1p6epX4+idhdVen+Q/lwhNYFsKUuxJcIxAF/PoWlm159rAezZwf8jxMh1s= X-Gm-Gg: Acq92OGrqrKW9wRI14eZYDJVZzyoqX6RJJ0EbJmcONsrbtSxKS7JJmODsQfcCwbBbRs 2o8b1+gwohTK5Ef4drRFRN+FDSTlsq8XqaV9/6POrCvK+KtwaNEoqdEqALTyAweicDdza51XM7e Az9yb305C321NjirILvxoEqfytDFxx8968F5hc1oNgRsobzexHgWVfBWX5mFCO4wysqZIpKFFOo Qi4G9MFrA6FPrci/+Ze3Pdn8B9v80zyqUZ2HiIkxSZAwLFBL3HZ88Vq4K1wmO554o01xo9Tw3xi blZYcbvNJsDPxTue7x12PNtnv7j5dvmahf9sEQ73bznJuFAvY7uz3IIzQ1tgn78LVr8j+ioaEL2 iV6QG72IjcMe9NMt1F1CfPeQ9mIctcgO9xK3lOeJ+0XlaUfUnUoHR87qSi20+hss57Oru3K8zDt 5/V9Rl0rSNkRpFA61gcI0UPfBYRXg+TKoSd7CMT1cguHQWnYow1W2oZe+8/AKH7qQSsC1jNbGch wIGRTiqHAivOF8W X-Received: by 2002:a05:6214:626:b0:8ce:ba04:7bc2 with SMTP id 6a1803df08f44-8cee626f0eamr293032506d6.38.1781014535341; Tue, 09 Jun 2026 07:15:35 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd077be8sm204702746d6.40.2026.06.09.07.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 07:15:34 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wWxEs-000000021xL-0mOX; Tue, 09 Jun 2026 11:15:34 -0300 Date: Tue, 9 Jun 2026 11:15:34 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, stable@vger.kernel.org, Michael Kelley Subject: Re: [PATCH v6 14/20] dma-direct: return struct page from dma_direct_alloc_from_pool() Message-ID: <20260609141534.GJ2764304@ziepe.ca> References: <20260604083959.1265923-1-aneesh.kumar@kernel.org> <20260604083959.1265923-15-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604083959.1265923-15-aneesh.kumar@kernel.org> On Thu, Jun 04, 2026 at 02:09:53PM +0530, Aneesh Kumar K.V (Arm) wrote: > @@ -270,9 +270,12 @@ void *dma_direct_alloc(struct device *dev, size_t size, > * the atomic pools instead if we aren't allowed block. > */ > if ((remap || (attrs & DMA_ATTR_CC_SHARED)) && > - dma_direct_use_pool(dev, gfp)) > - return dma_direct_alloc_from_pool(dev, size, dma_handle, > - gfp, attrs); > + dma_direct_use_pool(dev, gfp)) { > + page = dma_direct_alloc_from_pool(dev, size, > + dma_handle, &cpu_addr, > + gfp, attrs); > + return page ? cpu_addr : NULL; > + } You should probably put this at the start of the series so it can be backported Reviewed-by: Jason Gunthorpe To Petr's question I think this just shows nobody is really stressing the PCI dma paths on CC VMs today. if (force_dma_unencrypted(dev) && dma_direct_use_pool(dev, gfp)) return dma_direct_alloc_from_pool(dev, size, dma_handle, gfp); For instance the places even calling dma_alloc_pages() don't look like things people would use in a CC VM. Jason