From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCBD32ED4E for ; Tue, 9 Jun 2026 14:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781015943; cv=none; b=Cg6LptGJjURoTcLHYSHZ7BrZpkhI6aJPUdVImwG29svwNuRZTfPaDNe6/h61CAy+oGK55JIZvtRMd4sndy31S8qiFf8fg8BD0HwJaM+++IZfZONbIymSB/EKtO+iGjNINRYvI+r0CsbNRPEjze+YIJB/60t1Oeao+fJRjZnVUTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781015943; c=relaxed/simple; bh=97aE7Ww53/xYTnf/jGN6p7aLQq344lXYs6Z17FpXAds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NzQnkvU9yvoHgUBUIDtVwTXoa7mZYWb8yuikBGIH+oUJFHusXqT0u3dfSCsFyNOKTxCShNcbS2tcWnk+qlYINBhaifiR6txUmip3RvRR1qeGUO9jHH6bog/+lIyWyIsFbT0irsC+t4zVHnrOTR2bG9ZYZ86qMb8J2+jrOAHeBL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FjclAejP; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FjclAejP" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c27fc587ebso9720415ad.0 for ; Tue, 09 Jun 2026 07:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781015942; x=1781620742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bES0slIYsqJ4nlNrDrdS0ePhgxZqsdotlF46CT03uqw=; b=FjclAejPsXEoiLR6t0+lGhJVn+x1Kx6SiRpBDDKp5SSwTJoqtDKpdK0KZkOcTcZuxe D9Y8Nf8VXmN30E+hjoUWFyXyQ7FvH1W804nu0191qezA7UYeKqrCERxu/x6SbG6QMC5j oHzeUbdCSiaTXItUqcC1BlvwShykth88aeumeCLgH21mQBEp344t+ZwDJXQm6kxdB0bU o/oP5xpOqXHBtte5Uo2w1Iid4fx3mz8Aa7HOBSSzJNSnfN6kzwqQKAjGdFB1kN0EWJwk c95xuP2ib49KbP6EYJHB4COoUXGym1EqzqyCy0IDGl57JPEKeiceM+QF84k3vFhnyhmL nrkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781015942; x=1781620742; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bES0slIYsqJ4nlNrDrdS0ePhgxZqsdotlF46CT03uqw=; b=DhCyn7l5T4A7JGqSlR54F5YLVJc+bO382/Sa3fpZ0Jti0XBlxZtB39b/+jHMtqrbeV ib6UmNgEn9vfEyWDBW7998d3mAQOlI/3KeRLlSJGMB5mQKZUB97W7tx4gsg853EMA1Ro RkVVFKW83TToH/SS7TLUhy/w6N9OOQLD8RNP6inajxvMQUn8qxLger0QJL5UFcudASx5 S2K9HmHiEJhkALOIqDoG1ny+IEgFFOq6I0LefEqw6DHmcf6w3q0lQ8T6yB5hRNiQMSXY mBO7GaphlB0gXpTEkAUGhDEWBw2nOsheQF+iB5ZqoXnI0PWZ9+eWf36hhTTbu7O4oKUq B6MA== X-Forwarded-Encrypted: i=1; AFNElJ8eHcwj0/Ry4DN+5Jn2a5CXxFFVnE3gZKBfGjt3Ms/uD1lOYGb8O2RFsWxRlvWYwzdfE4BTjzEBW9Tnh/s=@vger.kernel.org X-Gm-Message-State: AOJu0YySyFxoUY+1/VTNN6iK5Hxn+LMRtQ1N4xCMwgkMWdrzJ8ZWmPel IaGh6KBBKsHTc1zTG+YJ+lzt6L7T1JiOILbuu0gjEVXytwo0LiGITI2e X-Gm-Gg: Acq92OFIP6DGs0CXcOW6S4Co/TQTD8cJOAJsGrEmih1z9BHJc7qdz6XRVWYlb9mFp47 jFHw5Wjm6hZsdh9WchmVwLz66A+qRaoGSTPoGSJ1MxWlq8GW6lGBeQMGeRX7RCeyC4wSIGwmVM1 EYtFssdYYvXyHrspGzn+a2e2wrJuG/RE6E6t6+vU/gd80jYo1iyyDhOBAKGKgHbQlJDsm6auXQM j4/vU9alY23MXMhrSkElGcocewuRPEChOO2cg+I1adzgLdSngLmZ+XPhG+f8H56Q0sPLyzd9dYZ cHKKjvlcVqrenDXMyDx7xxAvQOhXyNzHp/pRA3bjcuzlX9YDwuVPc8JQ/ExV7YT2wprkW31yrtc +5FwyNevjUcz0t0EH/nIkeI7EmBDQ1WT+JSZEfsCDiIpxQprSmXJWb8xS961bCNXU8PkZ8s6YPJ NrFB8FsnVrlwIGYS2eHBBrAP5Uh0ygABwqAeVTG5/FJ6wxB1vdDFKnf7f6WyZiQr1/BCGQC6TiG Vy3qMctn1cHvCnQRB4eLaZkPuRmNHcEkdcUBDd9OOp6KPzsa9pXzg== X-Received: by 2002:a17:903:2451:b0:2c0:3400:5c34 with SMTP id d9443c01a7336-2c1e78e03e8mr237284925ad.3.1781015941960; Tue, 09 Jun 2026 07:39:01 -0700 (PDT) Received: from localhost.localdomain (n49-176-80-106.mas22.nsw.optusnet.com.au. [49.176.80.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6e86dsm220741875ad.8.2026.06.09.07.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 07:39:01 -0700 (PDT) From: Weigang He To: Krzysztof Kozlowski Cc: Alim Akhtar , Marek Szyprowski , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH v3] soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap() Date: Wed, 10 Jun 2026 00:38:52 +1000 Message-ID: <20260609143852.1783558-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit exynos_get_pmu_regmap() obtains a device_node via of_find_matching_node() and passes it to exynos_get_pmu_regmap_by_phandle(np, NULL). With propname == NULL the callee uses np directly and does not drop a reference, so the reference taken by of_find_matching_node() is leaked on every call -- including on each -EPROBE_DEFER retry of the only in-tree caller, exynos_retention_init() in the Exynos pinctrl driver. Annotate np with the __free(device_node) cleanup attribute so the reference is released when the function returns. Found by static analysis tool CodeQL. Fixes: 76640b84bd7a ("soc: samsung: pmu: Provide global function to get PMU regmap") Signed-off-by: Weigang He --- Changes in v3: - Only annotate the np declaration with __free(device_node); leave the rest of the function body unchanged (Krzysztof Kozlowski). Changes in v2: - Use the __free(device_node) cleanup attribute instead of an explicit of_node_put() and the helper refactor (Krzysztof Kozlowski); dropped the former patch 2/2. v2: https://lore.kernel.org/linux-samsung-soc/20260609133320.1748882-1-geoffreyhe2@gmail.com/ v1: https://lore.kernel.org/linux-samsung-soc/20260609095224.1706036-2-geoffreyhe2@gmail.com>/ drivers/soc/samsung/exynos-pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c index d58376c38179b..f5fcdde9750e2 100644 --- a/drivers/soc/samsung/exynos-pmu.c +++ b/drivers/soc/samsung/exynos-pmu.c @@ -167,8 +167,8 @@ static const struct mfd_cell exynos_pmu_devs[] = { */ struct regmap *exynos_get_pmu_regmap(void) { - struct device_node *np = of_find_matching_node(NULL, - exynos_pmu_of_device_ids); + struct device_node *np __free(device_node) = + of_find_matching_node(NULL, exynos_pmu_of_device_ids); if (np) return exynos_get_pmu_regmap_by_phandle(np, NULL); return ERR_PTR(-ENODEV); base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 -- 2.43.0