From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005E643C07F for ; Tue, 9 Jun 2026 16:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022687; cv=none; b=MshA08QQnOnZp5EnYq4/Xsa+qeaM5pd9ruvU0KOoWbb2hCHD5gA2td8jEWBU4xBV/sRI1ActjozYEwAliaTY6iqHudcomRh4vwL6Q7B3oV+ekSRpzjNTD2ujVSS3joLHLii3FTPOUqQVUiOqXYpgB5IciNxwJjfZ8mhBTLYlE7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022687; c=relaxed/simple; bh=FRg9Eu9QhiI3/I6NgMvgK88AoQP9jiLCzpjsRaCrM1w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tPwbqYUwuU1cD6RV40zgOXkIIYbE6FgK4fXPPgi+fDz2qOGgvf7pfWRG7XySLj74hGgAM2hT8w0wl+1/RcaPuzVXWahVQlyMns6yEO8XgadDVEe7VPQ9o+i8uqUSIIz9U9RPQpvBPCYBgNVRJGB/1RxP/ABxt1VSNkc/glUDYH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IRi/wk1B; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IRi/wk1B" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c0c2c7d45eso51879015ad.1 for ; Tue, 09 Jun 2026 09:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781022685; x=1781627485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TcMeU35QKR/m7p0ys0S4K0EvNKBoe36L4mK1QCkh7IA=; b=IRi/wk1BdcqaWByMeEt9Bxy7LMhrl9XIeNjeGyZAbrZxW+9XYUQxo+HZW9X8BJ1nAp W7eT62eBbGavrGblFHUcIqOZDSo3W36IjSnE/4o76RC9rTkKzgXMUZftnoUMZdc0v8vy xhtugYKCRiBerZ8HxvtH4lQSuCYwtKgDUtiMqXSzxh7sksTfBhvvsqZBfOrbOL1pT7Dc rz3zLVcB0Xub2xdMuYNNF1zf3SLoADyiavt+E3mCL6+sRC3Gof5ABENV80uAdZ14DVsg 2arlVligUZV/xhKFoZKRFiYIIs1LF04ejjli/2MRPHP+4hAzNMD7q6ivbmJAOY9yKLrE /f7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781022685; x=1781627485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TcMeU35QKR/m7p0ys0S4K0EvNKBoe36L4mK1QCkh7IA=; b=VKkRGU6JE8ESmnQpNNL6pgbH/4/ugePs6MJjRHpEarA5+E3JB3PnODkBEPYS1XzNok lLCfHY6y6F2w463xzQYA6/2EdlKAAI51h663h1s/ZmDSWwlyf9E2mcg2/Fvv0BSr5+1x aNZ3FcvlElHOMXMpJDomrYpGub4cJGtID7ercGC86BxukB2ZYm/b4oZLN3U/1Iwkuo/d tg7tUpmpcWotHnIvnrQOEQpX53E0xJE5Ybh5sPf4gg0T4r7Oge5b0H2cMhsDM8HRCSgK wHrCEn98HM9UUnA0UiQ3UlJnHJ5WcMs90+ZEe8oWH7h/zNrJh/deHl/AcNlT1P6GgOiH xijw== X-Forwarded-Encrypted: i=1; AFNElJ9adrg52AeKs8dds9gSZV1z09QVx0Y4SI6xMzNVEhrgA2Dt/9RKge2Q0zfrcmXR+3PrfTAFzl01Yz5e95s=@vger.kernel.org X-Gm-Message-State: AOJu0YwfrIhr5bw44TYAc1P4gAgkZnmQLwQX1C77FJXQsGAao3HeEz7I saCXxGdHk2Qe0h7DGfY1+cSfjxSltcHwuzgbsxxCas5PWHXuBwiQrGS8 X-Gm-Gg: Acq92OGnZmAApNim+2dcFb84LtlK1UBM/1O2m3L3jpiJKfbSavK29bus6qJlezSsEBQ DGdekd7UvlDQzIzkuPj9kgOHal+XKk7qGeJY9Qgku6N+QaASziH5YzqRRdEKbJC3n642qWTH1XF CrlSBO6M8cDiWPudXErZ0ZrRQax0qE876cfjYJWmR3Zs8lqRiB+e0Tx+wsHKVR3+Tf4ipoq6UMh 5mW7YbExHyF9GR8VMoq/iWffwDZSBMrjXFlhNm7mdnW9vWQukckQTM+t0UL4Erjtp60L01j7KQN +I1pcZjLeQmI8qGa2KSVAsH8N4C5+39Jgwg5zsOdeWrFYgkuN7gyoRVwSZGj1iAWJx8Lr0dsh+3 Q3ll/WoT5Jf1jdV176Kt/Mk9dUlZSyT2g3DMntyjeKKjaMDsd/9mWFyM7BUD4j7708VojGWbITm mn/wbWGGgoyFma/vWk0vQVnnThH+LosrpA+vkI5oKH4ArLAGJq4S5dob0Hj8TNzGTWFm/NkA== X-Received: by 2002:a17:903:1247:b0:2c0:b35d:ed54 with SMTP id d9443c01a7336-2c1e85e04c7mr245030845ad.35.1781022685002; Tue, 09 Jun 2026 09:31:25 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d042sm227710195ad.60.2026.06.09.09.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 09:31:24 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v4 2/7] net: ipip: require CAP_NET_ADMIN in the device netns for changelink Date: Wed, 10 Jun 2026 00:31:05 +0800 Message-Id: <20260609163110.1717419-3-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260609163110.1717419-1-maoyixie.tju@gmail.com> References: <20260609163110.1717419-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipip_changelink() rewrites the tunnel in its creation netns. After an IFLA_NET_NS_FD migration that netns is not the caller's, but the rtnl changelink path only checks CAP_NET_ADMIN against the caller's netns. A caller with caps only in its current netns can then rewrite a tunnel in another netns and pick its endpoint addresses. Gate the op on net_admin_capable() at its top, before any attribute is parsed. The check is skipped when the tunnel netns is the device's current netns, where the rtnl path already checked the cap. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: d0f418516022 ("net, ip_tunnel: fix namespaces move") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index ff95b1b9908e..1813f6026e49 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -494,6 +494,9 @@ static int ipip_changelink(struct net_device *dev, struct nlattr *tb[], bool collect_md; __u32 fwmark = t->fwmark; + if (!net_admin_capable(t->net, dev_net(dev))) + return -EPERM; + if (ip_tunnel_netlink_encap_parms(data, &ipencap)) { int err = ip_tunnel_encap_setup(t, &ipencap); -- 2.34.1