From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C59248B375 for ; Tue, 9 Jun 2026 16:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022690; cv=none; b=LoNZDuM6wra6Z2kxogm47ej7YuinwOnxt2pnP74fn9d4OAFEc/EZq1Eq0GJsfDokvOPVRGIdQlownhn6VXQOHIonB7MFnMLVbilluRGYIbY7GPCdDEk435SchhAbtNGqT7buc3mSVgENzgGDTdWg3/r+hCCjwmhwovY3uQrf3JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022690; c=relaxed/simple; bh=CKQ7zjMxV33Xpql5BA8n/9v9zqRfxq06nC1RhTinzkA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rwzrf5yI7EkYFlfCqc7HgluvYcxvOEHOWBG7XA5o+R4q/6oI393MAP+NWKZ7SShDch6MQkpb01x5FeYlXPcs6CNfyd5Dp7P6olR3pNc1vQIeQ0Hk2qcc5vSh9BahpqxCX2LdDSthAChiirF0XqTMvnlsFKGDc9TgogdTIriKCoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CLaFhtzd; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CLaFhtzd" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36babe2c4bdso3539989a91.1 for ; Tue, 09 Jun 2026 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781022689; x=1781627489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mr5itRaGOdJM0OW4OLU24W+WID9quq8c5B9yuT9g/6c=; b=CLaFhtzdY9YR6LphasQyWqWEINehXZ8NbkKn6F0mAP9pEhid7MbXr3aocycNAi1Iyp hp3DIqCiXD3+KKffiYVuUZTdAxZte5S+TNmMJKhMSzB5kya1/cWK3mkHPrCEXxWqiinQ LbS5J+ALTkEQffo2Yn9z9PXLLPj7sbhJeuKtrb+aDKQn027j7uQ3sY3kwHIrMhUgGkux WIgnKE6gxqhBzxD9GSx+TwWBPdo2CqCpjbVZ4NWXs4s0M/GOnUP12ibofuU+/kuIJ9XM w+zC0uQRK9AkXIuU7kXXhxP04xPs/lYgM4ecXyn4qbOSSn/gf/s/l8+qwxiVeeWk0QM1 np6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781022689; x=1781627489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mr5itRaGOdJM0OW4OLU24W+WID9quq8c5B9yuT9g/6c=; b=CwUceqiQl7eeMdNxKg33YysAe9YowFvEqJ9BiqavXDLp3wK8EVL8/75Vbc9EOEBHN1 ISSJh0TELwumuybITs2vi+2N/lHcloxdBzINMTj/RT/OObfFBN74jPOuAQW2kYhgzC9j 65VPa7XuP85++DuTivpwyVa6p/ofvj7VG/a+FvztbiXm8WNSOebQLgZdmUTcS8ZL/ff6 2KrQyUkoZwZpkuayWm8at9P38NCKZiOCm3y/Y8avrNHynLAgWyv/mThgxSWqatZXq5k8 XOfUtt6vUOburCu/ra2llzmLyHs9JQ9wEXzJwM5XN/9BjdwopK24BUvQktxkBi+oglFf /K2Q== X-Forwarded-Encrypted: i=1; AFNElJ9rNyVRpcPYefztzQlNPkj4HXLvQa+Ir6m6zFO50jMJVj9wnZfv5sTSX1ANgg9P/dXwRLij7cWhiTvPXag=@vger.kernel.org X-Gm-Message-State: AOJu0YzaOd5s2ekwY/I5M1UzOhm9KW9yZAhKn12vVZ03lkfLAbv0OsvP DUSc5pVFGS2tPkhgd70K2J8cXqxSQq6USp9ld7m166i9scZ/xqaWmyZ+ X-Gm-Gg: Acq92OE81AT2QY1nn7kurojwvjfRJo66fBMG1nxLDjvJecc246TRD+8omkKJwo26J83 +pkLfT5VeXDLsx3lbTDLH3op1nqSMWcYvHuPIMzsJkRXYfbTO6MYXbbMm2/EkUsv87/+4ab0JH+ WtISYMuPKocWz3jhYlxqhm57bAC6SD0w0fquAXBEVDOa2RIJA5QG8Hm6Nn0BK37hpiIpnTFkBnE UJfkt1s2tmqoBRnnWcmy3fzFzBBjL0jerhQj97GqIOYWSiH3WcbuLaAHicV8Vq50Tzj2kT+i5qZ guUqX/Dlr0mHsufu+WLuZSo8vU7w3RVpW/CMeKgOFsEaY3rQewdBxT70RkbeAKN0NiWS+uf8e+W DnrZWbAiCiDOIwYcJnVpkZza//Xjwn1SusLJAh6NVw3o+PGqRLVPjlP+FLAWe89W9fCYvXoKIMa wecDIBP2C7fRQZW3xcvAKrrgSR5H8J/K2VFgZCfSDyxVkZZ7gRf6j2YFfwW3w= X-Received: by 2002:a17:90b:38cc:b0:36d:f28b:72e0 with SMTP id 98e67ed59e1d1-370ee92adfdmr22988746a91.12.1781022688682; Tue, 09 Jun 2026 09:31:28 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d042sm227710195ad.60.2026.06.09.09.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 09:31:28 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v4 3/7] net: ip_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Wed, 10 Jun 2026 00:31:06 +0800 Message-Id: <20260609163110.1717419-4-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260609163110.1717419-1-maoyixie.tju@gmail.com> References: <20260609163110.1717419-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vti_changelink() rewrites the tunnel in its creation netns. After an IFLA_NET_NS_FD migration that netns is not the caller's, but the rtnl changelink path only checks CAP_NET_ADMIN against the caller's netns. A caller with caps only in its current netns can then rewrite a tunnel in another netns and pick its endpoint addresses. Gate the op on net_admin_capable() at its top, before any attribute is parsed. The check is skipped when the tunnel netns is the device's current netns, where the rtnl path already checked the cap. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: d0f418516022 ("net, ip_tunnel: fix namespaces move") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv4/ip_vti.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index 95b6bb78fcd2..55ec52bc5db0 100644 --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -596,6 +596,9 @@ static int vti_changelink(struct net_device *dev, struct nlattr *tb[], struct ip_tunnel_parm_kern p; __u32 fwmark = t->fwmark; + if (!net_admin_capable(t->net, dev_net(dev))) + return -EPERM; + vti_netlink_parms(data, &p, &fwmark); return ip_tunnel_changelink(dev, tb, &p, fwmark); } -- 2.34.1