From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86869495514 for ; Tue, 9 Jun 2026 16:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022694; cv=none; b=BByoxTYokZszNY3gwvwXKP/VXlCtgqTKubqocBEUSOjc95QYzZZlsJq9sqZNF0voQ2a+pxZjpHwiwrXEXmhE9JjL4IUNEE/O5oRWWoIKaT7988js56pyvdp2gs4VrdqR2OlPd9XT72Kf86kvUWgKNNGGlICnvpSfpmFyZOXsVzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022694; c=relaxed/simple; bh=9CeSQ65EFy++LfGUh9ogh5aCzFhQ1qyM6WnEMY0Q8zY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uMfMgJFQ2Eg/LmIPtGwZYireXyPrO14yMlLZcjVgDsNiX6fJV6kMc5B1uhmWm5pa206N+EuI1N0nyQDp8ri53zR6/C5vM6gp4FA+z6UiMbH+Am1fONpxnSF1hEQWu2OMij6E7uFJ6zWPdQOUSzZL/efKqP0/0HQK3yZV1lLnYDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AajOKwAi; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AajOKwAi" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c0aa420401so44735045ad.3 for ; Tue, 09 Jun 2026 09:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781022693; x=1781627493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b/NUtWL+pGSdZG256FKpKppSfEdak3fTDyGu+gJY7Vw=; b=AajOKwAiXrBCsuRnXG7hDUCjLxFkiy0QtamciUoMbPVBSHg80MJMqHMHHIxFtC4Kp3 jjrZ01g9uI1ZvSa1PHn/MlU1HF2bpk4NbdzwZD+wyz7LEaKlqXOK7+yeKEHpRNV71vDg e8SHdFyWYkDc05DOMHkD5qZYBqRJRlGL19y9qWXPP2bfJL+KOhKMOVlnR+Ic4cld1dSu +bJaVOjHZwxIKqpNnCiXucleIBDP5+ZbaGtOKLPc6MIV+FH4GDe60cT/QygWQic72JXE ijz6k3QqUhEdsdHLT4DW6NS0JlNqixMseVk+JhwhHIA7ZBKtQz9+R6K9vvTn1vqcnbwv OQAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781022693; x=1781627493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b/NUtWL+pGSdZG256FKpKppSfEdak3fTDyGu+gJY7Vw=; b=FQ8mf8LdFo2nmvolDEYNZmhGnNnlxaru+YkGEBG8TRCf7JYSoX6FAt+6TDLBHdCNVf eL1YcNu1OdBQx4LUQOuwlOPK6bp4Ho7kNb3u/M07ofT9ItauKq7iHJ8ns/tltQtkgZH+ Jq6WF+93NQIGmYdPrEUF/I43d9zirqDla1h/C5p0pbb6ko0aj3GPaVUCzk1aESkejin+ U3FocBdN+HTETYdHhaBPrlD8LN7zp63S90VWYy3INkYYRYwP0QMkfPYlvXZGqQmEHvMd IARhrmf7wYlv+obBqPBcwZKZtr9L3mKNaLBj8V+ep4XB2lW6o6AejPEVBBnhVQO5I7mE owug== X-Forwarded-Encrypted: i=1; AFNElJ8tYbUPPNQLcPp2+VcivtIIiBfCuY25JRlnOy+526o8pZ8sBBELSbwrv9GkbWDcLskzhhyDoHUwV0xC4DA=@vger.kernel.org X-Gm-Message-State: AOJu0YzC90+zVjLHkrnaC7Ylj/i0w0INOAoYR+akJLFCJJgw9zlnvEGf jDZahw8gkdoVbi3S+FdmfWqQfhodkv1n6VBSqHvs9DQFcE7QkcMzVbrgsTIN7w== X-Gm-Gg: Acq92OGSp6XYJAQbTKObit86wPQJgA04RYEIvaoC7RaMRNGQ+LvRycgqYZWCLSV4zMa sCA0cuZQ5akyU3a4gIlKnKbiFckTl1SPgaPIpCNqLfo+QILUA1GtO08V5vAHNXNmuh1fYc2ZzFg WgjENz03tfjZPUytrEBoAizMGkvZZXPmk7xyj3MtzUo0r9e7On48+5TScv21LDqYu7RFFTgCAr8 l54Ej01YjvjQ58cZcwt/j0dbzHDwxRyMKi/H9K0Toe5brCEoEvrWpPov+B7cq7A1+HetDKKhvxp mJgcF6N5hOxmvQIqYaitUsFqd+hTcTmoHfzOtEembU9NNCJB52J7X5MkHIXWIb354yTZtccXe++ ha1Njj39kP9sxyFWFHUN0J5OPQQ6eIy1vXTvApjzndH0CsE32rbGdG3r1vri+C/3T8LUHjc+bjJ M++9ZomKdMbXCyOn/9Xxx1KpXnk+hIV+LycDYhqsrzz7WqYTuz7Xq3lLbyJsA= X-Received: by 2002:a17:903:2a8e:b0:2c1:20fe:9d5a with SMTP id d9443c01a7336-2c1e83502b0mr303154615ad.35.1781022692635; Tue, 09 Jun 2026 09:31:32 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d042sm227710195ad.60.2026.06.09.09.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 09:31:31 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v4 4/7] net: ip6_tunnel: require CAP_NET_ADMIN in the device netns for changelink Date: Wed, 10 Jun 2026 00:31:07 +0800 Message-Id: <20260609163110.1717419-5-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260609163110.1717419-1-maoyixie.tju@gmail.com> References: <20260609163110.1717419-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ip6_tnl_changelink() rewrites the tunnel in its creation netns. After an IFLA_NET_NS_FD migration that netns is not the caller's, but the rtnl changelink path only checks CAP_NET_ADMIN against the caller's netns. A caller with caps only in its current netns can then rewrite a tunnel in another netns and pick its endpoint addresses. Gate the op on net_admin_capable() at its top, before any attribute is parsed. The check is skipped when the tunnel netns is the device's current netns, where the rtnl path already checked the cap. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 5311a69aaca3 ("net, ip6_tunnel: fix namespaces move") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv6/ip6_tunnel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 9d1037ac082f..5ff8e057fb1e 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -2102,6 +2102,9 @@ static int ip6_tnl_changelink(struct net_device *dev, struct nlattr *tb[], struct ip6_tnl_net *ip6n = net_generic(net, ip6_tnl_net_id); struct ip_tunnel_encap ipencap; + if (!net_admin_capable(net, dev_net(dev))) + return -EPERM; + if (dev == ip6n->fb_tnl_dev) { if (ip_tunnel_netlink_encap_parms(data, &ipencap)) { /* iproute2 always sets TUNNEL_ENCAP_FLAG_CSUM6, so -- 2.34.1