From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA413CF212 for ; Tue, 9 Jun 2026 21:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040819; cv=none; b=sVMVdZrsyf+0JmZhaZ+jhJyoHBGK4krVO3+aAW44VJrDSDmXbW2dfBjo+XnXkFsJ/aoNAQZsrQYs7kytTXPYMvRSUdVttMHZitItrOaO1kR16gaqxlCOH98gmJrR8h+uTmSG2kFpJpitDs6LhG2FAPrOSD8kRSrfHNXzeasDdyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040819; c=relaxed/simple; bh=m4UAdPRwefNDVYeDao4kkz7JiY2h/cyn5SWZMZrqMNI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PMospV6xaUR0hR03EnNsdKqAZwNg3SFmaXcO9Rf4DoqC5fZ4xysf6nDGuvrUuycnKUZWb5HTjOh+UfvhWOWWbYH6MJ0Puw8Jspk+ic6+smisMNbvkD6L1krZaMK77w/b5+pU3Ym5cshOA5zgwm/Z7fjGCX2GMbYU0bjnmPgm9Bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3oex9JF; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3oex9JF" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso68702875e9.2 for ; Tue, 09 Jun 2026 14:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781040813; x=1781645613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=bZBJjCrkZ3RzSyjUlLWrVA7bCuKkhZfMdp7PMkk/Ds0=; b=Z3oex9JFttgf0Phgzq3dL08h1Pm6jD2b7xCvvd5/UkZtsRXHWDyNkpwr9FWgc+uHAO NbT+oO3D5i0H0ss5RIclGptpgbDLuOUV397HoW8roJG7sII/b95fyl4kyK+KTOyfqav+ gYfT2qZ3+7cgoyAx11rSK1Xb2DHhAcFE9oFoFHBbK1x+vV1ii1zPoW+M0CPwuwzgHXhV OuY2REQEUC2oF8uC0s2scNYxm3Y5xpn9XDjpHj6St37S4ijV2tuxX+J4gQStpjLcf9AS Muy5xEP4w9aDtA1wwnTAG3Uaxix85sbARO5pyrAoOYMUWdcWESTaQxPQ4hecFd7sWBj1 00mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781040813; x=1781645613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bZBJjCrkZ3RzSyjUlLWrVA7bCuKkhZfMdp7PMkk/Ds0=; b=NmMtARPsmmt0xnM8bqdJTiratgKxCPDUznXvhHPTYsA8Kvvi96PDlWF7H7MBIYO0jT m4JcZ3nXAy1ivcGwR9l5WJxpLEyNav08x3k/ywQZCBPd5+7hX+PgAeFptEQL2khvC8bp s9iL4XpgaVKc4rXQz0sxEXX5+9abAYSf9kkm5LKu/6HLZ53z96fDqs2nwQWJJmT9yITU O/VydNmvxBAYlBZKcZJDiWd8tFrKsVVz7IqI2OSNhHiybwLt0QZNyl1jVFFMI8NtjpzZ U64+uIm2rTMlfAYk4aZ9cgxvELLbUIx96u7hBLKVOSj23xmCY69zgNe3U9Y7SSYKq1si F7xQ== X-Forwarded-Encrypted: i=1; AFNElJ/oHQs2gTBr5DgBL7NzxkKmfnlAjazhz3FYo7XmH72Je2BLeMlfM/5EkKRfe5Pw29E90gip+aduSvTi1c0=@vger.kernel.org X-Gm-Message-State: AOJu0YwILckfnovvGoKvSPet8oIHiLmRNfF4qr4ppE2k2Teqb4NDumoo YcSZOMiYBbpXbD6FrHtuvOxkRbySns2Jc+ZoEFAnEG/LimpvCaLl0sdh X-Gm-Gg: Acq92OHNkIH1qKs2tvCCKrB6kU52yO+aNSEFG7RYI1svuXTJjgi5Gzf63JzJ8O1BeAv nv8MW2QM9cE9gSrmRPdGf3+1aWGfm1PAzbuPfEwtsxboa36w7dAk+ei/DmHVGTC1Kyd7HheM/T7 cd3Lq3V8lHNuN7pOcLm8JJqnChOszlRbWfnkucQVZIC2qnKJttp48BB8zvkE8kaYJn1WFaCxqwA Yz3RLTWpTHV69aVgU97h/Fvx2kxKhLv8oLBYN8ctOgm/+WEZo1nIlWnskJiFPAmD9bOS4iTxBWN gFJvTXsrYP8bRqPxyJrcUSc9n8GiZfD4CtrHMCvaWACZ0nOwPxQZFZn/1fHKOx6CnKIZb8K81Wk DOX5DaT+2pHStLQ2cF4DD7h+Xqxd8c83eFahdF3suiiS4GNVoYfq8z0r3sUwVvz4347OzU27ztp M2wo6O+SM35I6kZMGE/sZpsC9DuwUuwQ== X-Received: by 2002:a05:600c:45c4:b0:490:4ee0:82ff with SMTP id 5b1f17b1804b1-490c25fcfafmr379176425e9.27.1781040813317; Tue, 09 Jun 2026 14:33:33 -0700 (PDT) Received: from hp ([147.12.255.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc391aaasm591128825e9.1.2026.06.09.14.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 14:33:32 -0700 (PDT) Sender: Nikolay Metchev From: Nikolay Metchev To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Alex Hung Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Nikolay Metchev Subject: [PATCH v2] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table Date: Tue, 9 Jun 2026 22:33:09 +0100 Message-ID: <20260609213309.445019-1-nikolaymetchev@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <6f0e5451-0ce5-d4c2-8ade-3489701c9df6@linux.intel.com> References: <6f0e5451-0ce5-d4c2-8ade-3489701c9df6@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The volume rocker buttons on the HP ProBook x360 440 G1 convertible emit events 0xc4-0xc7 via the intel-hid ACPI device (INT33D5). These codes are only present in intel_array_keymap, which is used when the "5 button array" input device exists. On this machine button_array_present() returns false because the firmware does not advertise the array through the HEBC method, so notify_handler() routes the events to a NULL priv->array and they are dropped as "unknown event 0xc4". As a result the side volume keys do nothing. Add the machine to button_array_table so the array device is created and the volume rocker emits KEY_VOLUMEUP / KEY_VOLUMEDOWN. This is equivalent to booting with the enable_5_button_array=1 module parameter, which was used to confirm the fix on the affected hardware. Signed-off-by: Nikolay Metchev --- Changes since v1: - Resend the patch inline instead of as an attachment, as requested. - No code changes. drivers/platform/x86/intel/hid.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index 085093506..73874d436 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -156,6 +156,13 @@ static const struct dmi_system_id button_array_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"), }, }, + { + .ident = "HP ProBook x360 440 G1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook x360 440 G1"), + }, + }, { } }; -- 2.54.0