From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE5D480DEC for ; Tue, 9 Jun 2026 22:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043598; cv=none; b=bykpRPy7oobf7uO6JkJC2Rl2ZqfID+NdewOn/g22k38d3TBtrceFifRiIyI3W+AZ70tPTnk7NtVggBlj3Wb/n4wXOi5nanUO25I09oTGjOAwcW8VXlq7TiMLX0neHGZwOHMX7rbmfU+jloqMl+6MWF6KzeEIaEMqxolK4XIR2Ic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043598; c=relaxed/simple; bh=lyTXMgabiZFV1r5MchNd6Qy8eKJqo3LxCHLLSTQ8EzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xa5N9TNLX/lTdez3B6BJ9AVGcHaCIDjZbjUuXP/YeWpW9IsFcE9HTpUOIL9MLqhjrLIMUvsktu6WC6ftQvAuLHMhVptK+nqrIrnMmN58HvOt2REAr5kBDhOlWDF4pobkLPGGqE678TWOgDAPlu7IzeocYvdFuwWkdvkBCbj//cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RKdQ/v1u; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RKdQ/v1u" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c8587427468so2450255a12.1 for ; Tue, 09 Jun 2026 15:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781043596; x=1781648396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=RKdQ/v1uAFcxV/ocjx5v6hRmdWG+zS35WfgBSYeRthUQa93HZ0ES+XI4rB8m2KaqkF g5jDDUogZrFBdnv80jOgkkU+qQYH/WSewqkNeIUynlU/QdG731kv0Tc/+Go/xK34T9Gh NsQOA09KqGg5pYGcJCwZo3K2TjHj7z0/MVIg1OtbHBIxZhXXowxJ0VdX/JG2AGGKFgTt IXRUYb0a0HHXO/KBHQ8wztWifJEAqTGCby1RDVCr4t66/qKYWJmVNd4qBJ1XoY4oaJAP peD+TBSnwRgW7nYtzIhWEHUmjz2ab8SRbIOgsu6iB/7zMU4fih5F08KDiI8geU5okjKE UCAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781043596; x=1781648396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=GvYAmdDB6q2tmfBfzOp8r1LzNFRi5IYaZECN8JOWf3fEbFp9kG9VzAtQ6WEwRaROXh XNrW3ldEgXuf381qYUz5nW/63PKg4tnLkxajcmA/BVjk0yedbfA8wn2uGzYJ/s7GsLNc Z9wEn5o6ZFEZRgIStezQ6ufeDzKp1GaJrcqBqNFFBqSTHYcuCPlIFvuWt0LGENmaJLUv f1Jc4QuX3z/BW3afzKvc8THUAe+P6xVum+Lnj/d1RiUJmCCx3s8Jkr+d3MDltovOjxbp aT9eWFMTtULcFOmhpDsXjoYNHHqSx164Jofg/TTb/FzFvPnhLddbXSR3mBNOGKa3kdrb Q+dw== X-Forwarded-Encrypted: i=1; AFNElJ/xslYS7GAfcbXE5pMXyFB+Q2xF0xm7HtvHFBrrjdAEa18QOplu2Hp8+GxNw4IEn0Obg9S/5C0bKwURbzk=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ0rZY62Bn4GmMiqfixvMnGry+WjlJNfeNBItAKPTBuz9EYD28 kIoGLcSghM8zJD3SRB5WhcFAfq2IenJC5wXsX3IEr/uTZKlDeYBvdWIH X-Gm-Gg: Acq92OHA3Mz9GhWFSqbt5Typqa02hYO+xYGmJaLVIKCJ/qZQ0EzmrUfMBvw84D0kBT0 xi1Ttx5AZsDbM0zFh65L9u1oUwAIRhJ/GsriHtXWE1cFjloyY5CFDN+XzLuTDyeJ4cSHoG82zfK zZin7kjv0uW2rFoBtEYb0dgX2Dr9A31lRfYxjUwrxiQbYDCSFpTcUDht4IZ5jtMJpM2KOsSAKJl D5cZOuB7oQsxIXgfTJt6pxn2q7DHeUgmcbUdzzvyvm9vHdhQDTOf9BZSzHbfH6PjJewwIG5jcvg 8MJH4hit8SAgih1cK9HJwd+Xs2Aw+9+zUnnb0s8XkbQbD9s0wuxMzzuUfytWrWUNJ7cMCdfLsnB anhDHneATVTp78sB78HqFr9cok9AIa2+VXJdzuNFFO6ecAy5iepAAiKe38EHFXS836CvlwcMFOT v1XMEhE1Tmkyw469gEIciumHuFwiLjKGt+pYG22duGbaCkrgZN+oCXnXcw+ii5nYIF1Tynnnr9i Cd0hazegbiT1RCg/RCH+uYoH4gvnVUzLcj5KZIXSnZTcQ== X-Received: by 2002:a05:6a21:7a82:b0:3b4:85db:1bea with SMTP id adf61e73a8af0-3b4ccd1b486mr26738313637.5.1781043596210; Tue, 09 Jun 2026 15:19:56 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04ff24sm19661834a12.14.2026.06.09.15.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 15:19:55 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv3 05/15] dmaengine: fsldma: check dma_async_device_register() return value Date: Tue, 9 Jun 2026 15:19:16 -0700 Message-ID: <20260609221926.35538-6-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609221926.35538-1-rosenp@gmail.com> References: <20260609221926.35538-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the return value of dma_async_device_register() in the probe path and propagate errors instead of silently returning success. Previously, a registration failure would cause a NULL pointer dereference in list_del_rcu() during remove when dma_async_device_unregister() tried to remove the device's global_node from a list it was never added to. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 43d817f6ded1..3009e1531292 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1303,7 +1303,11 @@ static int fsldma_of_probe(struct platform_device *op) goto out_free_fdev; } - dma_async_device_register(&fdev->common); + err = dma_async_device_register(&fdev->common); + if (err) { + dev_err(fdev->dev, "unable to register DMA device\n"); + goto out_free_fdev; + } return 0; out_free_fdev: -- 2.54.0