From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87A740D579 for ; Tue, 9 Jun 2026 23:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781047413; cv=none; b=RrzeUKvvPtOt3yxEjrbyzVR6MBdfy0L+u4TejeWYpKDFeBRftJzVDyba5ugyZGEYQKDrSdHPzpVMTzqkcFX/qHD98NiOC04nmnN6KVqq6GYr8ECG3sz73VDACF30ilimuhG/oGaCX+Y/DS3zvs7tsGspks/y+SakU9CEHbcmjsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781047413; c=relaxed/simple; bh=/moGaGSyE23xwp1CWmNIIXZGf49bTpQJ/4nZGzLnW64=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FMRkJQvxBd/+SG36W15h4IjYo8Vis+1FF/E5rBT3wlq/WNR9lq67px1iNLEeQx3hViv9+btTYc2IsS8UOnqqpIUr5S5LTpCQ8N97CcN66pIhcz9DCuxZkM4bQN/nv3ZkhmYquyuBFmwZ1vvXG7RdzXloT3XqB0CEu+iSpWI2kXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com; spf=pass smtp.mailfrom=trailofbits.com; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b=fVyZQyCV; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b="fVyZQyCV" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-5177b1a7441so85750611cf.3 for ; Tue, 09 Jun 2026 16:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trailofbits.com; s=google; t=1781047411; x=1781652211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AYN2/VUfjfy9nXjDQ56HkTZcEt97aRnd8nCnumbKYN0=; b=fVyZQyCVDNl4tYoQVK1/K7jwqV04c6l5gLy++3lpBswkhXDvU9n9a9jb9o4dXoGASi 8r1jql/OyAJPP317i2e7+A9BCag85t7bfoJwu73R1rMaoQNlGhXorLVvhiqMYuu9/L9Y 5EwLMXgHXg6FTeaP2qv7JxZwfhNrCWqJ4eVzylcdTPF6ifKCa1uWDd/+OP1EsiG53dWG 2+Vdm+BbfRUAQch17AUMytUP8mhMfSvlqW1oG+n8P2zKcOqYgD7PoV/eaRlBVkxUv7+2 vM/saj9gmqBaU/+YcKmq3v4BnJVB1VmCyHOYruOcXgWjuWOYV9NBFGlEhO417av8A5IE ayAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781047411; x=1781652211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AYN2/VUfjfy9nXjDQ56HkTZcEt97aRnd8nCnumbKYN0=; b=ofIUIPGAqV+Xq5Oaau6da8RJt6jDnRcrBxSnQBoKcaU4OxukO8XaXzBdwv6kLFsMhP ukv1QfdiaTunYTUVcoy/tjJ378spwaHvvZe6wXHTRZlpASwjf0wCUB8TVLTTtJL5k8Xs pwx0UGn3KECXFBuRDBin5CxZIQeIKGyVS++OHza3GX5LPdh2jUg8qX4W4SMzAIH6OBmO nlKk6UHFqvoDGKIRG49neLdmhPeLlIK59juhaDah6v1oAGao1B+zEJ/WFvxw+P8d8jy1 qLRFfA6CgSN/tA0rf05cyJuUV2Z5mR8g3KgGuqMTRl1+ObBTmdLyAUsva24tNQMYJpYt NTdA== X-Forwarded-Encrypted: i=1; AFNElJ8DZ1TBXitGVE72zyJS+DgQOII+0Xo3xQOhVX2bXkfO+jrprnfj/uuRArQH1AGe90cMzlY3FDnkcbuhNlU=@vger.kernel.org X-Gm-Message-State: AOJu0YwTtJL00jBHljlz2gm6g3oJZd9uQ+p/ONjKGWzfKE3DOUjnIOyn yDHv6GRu7KxnjqLeSFBPZefPgucoPqLT3QvbKlBGS/RkhL7APORAmsChbkmyAdgCCMDmvfehPL9 nMm1O8h8= X-Gm-Gg: Acq92OH23sSAhkU+QCVs8O4A9CB3Cf+L7k29te11uBkiyIMhS7nKW/KGEVrS+fes28t pylhaSnwnUphl3AqduCpJNtAGEXKP1d+K8y5LlHQkWiJB112sIHk0kg41gpsgUneoCGbPSUvz84 yB9InrBnNrSSpyN/DWvodGK76RyNiHt1MSVGkYlLueXYXcs/kH74BFR2y2G7JhFRSgDtuAz0xB2 HjiDttmxP3iAdWX2qXyzx9fw3j6+TmylftqMJv5YTmry3I5sD99tSvCgGwyC6XqqNMjgCEaK2po orHOF8EbjISD79vyRO6PuxAX0GMgno9jEfguJSKVN2QjY3CsAkXTfAhjnLU6p1ipqNaZ7l5S87q hsqoY2B2jJehH5lhxgragcFxHZIp5H5xqXcH8B+K1bKmiMvIMAIbfwWZRjChFIS38EiQSUrgwOu TnVz4wTo8q/Li/fxkQ0pBku40cP6XiYGkze7LmMg== X-Received: by 2002:a05:622a:4a0c:b0:50f:b494:7887 with SMTP id d75a77b69052e-51795cbf6acmr332005161cf.51.1781047410817; Tue, 09 Jun 2026 16:23:30 -0700 (PDT) Received: from localhost ([161.35.96.86]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-8cecd053032sm224336396d6.24.2026.06.09.16.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 16:23:30 -0700 (PDT) From: Samuel Moelius To: Andrew Lunn Cc: Samuel Moelius , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wojciech Drewek , Marcin Szycik , Alexander Lobakin , Simon Horman , netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net v2] net: pfcp: allocate per-cpu tstats for PFCP netdevs Date: Tue, 9 Jun 2026 23:22:45 +0000 Message-ID: <20260609232244.1602027.c569f6c530f6.pfcp-missing-tstats-link-create-oops@trailofbits.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PFCP uses dev_get_tstats64() as its ndo_get_stats64 callback, but pfcp_link_setup() does not request NETDEV_PCPU_STAT_TSTATS. The net core therefore leaves dev->tstats NULL for PFCP devices. Creating a PFCP rtnetlink device can immediately ask the new netdev for stats while building the RTM_NEWLINK notification. That reaches dev_get_tstats64() and dereferences the NULL dev->tstats pointer. Set pcpu_stat_type to NETDEV_PCPU_STAT_TSTATS during PFCP link setup so the net core allocates the storage expected by dev_get_tstats64(). Fixes: 76c8764ef36a ("pfcp: add PFCP module") Assisted-by: Codex:gpt-5.5-cyber-preview Signed-off-by: Samuel Moelius --- Changes in v2: - Added fixes tag drivers/net/pfcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pfcp.c b/drivers/net/pfcp.c index 28e6bc4a1f14..a6aa30ae0af7 100644 --- a/drivers/net/pfcp.c +++ b/drivers/net/pfcp.c @@ -148,6 +148,7 @@ static void pfcp_link_setup(struct net_device *dev) dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST; dev->priv_flags |= IFF_NO_QUEUE; + dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS; netif_keep_dst(dev); } -- 2.43.0