From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1542E33ADB3 for ; Wed, 10 Jun 2026 05:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781070774; cv=none; b=Z0TyHU1hPEVDOdpGMyVI6LN8nbCjlZgPQ3jfmQo+V1zK+kS+Y4tQhFATJEW7eWnyI/arPSinVeJjK6otjBlJpt4pTD3pPWqFQqfoMvSODkkZ/2V5eZi9dcUhqqBQ47wtCQ26kjTso8JfOlp4HrpGmsRUSvjXreVPOpxsPs7iQ9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781070774; c=relaxed/simple; bh=kPiK4VVYK2YYSSKt+UOoRg5CfNLvCgE5KlbH1vf/nME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZMys4oNfXT3UkQ+aPIBWRUIWLrvgbQgWxqFCA5+2HWIX29UpzMJaLmBfj9SQ9AZolrEDYD8uwH+xQ1uPWm117MOe9FXdTEq16WwxsdWHZcEtHDaGFvNpPD07yYIP2gsLydXW0MxJiQ9PkSwzGv5IsWPNWRMuKGeUx6Ty6P+OluY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jpDXfsIT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Eklz2DOQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jpDXfsIT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Eklz2DOQ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A2eeVI240975 for ; Wed, 10 Jun 2026 05:52:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= avk5meTGBcIz3G48y/NS8SFzaal/HS1a4+vUZxSJN6o=; b=jpDXfsIT4AT4ka9V kFpZtT7578UkocoomF56qut2haoZtqeJoPeXeKJcyhW8LXhspVLysomeYybXw0Gt zhMYWTgeWZ3B0stIFdOtQTjA1CzFZLA0XZTnL/yMSVeQHkF8HNgO13GS/PqRsHpX dIPb33a+v3SXukEuUCjJUSWs+r1cU8cns6cvkXNm1Xz0lfiSGMy3bf0yRX2tAv33 90JglukacCflDwjlcY5GFWhRc1L6EUc2PASloykGTI8+R90DNB7g6tJFyvjk48hq UnA6wJ79hxjXcdDQEEq37cPEdBHOY9YVOLbDdY+hhnynzMS1Y20RuvemP6l8mnkI xXKKBw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epukesev6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 05:52:52 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c0c20f7581so67690215ad.0 for ; Tue, 09 Jun 2026 22:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781070771; x=1781675571; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=avk5meTGBcIz3G48y/NS8SFzaal/HS1a4+vUZxSJN6o=; b=Eklz2DOQ97+Yv46xlzGxrD7X0QoW+MwQ3+kjyjobDb/gzLiaFlhUJB6sGd8ulYc6/x dfBS65N3tuaNi8QSWK0vETDNZpblfPT86xyTww/eB/QvA9Hn1x5Au0nvqOsJDyIPTP/D oQUPRaBkINfWJ8po3rHMX4XwqC1IXrD23W/EwBIGxB7rrmI1Ksrp+3PxgGsv/Wbyiwzt z8g9qJNRYCYaHjbgNaSNA+/Frv0aZw4f9BsMzjDYfrLxsHIzl7feMZECtfpt8E0Zmoop lLgGC7GPqL4Zo5ocKUe82MdyJS3M3LMhPgNxrpd0GCOhwbguSmSGvczjqw9+/PDN2wkI t+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781070771; x=1781675571; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=avk5meTGBcIz3G48y/NS8SFzaal/HS1a4+vUZxSJN6o=; b=RE0C8v1WTLTv5aGKTeSmXCogiCYYLgQsTvzlvPgYhIuj8QgnoVSUmf5UyR7Ilk9zzp LHjfe91xRxhu6VmixsTfNiENGNPecwyvEh5IVCOnTzlkkHdMCCzgQuaS3k4iGCMirBYA ZrqqiNLfUCTOITbcb6nIAH8c/dgtLhzU88Sl2G/p8t6GxX+WqypY7RcHqkHtGNDMb8K7 M1Q72i/dKVSxGBvICWOb3MuVAiflkOVKEF/uBmT/VDQWgjo9zyyBv2NobeyPX47w2mqx bvnOAu5gkwfunbYMh/VEHiTx5CwvjKnNBuMzqo6fXo/UxQumZ9Na72lbjdPwZnFGdm9i 5ITg== X-Forwarded-Encrypted: i=1; AFNElJ/XvJfQZYNArwwRSC19J4lyc/pZK5kEFssP56jUCxPqpU4v33VVvV3Vc1C7H71+W5kFMx8t7iY7jlHHOzo=@vger.kernel.org X-Gm-Message-State: AOJu0YyOiugcDmM8TxhIRtkW43IibBOM7cZOGyKn6A7bjfhJ93DEGgv/ qFJSqCVHyIQRinsUeR6jZ3QnowSPxv8BwuNsIroVl8iyfOoeBH0JhinogaeXCr3lPMKa3tP2os7 seqUzQNNi4Ri1kEBBw1XQw14waP+GGhNJ1aTl7SgcU5Al2KrXZ9RyLLhLiwEcBviKhrg= X-Gm-Gg: Acq92OFgB3lkKkA3UPFvx5DrORha8YzRvtrI4LwN9p78yLaVHAv19a9xbjqkLkqyIZv qmr6jGxtbu36eJ9zgkeP9oi4q3He+5dQzijR3TpSAomozPi0wxJZBAa0p4mpdo67gfg8VxMKdVy wLRt3lH/Zsli7/dz7rYOyPXvDiSgU9t9EkqANdGFL1fHiQZFX7pgqWAuuj3I0/7WR5jmjL+p1/x 7TtfcAYF5wACgTgKLjyjeBBOzs3V47RmovLMQD5DEuCmf+7F23l91YeRLxMm+Zem7iP3iymdNUu JvRTsQN9R9xq38swn0nyEs0Bf2tGyHTD5y1LjgpaQ0ZWqh+QYzbWf+uo2yBXxVMtQdu9ZeJmlki MPSCQt8IanzHzu5hWKlnm9s5NMxl9/+jOND2Kf36BqYdHOlEDyCruLWBaPg== X-Received: by 2002:a17:902:ffce:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c1e80ebb9amr268984255ad.24.1781070770785; Tue, 09 Jun 2026 22:52:50 -0700 (PDT) X-Received: by 2002:a17:902:ffce:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c1e80ebb9amr268983905ad.24.1781070770232; Tue, 09 Jun 2026 22:52:50 -0700 (PDT) Received: from hu-sumk-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c24edc8acasm108601105ad.45.2026.06.09.22.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 22:52:49 -0700 (PDT) From: Sumit Kumar Date: Wed, 10 Jun 2026 11:22:26 +0530 Subject: [PATCH v3 2/3] bus: mhi: ep: Add mhi_ep_queue_buf() API for raw buffer queuing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260610-loopback_mhi-v3-2-a733c0cef61a@oss.qualcomm.com> References: <20260610-loopback_mhi-v3-0-a733c0cef61a@oss.qualcomm.com> In-Reply-To: <20260610-loopback_mhi-v3-0-a733c0cef61a@oss.qualcomm.com> To: Manivannan Sadhasivam Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Kumar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781070762; l=4302; i=sumit.kumar@oss.qualcomm.com; s=20250409; h=from:subject:message-id; bh=kPiK4VVYK2YYSSKt+UOoRg5CfNLvCgE5KlbH1vf/nME=; b=q4wkcXgb9kSyURpLBh9O/mKjiY/e3Q45Mu4AC/46kfOxEMBEgeGRBEwxDgEYIfi4SctX4pwcR D7bJIgV7+RWC93s7so8eWsurMOAJUZhs1AD3sJj9oOuUYon+1d0ryER X-Developer-Key: i=sumit.kumar@oss.qualcomm.com; a=ed25519; pk=3cys6srXqLACgA68n7n7KjDeM9JiMK1w6VxzMxr0dnM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA1MiBTYWx0ZWRfX6YEzEFeOQnd+ WvvKMxKIfCIVOqCot7waPfPMJh3KUkMZw9fVLAesXUnxWhFGARqY1ns36xYbAisM15JlRRCKYGI OKweDONxkhnhHdGV9bM0x0FkmSA0/NwBNbjEOygBcJhm9slRpO0WsJmvQLrn35cew1ejmy+9GMl yGRFxHYx28wKQAZWP92JS+GDXYSWVlbxp1nOiU54LPulu7zGHt1iCAQVzGJXgZese6WJpURACPz iXuV7nY1fwAQbSYGqTJITIdB4D1jBabPbt0hkydMl71ruWFKobCPA+2RPncmnBRIu1Ka/pRUb2O S6ngzp6/yE09iUKhr/HT7NoW5AxLrY/uCVK1Jz6Nfb4x0Mo0bpnP6sMnMWEIP3GXZW4hpkKfg6r VU8SR+Vfb5GmfWSUHUPPE0yNhWDY0um6/s8BNWyzr1MY6z1aYYO5lNsdNUzZn450TfIGlDhGbU7 P7QDj62yNOi8vYiOSJw== X-Proofpoint-ORIG-GUID: 1HHTVKvlVAaTHHZGc6eM7q5HMDQhC2aP X-Proofpoint-GUID: 1HHTVKvlVAaTHHZGc6eM7q5HMDQhC2aP X-Authority-Analysis: v=2.4 cv=DNG/JSNb c=1 sm=1 tr=0 ts=6a28fbb4 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=27Ti7_ZD70JoqEhemiIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100052 Some MHI endpoint clients do not use socket buffers and need a way to queue raw buffers for DL transfers. Add mhi_ep_queue_buf() to support this use case. Refactor mhi_ep_queue_skb() to delegate to a new internal mhi_ep_queue() helper shared by both APIs, and rename mhi_ep_skb_completion() to mhi_ep_buf_completion() to reflect its broader use. Signed-off-by: Sumit Kumar --- drivers/bus/mhi/ep/main.c | 27 +++++++++++++++++++-------- include/linux/mhi_ep.h | 15 +++++++++++++++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c index b3eafcf2a2c50d95e3efd3afb27038ecf55552a5..6c4c5ca473b821f9c2abe11cfe5043ec4c5545f4 100644 --- a/drivers/bus/mhi/ep/main.c +++ b/drivers/bus/mhi/ep/main.c @@ -516,7 +516,7 @@ static int mhi_ep_process_ch_ring(struct mhi_ep_ring *ring) return 0; } -static void mhi_ep_skb_completion(struct mhi_ep_buf_info *buf_info) +static void mhi_ep_buf_completion(struct mhi_ep_buf_info *buf_info) { struct mhi_ep_device *mhi_dev = buf_info->mhi_dev; struct mhi_ep_cntrl *mhi_cntrl = mhi_dev->mhi_cntrl; @@ -544,9 +544,9 @@ static void mhi_ep_skb_completion(struct mhi_ep_buf_info *buf_info) mhi_ep_ring_inc_index(ring); } - /* TODO: Handle partially formed TDs */ -int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb) +static int mhi_ep_queue(struct mhi_ep_device *mhi_dev, void *buf, size_t len, + void *cb_buf) { struct mhi_ep_cntrl *mhi_cntrl = mhi_dev->mhi_cntrl; struct mhi_ep_chan *mhi_chan = mhi_dev->dl_chan; @@ -559,7 +559,7 @@ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb) u32 tre_len; int ret; - buf_left = skb->len; + buf_left = len; ring = &mhi_cntrl->mhi_chan[mhi_chan->chan].ring; mutex_lock(&mhi_chan->lock); @@ -582,13 +582,13 @@ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb) tre_len = MHI_TRE_DATA_GET_LEN(el); tr_len = min(buf_left, tre_len); - read_offset = skb->len - buf_left; + read_offset = len - buf_left; - buf_info.dev_addr = skb->data + read_offset; + buf_info.dev_addr = buf + read_offset; buf_info.host_addr = MHI_TRE_DATA_GET_PTR(el); buf_info.size = tr_len; - buf_info.cb = mhi_ep_skb_completion; - buf_info.cb_buf = skb; + buf_info.cb = mhi_ep_buf_completion; + buf_info.cb_buf = cb_buf; buf_info.mhi_dev = mhi_dev; /* @@ -627,8 +627,19 @@ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb) return ret; } + +int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb) +{ + return mhi_ep_queue(mhi_dev, skb->data, skb->len, skb); +} EXPORT_SYMBOL_GPL(mhi_ep_queue_skb); +int mhi_ep_queue_buf(struct mhi_ep_device *mhi_dev, void *buf, size_t len) +{ + return mhi_ep_queue(mhi_dev, buf, len, buf); +} +EXPORT_SYMBOL_GPL(mhi_ep_queue_buf); + static int mhi_ep_cache_host_cfg(struct mhi_ep_cntrl *mhi_cntrl) { size_t cmd_ctx_host_size, ch_ctx_host_size, ev_ctx_host_size; diff --git a/include/linux/mhi_ep.h b/include/linux/mhi_ep.h index 7b40fc8cbe77ab8419d167e89264b69a817b9fb1..59f796e56207aaf8be09edc9ba4d1f59b665581f 100644 --- a/include/linux/mhi_ep.h +++ b/include/linux/mhi_ep.h @@ -302,4 +302,19 @@ bool mhi_ep_queue_is_empty(struct mhi_ep_device *mhi_dev, enum dma_data_directio */ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb); +/** + * mhi_ep_queue_buf - Send buffer to host over MHI Endpoint + * @mhi_dev: Device associated with the DL channel + * @buf: Buffer to be queued. On success, ownership passes to the MHI stack; + * the caller must not free @buf until the DL transfer callback fires + * with result->buf_addr equal to @buf. On failure, the caller retains + * ownership and must free @buf. + * Note: if @len spans multiple host DL TREs, the DL transfer callback + * fires once per TRE, each time with result->buf_addr equal to @buf. + * @len: Size of the buffer + * + * Return: 0 if the buffer has been sent successfully, a negative error code otherwise. + */ +int mhi_ep_queue_buf(struct mhi_ep_device *mhi_dev, void *buf, size_t len); + #endif -- 2.34.1