From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23CA23E0C6F for ; Wed, 10 Jun 2026 12:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781093305; cv=none; b=kNO5Fd7+/qnBLNKF4KbPQbc48ytT34f/edgcqcG3C16gB0+IC8vn7c+ON6Rthcty/Uvme4d1sf3MrDK083RXSlbYNG+hc1O0xPfsS3DOE0kbN8G5TVXJKBJQ52LXcxXqdMY0Wan/w2tg6UDRG/5tuKEU8H0AvT1nohnEnCU+Y0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781093305; c=relaxed/simple; bh=gRYmgtFz61CTrLJuMU4IYn49sqh/BxMTge3k2DLT6VI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=nkDAslNPDu2EwwQavKaAvqbEkAKQyPcsDT9pHzZken5BhyKwzKWiU3uc4wHjAZs6BE6gzH22su/5x1JhCkpkbeN4TATn+LiaFGEumqcmsMuhQkWY/WySXmRZGEF2j5LLafrrb38E88O8yf1yO+D5Kxc7FYUi7+GoeI51R5r1cac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mjuG3zTN; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjuG3zTN" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c168baac83so31472185ad.2 for ; Wed, 10 Jun 2026 05:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781093302; x=1781698102; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=80QEDLORROQQ3BtM7atufx0QxPfqyLlC7mZSU27RJko=; b=mjuG3zTNUBLBgsU8IRHbC/KxEhLb9EvKhWRQ3zzw4UCyE3WsmhIvmzUKejEsTjwtLj 4slYDGA9dKxPgFfNWp4vi925PpOVptqgLRk/qFu/CLI53NtVu+dsa43yuhKdpzZOkGYg 6lRZS5V49SsiwRLe9975mKlCef/2eFHL60j+pMf+vso0oZ6C0Pq3sUCCi1yi3dRc9pw6 RTsTugwej5zGkkzBbgK1dxHolLFQ6LDOH3wCKst+ZeG6keI/0RrppQiz55m2K7HS0eRe sv6KPDhig03jCoVv6jYdhiivs0gQUCH5TaJcvTlwKdeKEQ96unI3yR+PQ1qkxO3hpeeS W6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781093302; x=1781698102; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=80QEDLORROQQ3BtM7atufx0QxPfqyLlC7mZSU27RJko=; b=YKgzZPBTOe0corbeNAn1g/u21/nylLn1AYV5NUKKyAIrOGgQSUf1ZzjHoS+WjpGMZv qnfQCTrI3o1HWCpD5NBTjO7W2tp81tWHN7KSCJmZG/A0N3mwrPwZZDv910eO/YFgif4+ p6yZ34+aaVgUxYFfYHxk+kYGZtgEl1LVpUT7fdB1TalLC4du5o02U7FUsAW5nw3Eh1Sb Km8lioCeon5ms0AKk3SYViqIHFUlHXNazPZ5FMSO3QRRteWVle/ArhwuwObp15N6Zlym jV4u76r/9hE3cCH0U5aPrmJHmViz1q/C+PrxBsCfEy3RLgpCkFWe/uJr1Vl4PGPl0xOB OvQQ== X-Forwarded-Encrypted: i=1; AFNElJ9ujbkeInRjLXKv6cir7dYz8qub5AnZbG/+N0pTB7gWpx50nd1C2IlcRKpdBomljTX13XH1Y80Nr5JjiX8=@vger.kernel.org X-Gm-Message-State: AOJu0YxKpe0uHBxA0hKHd+WArEVpT2YdvTAXv9hhTBsWCanWjmLjFqVn LI5QOXUWfDzVQ1XzN3OuQpodu+YQiFbSwjkO1PSlcR+TlHhiiVkHU6F4 X-Gm-Gg: Acq92OERmYRjLqZqvJLlJ0GaE/BLqj/AtcLupXFZniAv9ztplOMZcC1I9qhkIPl924g KYkTxFJoDrI6fDFDr4/JcaXSHwo38p1s5iWYc7Zn7y/n4WwzH6Go24t+NqoUmNLfnKLf6WzIhGI au0HAA5RTsdt2ad4V/njswi49fV8u0ooulkagHb4iGl7XqPmXbJaEZWFAmwOsnvlzmv/wRGAQmY nFQFty4DdjVXgYMvVoDfb3h/pY4zDFuFvOu1/UAI46Ekf05txKSQXdeNOfE8kAo+KYf3mqXNw8R RJo+Fah8Nucif669cRP3NoBRQRa4q4RlU/4yGc4wVf7rqf5IFOQru5tQzXB8FcWDXrJqfnDZWGt 9DtT8957CAKVtwqYMGTBW80zrPPG7xxI1U5IQck6jlR/+Xn7il9oCkFqmGvmrQdO57du2rVY2+k BPId29ScYRN0mFsNcipwk2h/laQzt8999YPSJo1z6nymA6FKt71YrfIDHK84148NMuNoqqVsXnP 4kGYZyWhtlyCHFhgF0TwTiKbn+1 X-Received: by 2002:a17:903:291:b0:2c0:bcff:e191 with SMTP id d9443c01a7336-2c1e8332c1amr297123285ad.36.1781093302066; Wed, 10 Jun 2026 05:08:22 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f8679esm236919415ad.21.2026.06.10.05.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 05:08:21 -0700 (PDT) From: Felix Gu Date: Wed, 10 Jun 2026 20:08:17 +0800 Subject: [PATCH v2] spi: rzv2h-rspi: Fix SPDR read access width for 16-bit RX Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260610-rzv2h-rspi-v2-1-40c80b4a2c90@gmail.com> X-B4-Tracking: v=1; b=H4sIALBTKWoC/22NQQ6CMBBFr0JmbQ0dpaIr72FYQDvAGKGkxUYl3 N0Wty5f8v77C3hyTB4u2QKOAnu2YwTcZaD7euxIsIkMmKPKVV4I9wnYC+cnFgddGiNV2TYnhDi YHLX82mK36sf+2dxJz6mQjJ79bN17ewsyeX/DQQoptDQFmUIhHs/Xbqj5sdd2gGpd1y+FR3q5t gAAAA== X-Change-ID: 20260605-rzv2h-rspi-3c8dd168fb72 To: Fabrizio Castro , Mark Brown , Geert Uytterhoeven Cc: linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781093299; l=1688; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=gRYmgtFz61CTrLJuMU4IYn49sqh/BxMTge3k2DLT6VI=; b=Z+SHh11T+eA5g1RF+ZYwJotSyzA1VacKym9Yev1/NlWp0pPW5TEmvnNIb3baEQ7riX6bDcxvJ Drcb+TNYyiJAB5polxXgzeDhTZuIsPh+/B9R+yBMqobOTRs1uvBPCAW X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The RZ/V2H hardware manual (section 7.5.2.2.1) specifies that read access size for the SPI Data Register (SPDR) are fixed at 32 bits. The RZV2H_RSPI_RX macro for the 16-bit data path used readw(), violating this requirement. Switch to readl() for the 16-bit RX path to conform to the hardware specification. Fixes: 8b61c8919dff ("spi: Add driver for the RZ/V2H(P) RSPI IP") Suggested-by: Geert Uytterhoeven Signed-off-by: Felix Gu --- Changes in v2: - Fix comments from Geert. - Link to v1: https://patch.msgid.link/20260605-rzv2h-rspi-v1-1-c1d5ed562249@gmail.com To: Fabrizio Castro To: Mark Brown Cc: linux-spi@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/spi/spi-rzv2h-rspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-rzv2h-rspi.c b/drivers/spi/spi-rzv2h-rspi.c index 1655efda7d20..6ed3fad873b8 100644 --- a/drivers/spi/spi-rzv2h-rspi.c +++ b/drivers/spi/spi-rzv2h-rspi.c @@ -135,8 +135,9 @@ static inline void rzv2h_rspi_rx_##type(struct rzv2h_rspi_priv *rspi, \ RZV2H_RSPI_TX(writel, u32) RZV2H_RSPI_TX(writew, u16) RZV2H_RSPI_TX(writeb, u8) +/* The read access size for RSPI_SPDR is fixed at 32 bits */ RZV2H_RSPI_RX(readl, u32) -RZV2H_RSPI_RX(readw, u16) +RZV2H_RSPI_RX(readl, u16) RZV2H_RSPI_RX(readl, u8) static void rzv2h_rspi_reg_rmw(const struct rzv2h_rspi_priv *rspi, --- base-commit: a225caacc36546a09586e3ece36c0313146e7da9 change-id: 20260605-rzv2h-rspi-3c8dd168fb72 Best regards, -- Felix Gu