From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4811A2F5A13 for ; Wed, 10 Jun 2026 05:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781069173; cv=none; b=qxC9hTyi9jVudfcHPS+sOCM9nLINJXMWpsGt6ydEXxCyUBafjeL+RuN7SXHswkFxoN33nDl2zTUdWHWV32uziI8x/KyUzpXA9GefHgzi2kM12kETr1kBlQqhbGA0hG1rIwVaCHpPwa+hUn19N4u64zZBpnI0s47WxZTgZ2M3iB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781069173; c=relaxed/simple; bh=bAo/9pVuQEla4AfFVK48Ke2WXFes/c6ZDC9cEbQIvxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RdKQRa/YKv4dU6Ta0i0V8irI/YxwWqqNr2WwJhjaDSnrLHSq0CDK7MqLmOyqVftakUG/5OjvNqF2+WEHc8Xsf9/qtxAdm3SVCs1oVN+L5D//sqeQve5Bv54d30R54yrfAYqW9GZx7Z2HatXu2mYqUSIx4AbbKIS/Q8sL/+L5Tbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SPFWs4UE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LQ4tWdXD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SPFWs4UE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LQ4tWdXD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781069171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ua3AD41us2FBEHQ4+Zr+c+pHwYn7Q8L/aLenfNA759Q=; b=SPFWs4UExGZisjy4GJ8vJR7dN2F6VRhKuKJpqEiRPayHio2KgG50dG8ViDKFGUuMDl8lxM xWUg+pRehOFjZwmWZzEUeH0Q+J5QEI2oV3fXKKWJqShf2hf9EVEivVBoAbR1Sl336BynSD Nuh0X4e2hHVvVjEJ/N9n+qVCItF0uZo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-gLJDHjh5N2qe2u5jCMomPQ-1; Wed, 10 Jun 2026 01:26:09 -0400 X-MC-Unique: gLJDHjh5N2qe2u5jCMomPQ-1 X-Mimecast-MFC-AGG-ID: gLJDHjh5N2qe2u5jCMomPQ_1781069168 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490b2f22ea2so64901755e9.1 for ; Tue, 09 Jun 2026 22:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781069168; x=1781673968; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ua3AD41us2FBEHQ4+Zr+c+pHwYn7Q8L/aLenfNA759Q=; b=LQ4tWdXDk647DVgVbF/dJ1adyLveWySlEA6hJ6z93OiNP3iLBt5A7g0OON/gB6v7ZK XVM1QcH/oDK9yZziZH5zQVnz0ddwNUO2AyWz50mq78E/a1w9ZhftKU3yjar0OW8eDHK+ VhYawEcoFV757tyX1Gs9O3h7+ZJ538txEJDxuMAll+g2pDhszvKE6d7Q5TW7lNNkiKur ojPnOhZQ1ycLvflxyx7bVE56AMhkHE9n7GiJXIEnYCVikYibc7QWCROwMGfGhghiFCUA ANj2rvHXfRVjgJicp0G1F7kd8cVytMIH3Ixz+yShlkNeepN9nYvtTVfI+aQWFoGfe047 VUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781069168; x=1781673968; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ua3AD41us2FBEHQ4+Zr+c+pHwYn7Q8L/aLenfNA759Q=; b=UHUQI1kjPGATMcdfOZ6ZlDY4xTmILsXArcma+KlLM+aI/KphealNV0nesd7Kz2HS12 2mzufpT835VOWKaEXCinsNBHxbipArjqUZ34r+KbiSLaTQiyhL+yLaySypVepI17WT86 TFvHA3C5f0F3Gms4EaWS4mX0Ee2gfW1K4Fcd1BU7L+G0MpkivFQu3veHNSI0B0vq/iST Gq3bpfFP45dLsOfGePP5/AGksel/6aFm/Gom/cXdBshdz962lhDSHB6DBvLcrCLcAII3 PK0w6TsH69NdderVUt7rQNaDTCVjMXndnZ3i5RuWKVmCPts4xv++be7zEpuso0dVznYW fNIQ== X-Forwarded-Encrypted: i=1; AFNElJ+XKiaAiB3MbdhAeDPZ4/fiDTQtyQTidSOHYuaCKNO0bn2FHVpmRCPh5TDvq/lqvEMkJQi3zZdO811inHY=@vger.kernel.org X-Gm-Message-State: AOJu0YwiZjw4rAAFhNszJBc8g3/J1HFDylaq+PrHKSUG8CMMzB+lYtcN f0rbs7HdxGnq+cIF0mZPj52EOkJSE132qSEYFdE+stRVQcBeFKZKL7eTNMNXEzHcARWZ472Co21 +zXK7IdUUEQecdEt6C2XqXB3Ka26CJNXU8Wknkur4vxiRNNIMWkBvZ7eCRU59IAD+89WJdrhH0w == X-Gm-Gg: Acq92OEE4MWFTFXS7R544kEOZisEaexUlMEz8MCQSP5i9O2T2JEkmGMGszaynLTB1mm CmMNiIyixokg1DNRnl/vBvrr8B75dsdgkknPXfUWVbXBp+cU3im3Rchu586A3X1uS+6xDOcfieN 6XlWRiV7+vj64j0R118CvwH7bQa8mgw5fDiVjFrIOOcF9Jens5cZq8k+zcY34EiZGA2RfPdOYra xmWcjvNQHa7a4PYGrSTtXqC1F3KaTKprBlTWBeJ2gubGItwWfWEqxM5KRnCFJZbWUU+QTNvWc8r LrDUd6z0LotR8WKJ+UX7q2+5Jst92cBNtLszvn+EKHkTXRkQRFGn0mq+nxtsyoM43BX0IP1WFAK 8Q5co6fjQKVZtbxPm/PO+XLcXClcNmhewg711fUrabGSr03h3p6ZxxQ== X-Received: by 2002:a05:600c:6792:b0:48a:f18:ece4 with SMTP id 5b1f17b1804b1-490c25ee920mr385315445e9.24.1781069167681; Tue, 09 Jun 2026 22:26:07 -0700 (PDT) X-Received: by 2002:a05:600c:6792:b0:48a:f18:ece4 with SMTP id 5b1f17b1804b1-490c25ee920mr385315085e9.24.1781069167116; Tue, 09 Jun 2026 22:26:07 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4602cda3651sm56939057f8f.32.2026.06.09.22.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 22:26:06 -0700 (PDT) Date: Wed, 10 Jun 2026 01:26:03 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Cc: Jason Wang , Xie Yongji , Arnd Bergmann , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Marco Crivellari , Anders Roxell , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v3] vduse: fix compat handling for VDUSE_IOTLB_GET_FD/VDUSE_VQ_GET_INFO Message-ID: <20260610012421-mutt-send-email-mst@kernel.org> References: <20260213154051.4172275-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260213154051.4172275-1-arnd@kernel.org> On Fri, Feb 13, 2026 at 04:40:46PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > These two ioctls are incompatible on 32-bit x86 userspace, because > the data structures are shorter than they are on 64-bit. > > Add a proper .compat_ioctl handler for x86 that reads the structures > with the smaller padding before calling the internal handlers. On > all other architectures, CONFIG_COMPAT_FOR_U64_ALIGNMENT is disabled > and no special handling is required. > > Fixes: ad146355bfad ("vduse: Support querying information of IOVA regions") > Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") > Acked-by: Eugenio Pérez > Signed-off-by: Arnd Bergmann > --- > v3 changes: > - check CONFIG_COMPAT_FOR_U64_ALIGNMENT in preprocessor > v2 changes: > - split compat handler into separate function > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 123 ++++++++++++++++++++++++++++- > 1 file changed, 122 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index 405d59610f76..e0f5a7397221 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -1618,6 +1618,127 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd, > return ret; > } > > +#ifdef CONFIG_COMPAT_FOR_U64_ALIGNMENT > +/* > + * i386 has different alignment constraints than x86_64, > + * so there are only 3 bytes of padding instead of 7. > + */ > +struct compat_vduse_iotlb_entry { > + compat_u64 offset; > + compat_u64 start; > + compat_u64 last; > + __u8 perm; > + __u8 padding[3]; > +}; > +#define COMPAT_VDUSE_IOTLB_GET_FD _IOWR(VDUSE_BASE, 0x10, struct compat_vduse_iotlb_entry) > + > +struct compat_vduse_vq_info { > + __u32 index; > + __u32 num; > + compat_u64 desc_addr; > + compat_u64 driver_addr; > + compat_u64 device_addr; > + union { > + struct vduse_vq_state_split split; > + struct vduse_vq_state_packed packed; > + }; > + __u8 ready; > + __u8 padding[3]; > +} __uapi_arch_align; what is this __uapi_arch_align supposed to be doing? It compiles by luck because gcc thinks it's a global variable. > +#define COMPAT_VDUSE_VQ_GET_INFO _IOWR(VDUSE_BASE, 0x15, struct compat_vduse_vq_info) > + > +static long vduse_dev_compat_ioctl(struct file *file, unsigned int cmd, > + unsigned long arg) > +{ > + struct vduse_dev *dev = file->private_data; > + void __user *argp = (void __user *)arg; > + int ret; > + > + if (unlikely(dev->broken)) > + return -EPERM; > + > + switch (cmd) { > + case COMPAT_VDUSE_IOTLB_GET_FD: { > + struct vduse_iotlb_entry_v2 entry = {0}; > + struct file *f = NULL; > + > + ret = -EFAULT; > + if (copy_from_user(&entry, argp, _IOC_SIZE(cmd))) > + break; > + > + ret = vduse_dev_iotlb_entry(dev, &entry, &f, NULL); > + if (ret) > + break; > + > + ret = -EINVAL; > + if (!f) > + break; > + > + ret = copy_to_user(argp, &entry, _IOC_SIZE(cmd)); > + if (ret) { > + ret = -EFAULT; > + fput(f); > + break; > + } > + ret = receive_fd(f, NULL, perm_to_file_flags(entry.perm)); > + fput(f); > + break; > + } > + case COMPAT_VDUSE_VQ_GET_INFO: { > + struct vduse_vq_info vq_info = {}; > + struct vduse_virtqueue *vq; > + u32 index; > + > + ret = -EFAULT; > + if (copy_from_user(&vq_info, argp, > + sizeof(struct compat_vduse_vq_info))) > + break; > + > + ret = -EINVAL; > + if (vq_info.index >= dev->vq_num) > + break; > + > + index = array_index_nospec(vq_info.index, dev->vq_num); > + vq = dev->vqs[index]; > + vq_info.desc_addr = vq->desc_addr; > + vq_info.driver_addr = vq->driver_addr; > + vq_info.device_addr = vq->device_addr; > + vq_info.num = vq->num; > + > + if (dev->driver_features & BIT_ULL(VIRTIO_F_RING_PACKED)) { > + vq_info.packed.last_avail_counter = > + vq->state.packed.last_avail_counter; > + vq_info.packed.last_avail_idx = > + vq->state.packed.last_avail_idx; > + vq_info.packed.last_used_counter = > + vq->state.packed.last_used_counter; > + vq_info.packed.last_used_idx = > + vq->state.packed.last_used_idx; > + } else > + vq_info.split.avail_index = > + vq->state.split.avail_index; > + > + vq_info.ready = vq->ready; > + > + ret = -EFAULT; > + if (copy_to_user(argp, &vq_info, > + sizeof(struct compat_vduse_vq_info))) > + break; > + > + ret = 0; > + break; > + } > + default: > + ret = -ENOIOCTLCMD; > + break; > + } > + > + return vduse_dev_ioctl(file, cmd, (unsigned long)compat_ptr(arg)); > +} > +#else > +#define vduse_dev_compat_ioctl compat_ptr_ioctl > +#endif > + > static int vduse_dev_release(struct inode *inode, struct file *file) > { > struct vduse_dev *dev = file->private_data; > @@ -1678,7 +1799,7 @@ static const struct file_operations vduse_dev_fops = { > .write_iter = vduse_dev_write_iter, > .poll = vduse_dev_poll, > .unlocked_ioctl = vduse_dev_ioctl, > - .compat_ioctl = compat_ptr_ioctl, > + .compat_ioctl = vduse_dev_compat_ioctl, > .llseek = noop_llseek, > }; > > -- > 2.39.5