From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F83632ED4E for ; Wed, 10 Jun 2026 03:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781063811; cv=none; b=Myf7nfEYiSc4D0HhIc36AmN0/7M0DijVWtznXgc8WTVap7+6uVV1Oawk5cxlujZnEJqEVB1zzNPExhSWdXxudspCCGVw8lNB6aBg8WQmckYVCbw28OgtZMI1jYscxQeEP4v/tuTZ4rEfKva5eJu0qrNl5NIZyOObf/gBpOOYCSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781063811; c=relaxed/simple; bh=JBQ9vjydbWm4e0LA6BzrFWn4WQGdz2TISxuMT8shB1U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=STcIsMbLVczPo5CMtxMUtLw/ooz4OSOZP/YJjF0+MoT3OvwNZwu0LdIyvSAsfqTrTiLUyUQeSynE8gXQOrLPmTFfjINAt/iwiaRUhI+UKk8wUEPjlPyvHLBWmyZVLolBYjan1v0nKY/Ha3113115s0FYNQeGnkJjNVnC0LRPks4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T9KTJvpz; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T9KTJvpz" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7e2cb01a974so65330577b3.1 for ; Tue, 09 Jun 2026 20:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781063809; x=1781668609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=F+UOXDCtIzjeVx21Jhp3VgFkyakTv2qNWJLXKDOQ1Gs=; b=T9KTJvpzxCRg0mK2rbjnIkIPr4Qw1BUg7sX3Xc0KXorWkpr7Nd03SO5Dl3mJNr/8Cr vDHrB5JWCZExHKYncxElhU9v+8eLGwCc3n9rzBsXa2qdpiNhRDsX0XOXCAOaJ8jNeByv ZxY+GfCIyyRRcGQQO0b967b4zcDtmrFdS8vzrgIYNI6Y+49YqnW65jw6BJWKqISbsuPi 4VQjFF4pspk2Ff2FGzXTYrCCBMJ093DaHHI1+17igDq7AFqvergUN+wqQ0RfzbOHF7Zf rGwBlsjHq25d4svZ2sZhpiVaDy3xmnmtUg538jpVdlbXJrsURTbzEIZuLiSul1F4gFm/ 73nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781063809; x=1781668609; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F+UOXDCtIzjeVx21Jhp3VgFkyakTv2qNWJLXKDOQ1Gs=; b=Ed3LQ4tlAK6JCBpfAbRNCRAlZZmrFUOxDzaxd9tiYvvhJ17Nsi5/UYPTR20g5t6IVR Q3fj2/ppBXFLQ0ECGaLvPhbULiW5hONUNN2PeMaGEqPTN559586d+lA3039lQI1E5mNO nKTLXnJgkQox6MtLTYWBokmDRbyRrsTYlZnO+0feHRFrKU7aQ07XH3DdZj7p2vv55ZM6 h3S0pu+NmOzFkbhDTVClcooich5/jpSe0eubk9QPjRV1vCmoie+CofHkRkzujVr7yIV5 iejE/zLJlGxJ6no4qLfIcAJNJWeewn8oYMNzfYRa6CKsZzsQFO/9kRncX1XGbA2r4jCk +ygw== X-Forwarded-Encrypted: i=1; AFNElJ+gl2YWO1ZkmZyoaFYb9W2vU7QmlrhFyfT227+3q9grXFUkMrEbVG+0p6qXm/O3ATjU3UP1Bw1euYAjvDE=@vger.kernel.org X-Gm-Message-State: AOJu0YyQzQxKu3v7lvFtHYWqtWYUNOIQ0/9jFZIL69MAjnqbkESC8VHG TTbltEFJl71LHiMANlANYUZ4NHxrFKB5gdyJcvv2D+umexrkwPgLDsZRR8EMy0ok X-Gm-Gg: Acq92OH4N5o+4XJVY0tbFlA1oHLvV13avIQ5dGsAgP55AD02bLy/0DwYBhO8bleMBQQ uiAu0umcHpjueCtNER1CfGoItfcWtoNglX91Tmkd7XClPCtXbjCgdx6UPZsaANaRurX+I6N8W11 9RKDNuCmfFlILpl77KGgjZEVKI+qBoIDSUa++nbjsOEmES+FeogvH8f+6deSU/FF4lBaMbgKmuE h5c1UjEhMuBvSvsU9Ebw8AkjXJdNFNpoUsLbnulFxMVSK5zMMDuIFkkzLksYX7r/k3tGAAe0EWg B7+T4a3no+bgrn4LJb5SxMApqZ58xnZ7MOjH9XyO3a2lnSSURIeGfBEYMnNq6YfD2XzXtAtfs37 Ac+6TxaevzJt5ifY5EMElMTWf18gI6Y4M9H6Khi/KG4F4JIHpNklagpZV8ciUgntDbn2uZ1w9EP j7DBjgmpNHEsIYk+dLgw6l/v6oJFOAkw6+cH/aj4ikCZ8= X-Received: by 2002:a05:690c:3513:b0:7ba:eefe:9fa1 with SMTP id 00721157ae682-7ed0b874376mr211187867b3.6.1781063809330; Tue, 09 Jun 2026 20:56:49 -0700 (PDT) Received: from tofu.. ([128.210.0.165]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea20ea8d0dsm105825967b3.6.2026.06.09.20.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 20:56:48 -0700 (PDT) From: Georgios Androutsopoulos To: Greg Kroah-Hartman , Carlos Llamas , Alice Ryhl Cc: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Paul Moore , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Georgios Androutsopoulos Subject: [PATCH] rust_binder: add ownership assertion to Node::add_death Date: Tue, 9 Jun 2026 23:55:44 -0400 Message-ID: <20260610035544.3333022-1-georgeandrout13@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The `// SAFETY:` comment in NodeDeath::set_cleared assumes that a NodeDeath is never inserted into the death list of any Node other than its owner. However, this invariant is not enforced by the safe function Node::add_death, which inserts NodeDeath into the death list without checking that death.node == self, leaving a risk for future code that may miss this implicit invariant and cause undefined behavior. Add an assertion to make this precondition explicit and catch potential violations early. Link: https://github.com/Rust-for-Linux/linux/issues/1237 Signed-off-by: Georgios Androutsopoulos --- drivers/android/binder/node.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/android/binder/node.rs b/drivers/android/binder/node.rs index 69f757ff7461..20eaaefbd4cc 100644 --- a/drivers/android/binder/node.rs +++ b/drivers/android/binder/node.rs @@ -333,6 +333,10 @@ pub(crate) fn add_death( death: ListArc, 1>, guard: &mut Guard<'_, ProcessInner, SpinLockBackend>, ) { + assert!( + core::ptr::eq(self, &**death.node), + "attempt to add NodeDeath to the wrong death list" + ); self.inner.access_mut(guard).death_list.push_back(death); } base-commit: 287afdc7671a03081f48f3407bc59862c202bd4b -- 2.47.3