From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2082E370D56 for ; Wed, 10 Jun 2026 04:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781066337; cv=none; b=V1EFLPygMvgYR1CztkeQNT8Z2G+p0s5aSw/+Ph5lCvbNJzBfzAPrhXkljT+SkwYJsKf2Fy7RP3saCn95CfWc0g/OhxadfdNv1XRF9HvBu8QtPZQNYXeDmeOlOuKlPfRPEGgC7ZJMCesl/tDptPSUBqiskpCfBsSSCEvQxh5OCdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781066337; c=relaxed/simple; bh=0xzkMbZb8DmdjsLxVwu910Gns04flVx/nSnZbEzm/z0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fmm+2dQHJ9sAQRjtffBanu8APnS3B5J+mpR8ZlnzobVRE0xWhVYqMinobZ1Irt5klIqr4mM1AQMll08hwPqF5riRA2KVztNBUTJgx3xRpOK873NM3Dd/MCMUT15mk18f+YgWls/mbsj0h2rZAmiZpePaetoiGJPK0kumiLsqvTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N3yQYQHY; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N3yQYQHY" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-307d0405e07so2219021eec.1 for ; Tue, 09 Jun 2026 21:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781066335; x=1781671135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BuhTtUyVMPvx6z9MESU78WsNrQ7meZFqbXjW2dOVHdI=; b=N3yQYQHYSyPBbBSejVYKeW5xjJiv7rLIvQRW1v07Zhbet+tpRxuHN5bN2LmC1TSywY UkxfjsnhJy2+gWz9m8MqofraqkVXnEd/JG/xP4sAXYqQYP8mTeejqPbQ8z0ric39KNHH Py6Kg9EiMgVDOnWonmo3AD/J7L3pZRAC+lv1TxuoFf9BFV6WqczMww6BmuSsqcF41lzt 3celA1hCClZB5eFP4pIL0QHVWKSR8ZiTUgChUSSuqe3Xadq/1hWJk17Sx3B7kkzQ4hYd 7dVa5vsL4F0MHq27bdDtSPM/RKloT9sdS8GAC6CJzzMgUY2LLdXs+WNiJwpSO5puxab2 DGNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781066335; x=1781671135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BuhTtUyVMPvx6z9MESU78WsNrQ7meZFqbXjW2dOVHdI=; b=KU2gXBbwxNV5EgLYrSA9FE5jgSVXm0k7Ea34OYaq8Ki7hgtnaI8BV+qfn3h6Ya88+f H5Le7HJHquftLBKpSoV3pfJ1uVdoqCvAGpOt5HBAmv5N++NC5sZPjBuGBvUhc51YF69K qrs8yPmg/hXStwANPlO3X0PzSWwK0zGUf6+TJJcCG6FgCup6UI5joqSoB4Se9raVYhDu P6EO90ToRbxmbeJnfucJEkWvLFtUjdYY1Kgu/7xA6TWbY38o3DavuU0xhl9Oa1iBTZ2h b9TJSYtZ7IZWjfxCkbVK/Uum1PoUTjJP1nu8/CKYcXrDO3h8hh3ZTWQQCB+bO15Ml+xq raWQ== X-Forwarded-Encrypted: i=1; AFNElJ/swZKla+iQadR4od+wFzJyJnks1LDSp2WzIHAyCLOfojOb4aDiokbzsTyptnh+2yksko7LdJHSmtHUC90=@vger.kernel.org X-Gm-Message-State: AOJu0YyFTOg3YiwBcia02YNosHnnt6rccT6sXt0MqHih8wSLTev65oGY iDExla2Qfmt4WolwOpaxB3daxN2NmxnAFTWD8xET/wjGn7JK8yXte2q8 X-Gm-Gg: Acq92OGwVHlV7nc1oxUqBaqOA5xMDF9+ycUIxctpPHHJil58Cjudqw+48leRMhKDcVu JFyy1ki6Q+CYs3YStd0JrPdvytiR0KPccVHOsZWkt83MbQY04Co0a8HBeXL8zv9Bmd0CLj72iXg xefJj3MAdYu7pdDWI0a4JE3lHP3HeUh8ndR3gT8iuRuQ7Naxg1e3ENUIdD+dkSWGXaDZqNp+yoi bytQ0CwLMUYPIpHhpvTRzGEXyj2oRYqJyr8tQq8LXpUpzz8EoXZRqZyMpZyHkkFFq7QRqVNwg95 J63y3aJLSff4WOENVCACFsoi1HSjWUYjEmx5epUX+ujClpuaoqcb7f7A+Ectn+S+Bun/PNcYBMV dBuOHQIqNsnQNmzCrkT435wo/ujksVz43lrRlkTcUDVjotiVRi6rs5o119bz7uot9ebZO7VkWVq ilg9jAtysT42lG0cXBBOt1tDj4i5zid5nqxq0tsKkWIEQTyMDaZzWOS3asr3VzlCGbAA== X-Received: by 2002:a05:7301:1e94:b0:2ed:b131:240e with SMTP id 5a478bee46e88-3077b283e85mr14057362eec.23.1781066335190; Tue, 09 Jun 2026 21:38:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074dea8708sm25693676eec.15.2026.06.09.21.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 21:38:54 -0700 (PDT) From: Hungyu Lin To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v5 2/2] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers Date: Wed, 10 Jun 2026 04:38:38 +0000 Message-Id: <20260610043838.90708-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260610043838.90708-1-dennylin0707@gmail.com> References: <20260610043838.90708-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace open-coded bitfield operations with FIELD_PREP() and FIELD_GET() helpers where appropriate. Also simplify bmc150_magn_set_odr() by returning directly from the matching table entry. Signed-off-by: Hungyu Lin --- drivers/iio/magnetometer/bmc150_magn.c | 33 ++++++++++++-------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c index 6f2a4a863fbe..b5ec19dc500c 100644 --- a/drivers/iio/magnetometer/bmc150_magn.c +++ b/drivers/iio/magnetometer/bmc150_magn.c @@ -9,6 +9,7 @@ * (C) Copyright 2011~2014 Bosch Sensortec GmbH All Rights Reserved */ +#include #include #include #include @@ -245,14 +246,14 @@ static int bmc150_magn_set_power_mode(struct bmc150_magn_data *data, return regmap_update_bits(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, BMC150_MAGN_MASK_OPMODE, - BMC150_MAGN_MODE_SLEEP << - BMC150_MAGN_SHIFT_OPMODE); + FIELD_PREP(BMC150_MAGN_MASK_OPMODE, + BMC150_MAGN_MODE_SLEEP)); case BMC150_MAGN_POWER_MODE_NORMAL: return regmap_update_bits(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, BMC150_MAGN_MASK_OPMODE, - BMC150_MAGN_MODE_NORMAL << - BMC150_MAGN_SHIFT_OPMODE); + FIELD_PREP(BMC150_MAGN_MASK_OPMODE, + BMC150_MAGN_MODE_NORMAL)); } return -EINVAL; @@ -290,7 +291,7 @@ static int bmc150_magn_get_odr(struct bmc150_magn_data *data, int *val) ret = regmap_read(data->regmap, BMC150_MAGN_REG_OPMODE_ODR, ®_val); if (ret < 0) return ret; - odr_val = (reg_val & BMC150_MAGN_MASK_ODR) >> BMC150_MAGN_SHIFT_ODR; + odr_val = FIELD_GET(BMC150_MAGN_MASK_ODR, reg_val); for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) if (bmc150_magn_samp_freq_table[i].reg_val == odr_val) { @@ -303,21 +304,17 @@ static int bmc150_magn_get_odr(struct bmc150_magn_data *data, int *val) static int bmc150_magn_set_odr(struct bmc150_magn_data *data, int val) { - int ret; u8 i; for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) { - if (bmc150_magn_samp_freq_table[i].freq == val) { - ret = regmap_update_bits(data->regmap, - BMC150_MAGN_REG_OPMODE_ODR, - BMC150_MAGN_MASK_ODR, - bmc150_magn_samp_freq_table[i]. - reg_val << - BMC150_MAGN_SHIFT_ODR); - if (ret < 0) - return ret; - return 0; - } + if (bmc150_magn_samp_freq_table[i].freq != val) + continue; + + return regmap_update_bits(data->regmap, + BMC150_MAGN_REG_OPMODE_ODR, + BMC150_MAGN_MASK_ODR, + FIELD_PREP(BMC150_MAGN_MASK_ODR, + bmc150_magn_samp_freq_table[i].reg_val)); } return -EINVAL; @@ -800,7 +797,7 @@ static int bmc150_magn_data_rdy_trigger_set_state(struct iio_trigger *trig, ret = regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, BMC150_MAGN_MASK_DRDY_EN, - state << BMC150_MAGN_SHIFT_DRDY_EN); + FIELD_PREP(BMC150_MAGN_MASK_DRDY_EN, state)); if (ret < 0) return ret; -- 2.34.1