From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966DF349CCF for ; Wed, 10 Jun 2026 05:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781068003; cv=none; b=f5cn32xi62UxjhiPRqIJEagOmbg8UMR/t3snJq0C1rRMeV4Xf5cMZI2eK2EMh/NGMdiU5/NXL58gwA8p9L+rEKk9PN1Me8JxGGcUb6dhEbMIv6NCcquJt3l53UEKS71nTVNuH+xtImyfhMqKjgvq+zN7Y+P6Ob1dAqKO0hb/7fI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781068003; c=relaxed/simple; bh=g6cvCqY/wzQj8/576lDmohy8giGp7pz6yFdQL1uoFnw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=APLw97HKulBXmvJyQf02XB4JVgJsrUsz/Xcd304lkaz/bxO1X5FZObqvgMT6xI7lmJTuQosj06vQ5aYZdOESvxtm3IO+/mqFe3H1VGs6QhAjpfRj2w+G9b83TQUiJbSyTCTxTIGLf3fs1iHwtVnhzuBJ73int9k8G+buA8ismYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dicAsdia; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dicAsdia" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2c0aa420401so48949085ad.3 for ; Tue, 09 Jun 2026 22:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781068002; x=1781672802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y9sfLcW2APM8y3IVh9/744JaGOXv0hWh6z9HQ9rarp8=; b=dicAsdiaoKfYAr2e3Xjb18DTg6+wGLreeTpSyQkds0X36nEL/pKyDW/lIvIMqnLyQu zyYHdoc4kd/lssffB+v5NZVZymgaXL6GN7GTHVbsTvnP80p1Rz/0ORc+8lpAXdBPpq3F 0eK8rnOsuy920F/XmxMhjW8gt3WOQCOUGHtoKCf/rh8is0aBXjYCQCkfLMKj5KBE6oy3 rSLWTtSgmMwpm/wBAklxbk+WCWcagPlxonZyJlPzp8Vutmor2jnb1upSoMsVr2zfCnyZ d04RHuGPQYhADZw91Ieg13VF5CC0H3UEvboylto0ve/Rb8dt6dbBIAKO8Yrx9HJZlhI+ OQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781068002; x=1781672802; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y9sfLcW2APM8y3IVh9/744JaGOXv0hWh6z9HQ9rarp8=; b=Cp2XYsN8xjgUJbNiL/Ztg3EMbmCXRpGtKgEkIvW0cSNwCjrF5G8q/da99TO3ak2n/q JnC3QyQzamHXawSn9zyuTCOXzh2xxAx81n3LBrEnNZ1zyHWnyIN3d6tbd3A1Q8kQO5To rDAC34itarvmmfUU79JO53JSfPmLKPRqaWTyrtdA1oph3+HXmLL4tnrW1RfIy4SpDs/M 89e3838kuxsAwlpD5V6J5ka40qu00oMnYlBXLEJVlekLi80fEW27SCpzBg4EWlyaCAy/ vWobUrobWicHWWu+yMIr2PszJMT1g+WgiP6CeXoSRuuixdjHgKcf7MADbXSip5u70ocl WXTg== X-Forwarded-Encrypted: i=1; AFNElJ+pVGvmkNS85WiGIZASt77Gm7pZGuGSOwzpG8DUQhLyH7IR83u4SEzfOKEgjxmCxp9vDWgFVHzCahmOy4Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjt6wjlyod+RSga8x8e5c7dGiOKu7QCphJKhmRDGNi7BuAOGwK GI4ubPmaFYz0/oPpZwFyKDdoBXq+BRChd5EfaMNnXQvrJc0mOdYejxff X-Gm-Gg: Acq92OFXp91J+wjzcj0KZvPa6Q/khvnzLCHnSBOAza9OtafRZDnfA182Zru7GNtoXpe Bvl/TzS+N0eABEzn9++CnkbBe02t9Bq8BxLKYivBeIA0SFbb05Yth24rsJmIHlrFEGhKmt8kWWW Ukjl9Emn3XJi1UMswfm+F31oZxhhUwhZ9sxfE8t9FNiuRHHlZg35J379sTCCgVAnnX6BGVACOvc WcIdp51z2FywdPT7A7XJfVPHaNk2UgzaQ8u6NMZ0nm2wR+q2BSv3OJN5vqUjRh+fXnSW2/y1Xsm 6yRNk3awL6zX5q7O1xpub02t0rRTEYV8GZW2HG9i5QVkUAXwm8D9HSovmlBNvb/2ZMlBgaZS7vv dF32MNUVmhQW+cTFmcHihFy26RAPp3H4Qz51m7vV3/EjnfcMEbIm9wG5FsZAAJjBSqPfbVvkADj 85Ex0RR++3cpR9ijmWOTOZuGEGz4cz3UQ0gXE/HJRuean/UajJh3FSUpkn5sJCswrHI7W/pa5Wj vzP1JtewLRLyes/RgKzvg2ibM7gDGeZmKEkguEBJe/ZRpMw1kvrzQ== X-Received: by 2002:a17:903:1a70:b0:2c2:245a:3366 with SMTP id d9443c01a7336-2c2245a35b5mr221524105ad.27.1781068001214; Tue, 09 Jun 2026 22:06:41 -0700 (PDT) Received: from localhost.localdomain (n49-176-80-106.mas22.nsw.optusnet.com.au. [49.176.80.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6e2adsm245342055ad.5.2026.06.09.22.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 22:06:40 -0700 (PDT) From: Weigang He To: Shawn Guo Cc: Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH 0/2] ARM: imx: fix device_node refcount leaks in src.c Date: Wed, 10 Jun 2026 15:06:23 +1000 Message-ID: <20260610050625.2229221-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit arch/arm/mach-imx/src.c leaks the device_node references taken by of_find_compatible_node() in two __init functions: imx_src_init() leaks the "fsl,imx51-src" node, and imx7_src_init() leaks the "fsl,imx7d-src" and "fsl,imx7d-gpc" nodes (the first one twice, because np is reused for the second lookup without a put). of_iomap() does not take ownership of the node, so these are one-shot device_node refcount leaks per boot. The two functions were introduced by different commits, so they are split into one patch each. Each drops the reference right after of_iomap() consumes the node. Found by static analysis tool CodeQL. The series is build-tested only (arm, imx_v6_v7_defconfig); I have no i.MX hardware, so runtime testing would be appreciated. Weigang He (2): ARM: imx: fix device_node refcount leak in imx_src_init() ARM: imx: fix device_node refcount leaks in imx7_src_init() arch/arm/mach-imx/src.c | 3 +++ 1 file changed, 3 insertions(+) base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 -- 2.43.0