From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE49277C9E for ; Wed, 10 Jun 2026 05:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781069609; cv=none; b=riKVV2b6XMvnOdPMdtHgjp8t/vUpm4nOlePvKvCTTIhWMtTYrmFCSYb35UeNxlmQznEIDcX37SGOaCTyrbpZZh7FbCxIUjdSBCvsMFAuRVRcSRLgV9HC+jS7AW1zoarGjNM9H+FQJrJIlScLgREc85/fqltov38AMnAq7CXI+7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781069609; c=relaxed/simple; bh=MwryTSXIM3yDVtcwj98PEdOdOWkS4zTJqxnw9spGIkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dVkiggGbOMSku6WTPPNWJAXzJ2/kqZfTjVCtWXQ0hb+hpo90JPRLtQNaYrR4ylMAScxBvPii96R2+QhAxBf6bhuFaX5DikkZyW1Ml7wyTw2bsWvwOT0nJgUeNni1vkckP+TXUa1I3b+dMpV9JAPpe/a+dYGd05SZQv7uBqQEGKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SIh969dy; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SIh969dy" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c0c2c7d45eso57062385ad.1 for ; Tue, 09 Jun 2026 22:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781069608; x=1781674408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kHMzlmbLmk4stfG9PBhCRRViSNSziVCXY5qNwjX9cn8=; b=SIh969dyEp8LwdVViWXGUdF/2BEvskxC+GSP2I7m8h23uVKIJFwHX+SqBM2FmY1ZtI Nysep8kdY5x947B1VKvj3g3A2yaH8wHUoZ3rWBDnFlVpgOVZzYoUC9L9u4JVrCIJqoJ3 eC4WRDy3NPiYvvO6NeDwqZwzm7Whah5ey+YqDmQyfrzUbwD095sqWQ50EM6yur8lLVy8 ZC4H8p0u01tCcWTcbEYtJp9DyhaOdTPA1JU/hbow16bFN+XhDH2y8at64dDm3U8vMb8z PaweR+4kL5ppdG9tJ7Pi48FzKPpbS2OPI2SMXWZEz9uprE28lusxPILIccsxx0ltzjtm tbxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781069608; x=1781674408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kHMzlmbLmk4stfG9PBhCRRViSNSziVCXY5qNwjX9cn8=; b=giFx/iEx9t+6f7+Xhqn5Q5/BUiLahlAM9Q2b/Ta4PvymXrgJjTs4CFkqHKy/Soibx7 8L4wpTjYyWscOtpVE3lgQ4/ppl6JCJslqn5LQPrmgUiggMHPXxicYLsp8EAKDEkkm1hJ 16WOKn6IFQpGJkrdr5/qOEMjfM8pJxUEzCuDRT0ltN438R7PzVWM1Qh/okmfxKol/5bT DEz1ervbFRuxmqr9NJPmXgn41ZiJJ8WwlTWeewP1f3haL+piNlUKwNQxGaveDKRXPgGW Qlrk7paXS0+N+8xucY2bzgquqhjtgdvX+hT/IyY2+XWaaNb6Rnmt+4PqwJVWsUo7xJEc Tj8g== X-Forwarded-Encrypted: i=1; AFNElJ+1kmFePSiFzKJyiXUdgE7a909jeAr/3AI1v/kXh/qgSiQ3yQYJ37wu/l1bgmJnHbPwv361kzEyy09yj2M=@vger.kernel.org X-Gm-Message-State: AOJu0YwVX4YRCEcHv+vf7B8rz8UKbqP1RfiDCmxq3Ufdy7rlvQa7r0Fk juwbpUAX8h1wUoA+F6rS+Yl4B/XotKXiRhB4hPWuvMrcLpJSaKhDDFIM X-Gm-Gg: Acq92OEpnr9ZYxrgkonHN9rS6yzfnAK+mawb+6yk6TBd53MCSOp9E1c9qNBouP3uQmD uMt72HpTIPhfVsYLimyA0URGo63b9SwmF3aQYnrK6/Z6oLOcELFz7J3eAyr+TqTFYJlYBw/87r2 XS2OeFXreXOlFFFUhL1KjRCCK/kR6sPE3Ox1hMZuwKaTR9uHSFyy4eptRxxpopAXIdtItanhptV dw7vVPwS6Geg8K6ATv5fJl7vRxAikEHolQCTD60hxevsH4gPFLIkhpUeFoBhorLTTJN1IhY/C1M vH8rQuh3YrHauGNKH0NkHxpTBcizBkmXY2zSvu8NB2BcOZ5T2bl9dbxXNEFrser1gBkZmklURCs 2SuGl5DA+lFcsVAcpU3FLlvNyoiIrDY5FL+XFakyrhzFYLSyRNCXCZvx8efBD+Dhb7yydXq7h0J ZUso8XJ773T8gv95Z+CGz+52kT5d5wx4zngXLdMWLuRGmMBRRpCoyKT52nlj38G24ACkjDw8fbp h9FvQ/9zpAMob9OorePUTmDWHGCZKeqnsOCGFa5n4Nnnc7HS3QkN3+K/3oJ9JtC X-Received: by 2002:a17:903:3805:b0:2c1:98b7:ecf3 with SMTP id d9443c01a7336-2c1e849577emr238682945ad.23.1781069607639; Tue, 09 Jun 2026 22:33:27 -0700 (PDT) Received: from localhost.localdomain (n49-176-80-106.mas22.nsw.optusnet.com.au. [49.176.80.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f8bc5asm242862735ad.27.2026.06.09.22.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 22:33:27 -0700 (PDT) From: Weigang He To: Daniel Palmer Cc: Romain Perier , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH 2/2] ARM: mstar: fix device_node refcount leak in mstarv7_init() Date: Wed, 10 Jun 2026 15:33:12 +1000 Message-ID: <20260610053312.2267307-3-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260610053312.2267307-1-geoffreyhe2@gmail.com> References: <20260610053312.2267307-1-geoffreyhe2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_compatible_node() returns a device_node with its refcount incremented; the caller must drop it with of_node_put() when done. mstarv7_init() obtains the "mstar,l3bridge" node, maps it with of_iomap() and never releases the reference, leaking it. mstarv7_init() is the __init machine init callback, so this leaks one refcount on the l3bridge node once per boot for the lifetime of the system. Drop the reference right after of_iomap(), since np is not used afterwards. Found by static analysis tool CodeQL. Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs") Signed-off-by: Weigang He --- arch/arm/mach-mstar/mstarv7.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mstar/mstarv7.c b/arch/arm/mach-mstar/mstarv7.c index 871c0fd258e66..64262b8f10a0c 100644 --- a/arch/arm/mach-mstar/mstarv7.c +++ b/arch/arm/mach-mstar/mstarv7.c @@ -117,6 +117,7 @@ static void __init mstarv7_init(void) np = of_find_compatible_node(NULL, NULL, "mstar,l3bridge"); l3bridge = of_iomap(np, 0); + of_node_put(np); if (l3bridge) soc_mb = mstarv7_mb; else -- 2.43.0