From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 027723B38B1 for ; Wed, 10 Jun 2026 10:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781086863; cv=none; b=n307Lb0BbbozGtDJmYlJ/zkpz5FLM8iTyQcQL2u1kocTJFkkHeeQIU4P4RRrPlDwkEO3PFLm0A5XLErsPCDPm8OVa7+hpD4mw80zl0+K4AK7vMPfIpfysLLZQD37nWCbFiD7TlQOhJ/5QqeJo9pEgsU2TyN/daWpthn3w2d7Iv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781086863; c=relaxed/simple; bh=oqCFls7mvbDi78AmlfEIReCmwgy1BeuT4n4FaEn6K+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DtHF8CrIZ1Pro5S1KARCyj62rvqjS+rRKXg5XgplXUTNmbt0LlhbHcLuz7T9qBFDSfmtAgsqjPEyzjjpz1eWedbirOlqGUFwGiE6kwtZiTnKbcpiRjAEobvLl6a65u8/dJtAJkmttcCNTWbe0d3vJZPOJLJcDZXp6YrRpqU3Gro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h3Ty1Ml+; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h3Ty1Ml+" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c0bd02d97eso73389935ad.2 for ; Wed, 10 Jun 2026 03:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781086861; x=1781691661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g48rDzZBVCGDCg/97G6a3N/2kOm+y9KrRj3TLV6zvrU=; b=h3Ty1Ml+Gfq0CZgQ2mXDqHywLwgtfJ5zrIbRZw0SEwwBPJcAT8wsgqOsv2DLom/CT/ oHHrA7O8SJ2rHiKYi1iiTGmWE9HY6M4C+tw2HIWQT0AC/3YgVKVpUyCYmWaLQ/A09AhJ 9z84yDMCJK74kUha3LSZMeBjHmqaS/C5lMRnyNzRfTNREJSek74mudNmkp/1tpP0RWOK gJNlebEdUKq8Usx0aPc3LyKGy6UjuuYskKl5VFXr5UDDpkm9WbAB8yu4JK8KOWRf1egq FCp/Pc400xswVtzP4LTGVT7yMOHMBY+YSSt7Hg8UXTZV14ddyDnZDZJUosK+Tfk6xpNB q+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781086861; x=1781691661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g48rDzZBVCGDCg/97G6a3N/2kOm+y9KrRj3TLV6zvrU=; b=NsOTPQPnD58fWv083jWkD0FwAz6SOazH5EErgtbOS2WzVnz+aspNvgtNGjparylnd+ B7xDvslOpT0K4zb+E95UfV8Hjaw3WqfmJH/991EgetlFosbVkRM9l6OypGelZT2wdrzp 6L1+H+19n83vWBCIBeyglFf2XiEacnUKyoz9yVRa7NYT1UqDLp8KiD2bxv0ytvOltTfu g3YYawcfcAO11fuS1Md9u9GdQOpQPdCTFyX9AXaVcCUSo59FIOiHHeodg0FIbgDpf4zo iBncaWsYpBeryY9qfr7/95Ty52ytKYlcMK6fYZK6Szhi9XUiJwKQ2J1/fUiIQW6RCB3p tBQw== X-Forwarded-Encrypted: i=1; AFNElJ8MvndyFnjHoxL/kZNUG07W5iCGCrYUGm8Kzw/YImWJ9+OrVEkRHkCbf+mFt7bYrKIyxN7EXpAepuGQBMY=@vger.kernel.org X-Gm-Message-State: AOJu0YxseTDEuMmH5enTEgKBXOGkXkj0pB2R8UDL4jguskq8ZMB/lE6w Yq8I/LPaz5zRVtwysqd8SF8yHtHAZAabXad7OZg73k/U/sfxa8DdqX/T X-Gm-Gg: Acq92OFJpW9TxECm0mBCbGhrEgc9lAJW8CA7992/rOwPqsPGQU9VVYWyEQJiyL/RH4p HeqrJehEC/eHG+bK+eCHvj/Bd0FplnrbHgaLa4NudEugVMkCrimtQq43XzSAuub5YAgBy8s42Oj xtwiYVrXyF9Sh8r2xW+qCZd0KmSTh4ClN1NGxkAMqefb2oEd8GcHeX9LteqsoIbNPj7UibNuTn4 PUrRjpywtUBQF5dCxEVKMrNU8qOb7q5EYtL8DE8rRdojilycQ/N8kZ2c/zOlqXLH6v7JGN2sANU nov8mZ46/rA7SaLa6aiq8H6kMkaaz9dmtbqkFVVwqShS5ToQMPpc265piIBQPY+vm8hKhiR8TlX J/Ps/cM8lnVWARKrnHO/rY7LUZdA/IvESJBu3aUErxs6XhzNz+GDQnAyD8vWJaqmg275LmSKAj7 xbcwecrwoPoX4sg3fEggmtfmEGt20l7hvUYQyxnCbwwhrKPhhNmWVUWwICXKoMI5XhR9lM2EHCL jCWShg= X-Received: by 2002:a17:902:f70f:b0:2bf:356f:4e0c with SMTP id d9443c01a7336-2c1e80d2996mr310019635ad.1.1781086861478; Wed, 10 Jun 2026 03:21:01 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f96b3fsm250133875ad.29.2026.06.10.03.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 03:21:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Linus Walleij , Bartosz Golaszewski , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bui duc phuc Subject: [PATCH 05/10] ASoC: mediatek: mt8192: mt8192-afe-gpio: Use guard() for mutex locks Date: Wed, 10 Jun 2026 17:20:16 +0700 Message-ID: <20260610102021.83273-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260610102021.83273-1-phucduc.bui@gmail.com> References: <20260610102021.83273-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Convert the explicit mutex_lock()/mutex_unlock() pair to guard(mutex) to simplify the locking logic and automatically release the mutex on all exit paths. This changes the mutex release point from immediately before dev_warn() to automatic cleanup at scope exit. However, the affected path only emits a warning and immediately returns -EINVAL, without any further processing. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8192/mt8192-afe-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8192/mt8192-afe-gpio.c b/sound/soc/mediatek/mt8192/mt8192-afe-gpio.c index de5e1deaa167..b993ca2dbd7c 100644 --- a/sound/soc/mediatek/mt8192/mt8192-afe-gpio.c +++ b/sound/soc/mediatek/mt8192/mt8192-afe-gpio.c @@ -208,7 +208,7 @@ static int mt8192_afe_gpio_adda_ch34_ul(struct device *dev, bool enable) int mt8192_afe_gpio_request(struct device *dev, bool enable, int dai, int uplink) { - mutex_lock(&gpio_request_mutex); + guard(mutex)(&gpio_request_mutex); switch (dai) { case MT8192_DAI_ADDA: if (uplink) @@ -296,11 +296,9 @@ int mt8192_afe_gpio_request(struct device *dev, bool enable, } break; default: - mutex_unlock(&gpio_request_mutex); dev_warn(dev, "%s(), invalid dai %d\n", __func__, dai); return -EINVAL; } - mutex_unlock(&gpio_request_mutex); return 0; } -- 2.43.0