From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127F23FDC08 for ; Wed, 10 Jun 2026 12:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781095211; cv=none; b=tJ9YHSR4WB2/rzRLeTAzfA+b0jgdgcfDqzgChCI1u/VdIIIpqPoUfjHyfyU8j+tOdUtrgJeYkR/jo1+R/jkMpDBDVd5ySreO7GpZZgfNrslowYAzNNyJ5nk+nl3SjttNzVWDckFziw/QUhjsYlf9UGkqZL9/SKslao+TVe3TmQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781095211; c=relaxed/simple; bh=6GLaNtAOvcr+X26Nb+AM8LIJ8VknGJTaxaZw4baqneQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PlBNHboaLYHu3mggfbENrkqLD5QWQhrTyBAE+pYMW8pbDUwzQ5jbaMY6uP27Ri2BPXkOlgkxF3F4iPmNlNvR/C+H1HngKmSAWLl3FsaQZAOqVeOsTXIKtr+WH2cwQccRrbNxLLHWoZh0cgraBK/RvKu6J0HoKXH0FgL9ja2O8vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KPqhoypF; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KPqhoypF" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-91574384cc2so767993485a.2 for ; Wed, 10 Jun 2026 05:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781095209; x=1781700009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tLVHzGu2Du1k4J9c4p+zgX4sdLFgy4zvRmNg1eHlph8=; b=KPqhoypFYrAA+6sAIJ0w9FlDj+xkDSkdNKBZEM7rM8k+vgbtVFuu65/gOJtu58koik YbOoSas0cZJo6/bwr+pZWxAMQgmCz5mnT0uOCY56GY/h0EE6n8Z4WcEM8iM36vmDgVjM K04/9QahT8qE62nHBMCH7xlxgPzgLgwThImnd4JFr1kjrvfREMCResnjTSMbV2gjGxx4 9JUY5BHF1SsX+7lnFykNGRXwS9nYLEUuLonwmq4tI05tnbvgLAzsOcGZixqOoUfaN5O/ KSKoStKZ97VpLdf7VGgS5VIfR+xWX/raSm1uVr6JtfGpV1zlRePXrLkwDLsER907QsQw xGnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781095209; x=1781700009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tLVHzGu2Du1k4J9c4p+zgX4sdLFgy4zvRmNg1eHlph8=; b=mvXhZaKTn0+2ZA2x7VS+Xx59VhkcusbfTCvYuouDrXikqzkj2x838PbJMg0Q3ZDkes KRxGRQRxIjbg/wB3iU/nmOQA5gQ8iolpYfdbK36EZxH3fmGNiP32FCDwG4BG5Zxsl1E9 ywf9pPmCwlUM2/EUrLXUv5r6reGJLttXiMIUCmzWQrwzEhByQpeKbZppUPPzWCpSlQQB zshpEz5TPMka4epFpEWMvbw1g5+4Rbtdo6h3uIGMr492DFOvaMuxhmJu5i1Z6ZU+MxP1 4hCXPZG+Ejjt0+w5ZDyYRd8VVxe6NYL0SPAVIxBdu43m/ZFqVS3RijNumRuBPhWKAfTD R2BQ== X-Forwarded-Encrypted: i=1; AFNElJ9yEfvYZBg30ZCytQuZEIskL7evJZQK5ZNiI1lSGEh+9xrs0u44aO6y1GS7Ex+9nAsJ9q6SXUlZCMfjVx0=@vger.kernel.org X-Gm-Message-State: AOJu0YwvoDgdCIxhd9rhFD4bJlVXNPHvgxjO8ZJY246sJa+8CXhdDqdL JrHoFEgf72a84qXN770PxxSG3Bqeb3Hc5O8dKwXi0ic0rFNuZU9yHcCZ X-Gm-Gg: Acq92OF0JiMTVzIOjyGNVT2z/nhymnwhuQkOXQGAMoq2KdhoopvEYWxsPECGTRNdeFf W4Po0dseBAEhqDqoaLqQ/wxe0jEsjdCteoXZ3efDzsbWCA+O0j5bqq6a2ppAq8zu95WK8+MwTf8 M5geANMwY7P2kEQdZl05/VohUBLw+my5flAziN2Z3s8gRcfdaeJ9hHUfGSVjGbZuRqQmeMT/WJy REKUG3oMdaZwjluxlGEN0CwjpeIronZPSBrKEbkCkvSdbJYL07NZGfYy+UyZR+cjVuEbX+O4G/2 /BnUvkQPFvpvUDBh2zMXLDOTbx/cEh7c35g/Qjzc1YR9G8hyGOCeATNS2X9RNSHlbAk5/BTEe2b ryveyB9WRoTWca3H//Mgn+AqaizAuC8Rs6OTsdorUrcmyK3nT/uM19HjEZPdhhZuwiXAaixcIMo yjnaSgWZCGOGcRuF5SzXmhivI0qcluMr0BOXvSD8AisNo86RDkP+kAvZ2vPLXVueXshUUgWKslJ 5cgEGMMU9XHJWGRh8/+zdbTxeZazzM= X-Received: by 2002:a05:620a:1d0b:b0:915:c4de:7ac0 with SMTP id af79cd13be357-915e82e7f40mr1123809485a.31.1781095208799; Wed, 10 Jun 2026 05:40:08 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a237330sm2499096885a.16.2026.06.10.05.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 05:40:08 -0700 (PDT) From: Michael Bommarito To: Jon Maloy , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Tung Quang Nguyen , Simon Horman , Ying Xue , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH net v4 1/3] tipc: require net admin for TIPCv2 netlink mutators Date: Wed, 10 Jun 2026 08:40:01 -0400 Message-ID: <20260610124003.3831170-2-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260610124003.3831170-1-michael.bommarito@gmail.com> References: <20260610124003.3831170-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit TIPCv2 registers mutating generic-netlink operations without admin permission flags. Generic netlink only checks CAP_NET_ADMIN when an operation sets GENL_ADMIN_PERM or GENL_UNS_ADMIN_PERM, so a local unprivileged process can currently change TIPC state through commands such as TIPC_NL_NET_SET, TIPC_NL_KEY_SET, TIPC_NL_KEY_FLUSH, and bearer enable/disable. The legacy TIPC netlink API already checks netlink_net_capable(..., CAP_NET_ADMIN) for administrative commands. Give the TIPCv2 mutators the equivalent generic-netlink gate. Use GENL_UNS_ADMIN_PERM, which maps to the same namespace-aware CAP_NET_ADMIN check that netlink_net_capable() performs, so the behaviour matches the legacy path and keeps working for CAP_NET_ADMIN holders in a non-initial user namespace (containers). A QEMU/KASAN repro run as uid/gid 65534 with zero effective capabilities previously succeeded in changing the network id and node identity, setting and flushing key material, and enabling/disabling a UDP bearer. With this patch applied the same operations fail with -EPERM. Fixes: 0655f6a8635b ("tipc: add bearer disable/enable to new netlink api") Link: https://lore.kernel.org/all/20260604163102.2658553-1-dominik.czarnota@trailofbits.com/ Assisted-by: Codex:gpt-5-5-xhigh Signed-off-by: Michael Bommarito --- net/tipc/netlink.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c index 1a9a5bdaccf4f..8336a9664703f 100644 --- a/net/tipc/netlink.c +++ b/net/tipc/netlink.c @@ -152,11 +152,13 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_BEARER_DISABLE, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_bearer_disable, }, { .cmd = TIPC_NL_BEARER_ENABLE, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_bearer_enable, }, { @@ -168,11 +170,13 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_BEARER_ADD, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_bearer_add, }, { .cmd = TIPC_NL_BEARER_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_bearer_set, }, { @@ -197,11 +201,13 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_LINK_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_node_set_link, }, { .cmd = TIPC_NL_LINK_RESET_STATS, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_node_reset_link_stats, }, { @@ -213,6 +219,7 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_MEDIA_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_media_set, }, { @@ -228,6 +235,7 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_NET_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_net_set, }, { @@ -238,6 +246,7 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_MON_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_node_set_monitor, }, { @@ -255,6 +264,7 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_PEER_REMOVE, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_peer_rm, }, #ifdef CONFIG_TIPC_MEDIA_UDP @@ -269,11 +279,13 @@ static const struct genl_ops tipc_genl_v2_ops[] = { { .cmd = TIPC_NL_KEY_SET, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_node_set_key, }, { .cmd = TIPC_NL_KEY_FLUSH, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .flags = GENL_UNS_ADMIN_PERM, .doit = tipc_nl_node_flush_key, }, #endif -- 2.53.0