From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7346E3FB06B for ; Wed, 10 Jun 2026 12:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781095212; cv=none; b=brlRd7+AI4aQmfj/O+vLZE8cUo+2L+7nkG0R2W0ySk5Qq0zUhZKYGS0W2+sP4QZ2K2QTFkNMMV+RAj3BwDS4eY8CwYoj+QytDxwHWUsReTE/9IoTN6f6wV1NKHU4jqsC6dKjIbaZHVOeizWIXVjH0fgLMj2OTK3hMxV543/2QA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781095212; c=relaxed/simple; bh=VG0IT3yM50Mq4JKm2XtmCthKoI+vTzER7R+mKGMJA1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XQmp8g1vDWIxQJoNmZdBRl6nkXS52TnvaPWETxSGmTBjQmz5JvLslrjKUewyIDU1jZgrSQSVHM5k5lv65BudogzskAQ3umQvxFemGxINJWZCc7N2kIO6Dr4lXAO28deeBADMAau2FcIJUdTwBaGlLWnZk9YNFZeBBiF52rDvP6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rCZcN+0b; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCZcN+0b" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-915671abde5so587664585a.3 for ; Wed, 10 Jun 2026 05:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781095210; x=1781700010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DkDiv7TejFrxyS+xIMDLxRZI5NicDdqKAe8ljgeC4Bw=; b=rCZcN+0b7LWLNOtAYZ+H5BO5calzFQk7x/urk4XBxgQ13wXiFQ4WdvmYTM2nnTuaA8 7raZdFwIehIEytEk/ijlA7QQjj9OR7NKpMBIpRPPmtnkTkFs82YyYIxZcswV7qE4RHE8 otuZOL/eUnPnXE23GE0Wdhpy2mk4GtXszJLE9bC2cJV7ZCMinGO+E1R02EpkE9aw3RN5 +n2f288TYb0mWDUb3ONyOd/U4i4dd4UiEAz9ME141JyyTSG1uzz1U54agUpKNnWMEJp6 JKjQb7wuzKQ9hCLXGSIBaUVswljieUoacu0IBQxgOxM+9pTyN0mcxXZgR1S+U+DHcWZt 5ttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781095210; x=1781700010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DkDiv7TejFrxyS+xIMDLxRZI5NicDdqKAe8ljgeC4Bw=; b=dBxydupNhr+nB2RTPK5mz7X+es1WehHjDyVeoSs3cWC2rV+n9yXXNGDZ9unId1fG+e SLyvBg/NIyTrWe/elsRfKhjhPRHCWoQpqCr3IRpYZjD82hfIA89f68h/AUrI3uf7Bupm Sd/5oQ1di33z0FhbBgwFyQtT+b7dJMq6NCzHlg/BJCXbkMURTgXe3uQR5KPFCM6YmT8c x8E18LT0EWaY0GtV4KrTwPScF9FcfXjx73NIqiALFb2XIVyz1A0R4aAtSdqIzyekOXVY CamO3FN/YIs2R9Pgmz6hgGPI6ReZ8wR3fZs0u2i7NlmmsHyBImzV7hhJKwbowkIkjqw0 +wKQ== X-Forwarded-Encrypted: i=1; AFNElJ9gz6kUFVTtz3ltzpXT2xYQOPcpv/7ky/mxKdVujahDpEuWMjRe9d+rVIOxQDM15yPzP7vo4qvU7o74Q68=@vger.kernel.org X-Gm-Message-State: AOJu0YzCdDU+1iGPfl2Pq3YgNyPleXWBkwVmzntrPGU8Xz7YD+BjhSOM BdGVpjg+qp4JpM8rfxdr6YCbcMBHPOpXiSnujU47CgwcSS/Ksn8r/hyQ X-Gm-Gg: Acq92OFQR/lQwXCqlXAJLFxsZderNesEIT9HCLvecucd36n/41Mc9VIpqtxN9oTdi2u Lxs1qcj+xT56mNZD11SRLob0O+qzwLCgcLo3iTQjRiO8UREbmNOlGOW7xsqGiqQV+i8LVyWCvh9 vQYOIlTSjaHwU5qp6Hw/KdS3sZxDv0PXMH7ULhQjd17dqEZgi9sIbLwz6vnf30o2GLruxdr+dID Kk2uAwl1lNMJcSaFRM1N2kz1xy7eY5w3lLFtlUwFqCdMoEgBh7aYpLRd8GbE2VGmJEnh/90pj1L 5kuR4c77iMpmEdjetqBMbDlF2UyIFurc9khZyRcJZnAloOJW3BQXyP13GVneZxftAQajydygCz1 9S/r8rG2z+k4yOeA7arwd0FCIhDX/yX/zdfJj/U8UQ0Bz5H2mCOFtQh01yfDM6qrQkTuyA3utOZ XQDWf4SP/R10DKV+GV2X3lf4XHXuEF8x11DJd3GvZ29TYZSXAZxAWs6NcVgkQioGwEpJO2wnr0f W1wYlZjso70gYxyvBaQrPD2T4zgSOE= X-Received: by 2002:a05:620a:290c:b0:915:db15:a24c with SMTP id af79cd13be357-915db15a309mr1828466785a.37.1781095210451; Wed, 10 Jun 2026 05:40:10 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a237330sm2499096885a.16.2026.06.10.05.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 05:40:09 -0700 (PDT) From: Michael Bommarito To: Jon Maloy , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Tung Quang Nguyen , Simon Horman , Ying Xue , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH net v4 2/3] tipc: prevent snt_unacked underflow on CONN_ACK Date: Wed, 10 Jun 2026 08:40:02 -0400 Message-ID: <20260610124003.3831170-3-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260610124003.3831170-1-michael.bommarito@gmail.com> References: <20260610124003.3831170-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit tipc_sk_conn_proto_rcv() subtracts the peer-supplied connection ack count from the unsigned 16-bit send counter snt_unacked without checking that it does not exceed the number of messages actually outstanding: tsk->snt_unacked -= msg_conn_ack(hdr); msg_conn_ack() is read straight from a received CONN_MANAGER/CONN_ACK message. If the ack count is larger than snt_unacked, the subtraction wraps to a near-maximum value, leaving tsk_conn_cong() permanently true and starving the connection of further transmits. Validate the ACK count at the start of the CONN_ACK block and drop the message if it acknowledges more messages than are outstanding. A peer (or, for a local connection, the connected peer socket) can otherwise wedge a TIPC connection's send side by sending an oversized connection ack. Fixes: 10724cc7bb78 ("tipc: redesign connection-level flow control") Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito --- net/tipc/socket.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 9329919fb07f0..f64f7a35b5c91 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -1362,6 +1362,9 @@ static void tipc_sk_conn_proto_rcv(struct tipc_sock *tsk, struct sk_buff *skb, __skb_queue_tail(xmitq, skb); return; } else if (mtyp == CONN_ACK) { + if (tsk->snt_unacked < msg_conn_ack(hdr)) + goto exit; + was_cong = tsk_conn_cong(tsk); tipc_sk_push_backlog(tsk, msg_nagle_ack(hdr)); tsk->snt_unacked -= msg_conn_ack(hdr); -- 2.53.0