From: Andrew Morton <akpm@linux-foundation.org>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: David Hildenbrand <david@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
"open list:MEMORY MANAGEMENT - GUP (GET USER PAGES)"
<linux-mm@kvack.org>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/gup_test: reject wrapped user ranges
Date: Wed, 10 Jun 2026 13:33:25 -0700 [thread overview]
Message-ID: <20260610133325.617652c3639b27b131de8b8e@linux-foundation.org> (raw)
In-Reply-To: <CAE+C+DZWRsKF8m5d-N-vkyp6rEw_T=ccWpUdqZVVYZ=oNfCvnA@mail.gmail.com>
On Wed, 10 Jun 2026 13:22:32 -0400 Samuel Moelius <sam.moelius@trailofbits.com> wrote:
> > > start_time = ktime_get();
> > > - for (addr = gup->addr; addr < gup->addr + gup->size; addr = next) {
> > > + for (addr = gup->addr; addr < end; addr = next) {
> > > if (nr != gup->nr_pages_per_call)
> > > break;
> > >
> > > next = addr + nr * PAGE_SIZE;
> >
> > Sashiko AI review identified a pre-existing possible overflow here on
> > 32-bit machines.
> >
> > https://sashiko.dev/#/patchset/20260609004814.1240586.6294d614ac80.gup-test-range-end-wrap@trailofbits.com
>
> Does the __u64 or Sashiko AI point require action from me?
Not really. The patch makes the code better, that's what counts!
next prev parent reply other threads:[~2026-06-10 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 0:48 Samuel Moelius
2026-06-10 1:27 ` Andrew Morton
2026-06-10 12:21 ` David Hildenbrand (Arm)
2026-06-10 17:22 ` Samuel Moelius
2026-06-10 20:33 ` Andrew Morton [this message]
2026-06-10 12:18 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610133325.617652c3639b27b131de8b8e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=sam.moelius@trailofbits.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®