From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D067540DFB4 for ; Wed, 10 Jun 2026 13:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781098519; cv=none; b=C/IhcjeGVHllsp+R1Hq1fRdOqiZxBuu2JSYQlIPm4l6FpH6G7iMsUUE9OAUlbcAzA5Q+llHb11BLMZaSJ6woosOaUzGUqaB1U65a/K7e4uKLJvt43JiJ4o+G1bPNfrFSo5yUdr1qho/GMKXBkQF54CPl7Y0nDDh56xn3qGW2+CU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781098519; c=relaxed/simple; bh=YUdqjoFhiPqQLaf4gJadZcw3eGr2LIScfANZVbT6QL4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZfjotuBU2KNxGw/J8m8YuFmtRGE6DzDEA2vjy4iMHV/BAJTIIPbuKebCTbF8ZjcESRwr10GXYfNIgY7t44/2EPVR5OW7qQLLclZDfJ7q8ZZAoVIzioeT4dX/UrHRthfQsNf7qRhLBB5SWvu2lI9HO8i3ut7n9ccKZ4JPn2CAUZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C6dvPlbV; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C6dvPlbV" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5aa61503fdaso6765745e87.0 for ; Wed, 10 Jun 2026 06:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781098511; x=1781703311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iLX2dOT9Bw/pz1APJXL+k95y9Wnfgl8Z5/bITb57NwI=; b=C6dvPlbViT5sQbueoeZFAHUlk1cv5y8IiGRqg1/olB6Gua5BTgZu3cJxvjvYtoEZ4t b1IEy/yWt322rHj+/2pceZ7ffykMIQF1BCQlkolvcKbF+zJaHesswH1PcJXTshnP/WU4 kGK8DT8m9XtNs7NLSyd811yFkKlqx5ttKYyGPf2Bq0EARL7hFqGZf9uME91/g+fln++k nTNTHBPqCpxHMueDgB/lQ26N1qf1F1cnw79ABy8ICJq6XaRsdPQMQiGWJY6xfHg41/l/ 1bVz1So83U+K/tcFXQp1tXAwTwwam7IUObhC1fZZEWnv4npdVR2+O4jvYmbi2QME2wn9 DXoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781098511; x=1781703311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iLX2dOT9Bw/pz1APJXL+k95y9Wnfgl8Z5/bITb57NwI=; b=jNtgHaYK/6nYeLBwAK8pk2Opb1hsHyPd9XRqK96NOqSRP4O/EZSeRQzZI6hjwjuFxt Yn6zJENeakE5ozrOT+SpzvD2k4MyfylM+W2YJdsFUeVVOlHA0HxCohV6MgeIaqjKRvEi a9tkGSUjj6SUrTpKUDNV/TMjVsxfb1tOrtbXSbKs4IGNfcoKv55I4SCGyb0+JZDjf9y4 nRa+SgstPV1xgmkEx8l9zbLXVHqMZAvZiv8gG5oY9DRJMz9HZ3TKE0AddsZN3zfd0rDZ oGBjjIbmptM+KBaW/+HSag28rPdnQsWG5zsJkxy5s117/RJUBSFtHOK4eiA7jyPmJrM5 hDAw== X-Forwarded-Encrypted: i=1; AFNElJ+rBNU1o8zoldtCRpqEbhyZ0sDcDLioRpsiJwnaeF5vN8VSj+cyzNKNV5GCN9Qdx0oQ4tOVN4DX3E5GY/k=@vger.kernel.org X-Gm-Message-State: AOJu0YzvBAVfwgXsyk9FkCqHdfpydV4yaquHxdA+/th4oOPgkFfWjZUK 915XutgkJQwvHIvxev469eQ8BxhEhcvhDIrYV3cFWD+pGeeDy+OexIqd X-Gm-Gg: Acq92OFOscp8hoMuSbKCuqnNnGASimoYsGrMrqoSfdzhFFD+QP5QifYexX1dlONIV3j 8COR+YBpY2VBe4FPOfGm9pEo+dA/ySCOPqeWSAwRSAvLReNFYeYdZo4djPfwvrt5cko5s/Ej85N 6SBJNZID3Zj2mw/UudCGAvY7a5rMVaE0Fkfl9nnpY4O7SLk8rXArXSaK45miOjZhU6WlbggsUfR OppsuZXxhXRgmte4u2YYQjWeF6G1eIQgKJp400THHDNDbu0etIUd3JY21O/SRSg/e6gQ1uShX9k usPv00dy4T75JU9zxFKdOXXGBc6iJw0agyRK/pg4CkLJnySoadoldM0yL0vFhoVD8Hyj1tivYsp RcILpz4BAI3rEGVtIxo3OnFRYOFzLi8Ir23UBar4QFOEjM/lUPdf5qlByG6BKKXTvMXYchpdE2V nphYqLCyIilo1elWc0ZTOnO0JEuN71dr2EmyJPjEu8PxQc+9nodg== X-Received: by 2002:a05:6512:1346:b0:5aa:7a7d:c7d2 with SMTP id 2adb3069b0e04-5aa886ca133mr5697683e87.18.1781098510327; Wed, 10 Jun 2026 06:35:10 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-396abf66ea9sm62000751fa.2.2026.06.10.06.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 06:35:08 -0700 (PDT) From: Jun Yan To: conor@kernel.org Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, jerrysteve1101@gmail.com, krzk+dt@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Subject: Re: [PATCH 7/8] dt-bindings: input: microchip,cap11xx: Add CAP1114 support Date: Wed, 10 Jun 2026 21:34:58 +0800 Message-ID: <20260610133458.970174-1-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609-ebook-tantrum-4846384c02d5@spud> References: <20260609-ebook-tantrum-4846384c02d5@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Tue, Jun 09, 2026 at 10:08:27PM +0800, Jun Yan wrote: > > > On Sat, Jun 06, 2026 at 11:04:00PM +0800, Jun Yan wrote: > > > > CAP1114 is a 14-channel capacitive touch sensor with 11 LED outputs > > > > and hardware reset support. > > > >=3D20 > > > > Add the compatible string for CAP1114, include its datasheet URL, > > > > and update the maximum count of LED channels and linux,keycodes entri= > es. > > > >=3D20 > > > > Add description for microchip,input-threshold: CAP1114 only provides = > eight > > > > threshold entries, which does not match its total channel count. > > > >=3D20 > > > > Signed-off-by: Jun Yan > > > > --- > > > > .../bindings/input/microchip,cap11xx.yaml | 21 +++++++++++++++++= > -- > > > > 1 file changed, 19 insertions(+), 2 deletions(-) > > > >=3D20 > > > > diff --git a/Documentation/devicetree/bindings/input/microchip,cap11x= > x.ya=3D > > > ml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > > > index e307628350c2..08233386a433 100644 > > > > --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > > > +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > > > @@ -12,6 +12,7 @@ description: | > > > > =3D20 > > > > For more product information please see the links below: > > > > CAP1106: https://ww1.microchip.com/downloads/en/DeviceDoc/000016= > 24B.=3D > > > pdf > > > > + CAP1114: https://ww1.microchip.com/downloads/en/DeviceDoc/000024= > 44A.=3D > > > pdf > > > > CAP1126: https://ww1.microchip.com/downloads/en/DeviceDoc/000016= > 23B.=3D > > > pdf > > > > CAP1188: https://ww1.microchip.com/downloads/en/DeviceDoc/000016= > 20C.=3D > > > pdf > > > > CAP1203: https://ww1.microchip.com/downloads/en/DeviceDoc/000015= > 72B.=3D > > > pdf > > > > @@ -26,6 +27,7 @@ properties: > > > > compatible: > > > > enum: > > > > - microchip,cap1106 > > > > + - microchip,cap1114 > > > > - microchip,cap1126 > > > > - microchip,cap1188 > > > > - microchip,cap1203 > > > > @@ -62,7 +64,7 @@ properties: > > > > =3D20 > > > > linux,keycodes: > > > > minItems: 3 > > > > - maxItems: 8 > > > > + maxItems: 14 > > > > description: | > > > > Specifies an array of numeric keycode values to > > > > be used for the channels. If this property is > > > > @@ -122,6 +124,8 @@ properties: > > > > is required for a touch to be registered, making the touch sen= > sor =3D > > > less > > > > sensitive. > > > > The number of entries must correspond to the number of channel= > s. > > > > + CAP1114 is an exception where channels 8~14 reuse the eighth e= > ntry=3D > > > 's > > > > + threshold, so counts differ. > > > > =3D20 > > > > microchip,calib-sensitivity: > > > > $ref: /schemas/types.yaml#/definitions/uint32-array > > > > @@ -149,7 +153,7 @@ patternProperties: > > > > reg: > > > > description: LED channel number > > > > minimum: 0 > > > > - maximum: 7 > > > > + maximum: 10 > > > > =3D20 > > > > required: > > > > - reg > > > > @@ -199,6 +203,19 @@ allOf: > > > > reg: > > > > maximum: 1 > > > > =3D20 > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - microchip,cap1188 > > >=20 > > > I don't understand this restriction, shouldn't this be > > > if: properties: compatible: not: contains: microchip,cap1114 > > > so that the constraints before your change are retained? > > >=20 > >=20 > > Previously, the LED reg property had a default maximum of 7 for CAP1188.= > =20 > > With the addition of CAP1114, the default maximum is now 11.=20 > > An if-then constraint is added to limit the LED count for CAP1188. > > Ah, is this because cap1188 is the only existing device in the binding > that actually has LEDs? - CAP1126: max 2 LED channels (0-1) - CAP1188: max 8 LED channels (0-7) - CAP1106, CAP12xx: no LED support The LED reg property constraints for CAP1126 were added in Patch 3 [1]. [1] https://lore.kernel.org/linux-input/20260606150458.250606-4-jerrysteve1101@gmail.com/