From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCF931A7E2 for ; Wed, 10 Jun 2026 18:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114821; cv=none; b=gY6urvKiyrycXlXsx1R1xgXq9fhMfGmBExd1MJMhAfpH/GXt0ZwwR7aiT1aazuuxFZJJfMexlEjunUo/guCXZutkuv49gV5OCz/aX9lrNahKLLud0IGgVi8UeCcvy9rWaSvl2Hq8UyhfERjBlQWZl0Ky98k4kvkUYpMQRGbEirY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114821; c=relaxed/simple; bh=gSOkpRQ1quPlQN6lRnIHqRnL53jp7xQqYZvpnyw9t3s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UDbQlm+zDRn8AmZYl+ThVSAZmkXWQVGgwbPP8DZLu4xHMhzIA3GO5JCEXaEmr2+FZpw60AkXm3Nr929KlRFNu+4sQD5RrBm8KueMGI2iTcFx1/7BrJk3y5RBrXVHpR6kfFs/NJMicss7zBP+LqwEsKfLcKnMhEyIofeNJkm3nlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V5cobSLD; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V5cobSLD" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf2d865383so11195ad.1 for ; Wed, 10 Jun 2026 11:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781114820; x=1781719620; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PFGu26dN8BqgyfJrrBjH4o8dhOALdzqo9pBHmzVqc78=; b=V5cobSLDD3oe4eGvaSjye4zJZVFShZ87j+T0sUqjWrhkbHOoQrEZTzhk4z4qWUwxUc jh6fq2r7wt/oCS7gZjXUyDQRwbTfwrXpnrU9JeJB+28aAYnhAMIeSwfUz7079lgNI6mf L33Me7MT4/GdQswl4bz0viu+Fjx3RldeymbDSZUdEgaccq451hpV6nsOSQrorjDJKLOp 0aeNHhKQ7nLttfhwDeDCOCSkVTaeL1hdd3oK3RA7HrhvE5xVzFUhmJqJ0Q1evXfavgHi VJh7/3zKBchtUOoMx1hAO1iSQEYRSLGa3eKPXIGkUvIOhZvxUYiJdubmYa0lr8Ny2KFz nmwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781114820; x=1781719620; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFGu26dN8BqgyfJrrBjH4o8dhOALdzqo9pBHmzVqc78=; b=DGYQCGl9HfxuHtiC5I4ertQMwQVywPACsc//P3e3/Fzq6fOi8G9wi1/niQXVQ6Lkra nEhiSxPglJnE9AmVFwn93xe5obE6arrPF/OFuOqSrCLYGersqJfqH6iMsZ8SjMWB9j28 CbI2mhwNqoLUWRV2EUO5YHWZez6VWgzijjL1PdEPMkb5QHa1Gt6YLGaje3I/MbAeFTH6 +rgpb0N94qFRpVCB2fm9mZbnmc3oulsF2ouqQ03QoAFmmlM9mvWdPxDM7qblhh51CArT GQeQYvD203mbCaZwJ7U2F6eHrVNLH828wfqr6G7+1kSJJyLQLFJphWDkSgSY0VLCEBwa 0tYA== X-Forwarded-Encrypted: i=1; AFNElJ/pHFlOVm6A7Vibj0Z8FlUrULC50ikm0RtoQbPgqU3S1RD6ah9aHpYDpl6bPh5WhG0oF4izTxfxzhTDwGo=@vger.kernel.org X-Gm-Message-State: AOJu0YzeC9ogJyFVrv7ZAO6io4ZBSuTK52Jz8cYT4Y3JHr3eeAdyg9Cc eUmIneULDgsBFalymWFaymuQ/rWwegVi/iX91iCDEyD2Db1AbZ87EmXO0tcI8a5PjA== X-Gm-Gg: Acq92OEhiX9ZbJBMFZFAhUyWZx/9BUk5oMGVjIoESjEyJHEAW8PS55G5FA13y4XxVuA 0pf1wndrI19h5vKxhZZvxt0tLApudaaesuIREW6Jf9nCveLxAvM7prIPxbkmRuGNVcuc25lfuB7 AwPq/XE6xEuw62MNEDRfN7QDHzzvNgtbsWT38g1vvu3OY6s/nDmfSD7naaViL9XJ2hQBuuE3zpz yxcyrYMuF/Wt58KXl3FF7ibPQXoRZEFX/qvOr4E/rk5G+dyZVVcA3bhe1ZBuLRbqn4TOqfj7Edz qMPWYNjeB2xaqD2PsJJV1Bx2h55cjWeiz1daQGanlC8P+jRzDlN29qE2gowTMXZbC5oGh1+yJeB PzMOfW344Srp0D+QYhYlDfapv3D5ShIytmr3k4NyGFoMFctowVSDkKRADpy9rI5yLtb9j/uJO8a OaXGGXieHQDIy60orwe2fdMflwKoO2obpTkjZnpVoRVAtKN6Nq/TatA9gJUYdxo6sFEipS0mO48 o9hamN7iQ== X-Received: by 2002:a17:903:3203:b0:2b7:b03d:9dce with SMTP id d9443c01a7336-2c2d93807cemr693025ad.18.1781114819544; Wed, 10 Jun 2026 11:06:59 -0700 (PDT) Received: from google.com (176.13.105.34.bc.googleusercontent.com. [34.105.13.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c24edbb49bsm122656955ad.38.2026.06.10.11.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 11:06:58 -0700 (PDT) Date: Wed, 10 Jun 2026 11:06:54 -0700 From: Vipin Sharma To: Pratyush Yadav Cc: pasha.tatashin@soleen.com, rppt@kernel.org, shuah@kernel.org, dmatlack@google.com, skhawaja@google.com, tarunsahu@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/2] selftests/liveupdate: Move luo_test_utils.* into a reusable library Message-ID: <20260610180329.GA224168.vipinsh@google.com> References: <20260511201155.1488670-1-vipinsh@google.com> <20260511201155.1488670-2-vipinsh@google.com> <2vxzo6hlt86a.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2vxzo6hlt86a.fsf@kernel.org> On Mon, Jun 08, 2026 at 04:31:57PM +0200, Pratyush Yadav wrote: > On Mon, May 11 2026, Vipin Sharma wrote: > > > Move luo_test_utils.[ch] into a lib/ directory and pull the rules to > > build them out into a separate make script. This will enable these > > utilities to be also built by and used within other selftests (such as > > VFIO). > > > > No functional change intended. > > > > Signed-off-by: Vipin Sharma > > Co-developed-by: David Matlack > > Signed-off-by: David Matlack > > Signed-off-by: Vipin Sharma > > --- > > tools/testing/selftests/liveupdate/.gitignore | 1 + > > tools/testing/selftests/liveupdate/Makefile | 14 ++++--------- > > .../include/libliveupdate.h} | 8 ++++---- > > Nit: perhaps libluo is a bit less wordy? > > No strong opinions on it though, so I am fine with anything. > Thought more about it, I think libliveupdate seems more appropriate: - VFIO is using similar strategy libvfio - Name matches selftest folder name, so, kind of easy to know where the library is from. As you seem fine with anything, I will keep it libliveupdate. Thanks!