From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6E1140D565 for ; Thu, 11 Jun 2026 01:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781143062; cv=none; b=Mn98qboXXsW+1aWPOvlsAi1aLevoGtnMOJPDum7ZCx+w9RxFUmdgQugkqgc/dl1cm+V4PUBspG82Kv5o6ADxjs3IJ2bgAskaWxH6HtvmQFTLcNRHokVV8fwOE5EZNsuSnkMFhysqQZ86yqhco9d6nJObC4soPO4qoJzgJPFC7ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781143062; c=relaxed/simple; bh=YHzSKusAy7Gd4N6ql/4OLrO2/dOFD8Ms3apGQl9HKJ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vFGswLzFqnWSZ1gNqQe8ckfzJYseIDBOXHqtTI4QbqUP4qa5NoFsy/zZDDU6zEyLAy6Kl8Vto1DYgcQ8rSxdEawR8RF2e5nzja2axAX8URvRi8FPGmKfcmRdnASOVtQ1o9DsIgNmUcNsiqaXjLIZMdH53gTEPiaD5zn4t6Tvq24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [117.182.75.76]) by APP-03 (Coremail) with SMTP id rQCowAAXNdwNFipqpr1TFA--.11030S2; Thu, 11 Jun 2026 09:57:35 +0800 (CST) From: WenTao Liang To: Philipp Zabel Cc: Hans de Goede , linux-kernel@vger.kernel.org, WenTao Liang Subject: [PATCH] reset: fix refcount leak in reset_control_bulk_assert() Date: Thu, 11 Jun 2026 09:57:31 +0800 Message-ID: <20260611015731.57989-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowAAXNdwNFipqpr1TFA--.11030S2 X-Coremail-Antispam: 1UD129KBjvdXoWruw4DXF4DuF4xXFWDtw48Crg_yoWDJrg_Gr WxWF17G395KFya9w1jga43urWS9ayDZw40gFZ0qFW3KFWvkr17XF98ZryUJa1UXw4rWry5 CF4kCrZ3ZwnayjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbwAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUywZ7UUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBg0PA2op-KFYggAAsD When reset_control_bulk_assert() asserts a batch of reset controls, it calls reset Fixes: 0b52297f2288 ("reset: Add support for shared reset controls") Signed-off-by: WenTao Liang --- drivers/reset/core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 38e189d04d09..daf9201bc105 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -516,8 +516,15 @@ int reset_control_assert(struct reset_control *rstc) if (WARN_ON(atomic_read(&rstc->deassert_count) == 0)) return -EINVAL; - if (atomic_dec_return(&rstc->deassert_count) != 0) + if (atomic_dec_return(&rstc->deassert_count) != 0) { + int err = rcdev->ops->assert(rcdev, rstc->id); + + if (err) { + atomic_inc(&rstc->deassert_count); + return err; + } return 0; + } /* * Shared reset controls allow the reset line to be in any state -- 2.50.1 (Apple Git-155)