From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9AD375F8A for ; Thu, 11 Jun 2026 06:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781160855; cv=none; b=nivKBaWtj+aIVTHeVRh1uelFAQVkkKa5hCAEvH4q+ynjI5Tex4hjoShKD9a8VLwZ000YQUCmG9eGo1C1G33J1nNO9i66I8hjnNWUG1LNQQabwAlGtZQhVmWo2z/YcPiLNVUOfYbfgiCmjsT6xXRb0Z5dzdRN8IKWNmYLi06RWl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781160855; c=relaxed/simple; bh=BzoDKri2AnQ0Gzc0Q9uN7BE4vlA65vCGXfLvgcKu5xo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dLjoC3zsDtz5x05BOqF+HBz+wZXXAlGiQmmIKIGbrzBwxX81jBbHEG7XijQXkBplQy6SPu0swWhOeMfLGLl8J+Dh5qNZqvm84WhpZJJy4DtdJ4Ka47b87IxISROOcQRTtrQHu5VUab65yh6lx/L7RX8MCdhNG1OrThfUgHurNYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hcninkPn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Uw2f6wWu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hcninkPn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uw2f6wWu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781160848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SyfejcTOJzGfkGjW2j6iDmBXVI3fZpPrk4NxQ/CTQBQ=; b=hcninkPn6ZsvavI+axoWObNinTizQH8ZJMeyEL3x6JhS+nhmbWG7yJgYrzUxCf+OLmPluq gkqOlhaymsiUyF5YJUsgUnZ3PeWe/9Lpjketbolp8gwqSSq/ltJmUINlaKBmGUZfgWyO7r cXXEHjWFeNFm/UK7M7zW+A4vWuY+8rA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-dGLgqzkkNPyNywH0XV7d1A-1; Thu, 11 Jun 2026 02:54:06 -0400 X-MC-Unique: dGLgqzkkNPyNywH0XV7d1A-1 X-Mimecast-MFC-AGG-ID: dGLgqzkkNPyNywH0XV7d1A_1781160845 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490c4f61a34so39704525e9.2 for ; Wed, 10 Jun 2026 23:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781160845; x=1781765645; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SyfejcTOJzGfkGjW2j6iDmBXVI3fZpPrk4NxQ/CTQBQ=; b=Uw2f6wWuujGQWwdAlce2hcarrNsvmIkCyI8wAFE0LTwuJKv6K6MZ21Wqc6KWScKYY5 hKB17SYireBxbU9YH1bZZbdOBK2sVG8BvRr3e/cbPqUzwXFS7uy5ycCpt5uVkSQJcu+M XTx5zjH70JWeYDzU7gQhyU/RjAd0XmiHAosvBP+Xrtn2bQiuLVChtNubc9gMM7yZryR3 ZNttnRZP0B+7AP2wNAUrh9GgG6RieXMg8nqwy4f5bR76nFYm8gV2svrNEARmrGpq7ypj DGD7YT+P3zzD+jb2IU3QMZ8pdVsDOsL2WhTDX5H8RIO0K8AP3ctJvTjPhCtkw83qvqzC qQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781160845; x=1781765645; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SyfejcTOJzGfkGjW2j6iDmBXVI3fZpPrk4NxQ/CTQBQ=; b=lgJXr9bk8s+kGZsy2IT2SeIrOh/4dBCjk43pa5YxgV4EpOgYiri1CWRHfFTXUqV77+ /hSw7yZKJSwk+gG4/n55ZRiEJeFfAgH+IlazZfIO8XrUkUL8zqswAABVwcvP1/iOGvIm Ei8UzPTcyGUUA8JKxy0Jg5gqI526+ewjjbQFhTSkwC6i5q+NrcRYfLLGNN/ewTRTW7K4 5nf1FWrEWofbuBjaEZR5SxCbhCkHp7fS0dj3QoCP9F9jlypXdvD0MA7MSEBgdysnlyJi ehnPAowGPojm1zdHEooPp+5elkjTeEaqjK9Dau5aojs9s/kH0bqIALr5BTLfQC1dsPXF HT/A== X-Forwarded-Encrypted: i=1; AFNElJ//CUDhjlGRs+hdJui5pjKUbh3Wq3kiGKi+MnoY8DBCdKH5KN4FQolEPoisH6/wHAW6s/poFx0Hb/8gmGo=@vger.kernel.org X-Gm-Message-State: AOJu0YznFn9PDy7wS+zEeiFb7PsU9w9jfSq47qDlJrrDnfGQQRvHBEW+ UNPgNpgKpL6bkB1N1HZLnvK8uv90hae21cg3Nk1S+lF2MwEPfCyQkJByoF2QmIJvx4P5zYc8Gy0 uHdLQRjjyaS8dq4P5efRXUyG0n5mo7iLSq8J0SBZTpQvyeEW6yLZnZaUdVjPk6GQHMA== X-Gm-Gg: Acq92OFZnAylDieFMvk10NtZ8NLQhNkcjY2WE/MVpmTRayKzMy7uLeSzp5WonGpqkbx CcEVsWJXzE6waACCK25Edht+go8PurZXT2bdiqGHwmqzZ6NgP08QmBrGdf5bF5NahgYonIHPpo8 Auf5+Pq7zhXV2uXUa/hGYNgZ6XbFrMc39HMTFXrb/D9yMXjy+e3cygTsC4ikDolEOFBzxlGePER 8HjeVUv5sm2/a//aYPvyWka2/SpGK/Si4PWhgAXb5fsaADY3alIkyTgXEPv13lG/+zkWBTLsRl/ GHUNszkiCzF0BZUaF8Fz1kpN80yHBBuF7aZ7yfRuokhUD7JxR7WymcMu1DaLUZdnFTBKmwUGRhi tWt+o58mpiJVxua3Dna1sYquMYiipHcmhbrBRxY5WAk5kNYSTAJTHyg== X-Received: by 2002:a05:600c:c04b:10b0:490:c2a3:3302 with SMTP id 5b1f17b1804b1-490e561e473mr9784565e9.35.1781160845353; Wed, 10 Jun 2026 23:54:05 -0700 (PDT) X-Received: by 2002:a05:600c:c04b:10b0:490:c2a3:3302 with SMTP id 5b1f17b1804b1-490e561e473mr9784225e9.35.1781160844845; Wed, 10 Jun 2026 23:54:04 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4602cda3651sm67202077f8f.32.2026.06.10.23.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 23:54:04 -0700 (PDT) Date: Thu, 11 Jun 2026 02:54:01 -0400 From: "Michael S. Tsirkin" To: Nathan Chancellor Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] vduse: Fix error around jumping over a __cleanup() variable Message-ID: <20260611025332-mutt-send-email-mst@kernel.org> References: <20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org> On Wed, Jun 10, 2026 at 12:16:49PM -0700, Nathan Chancellor wrote: > When building with clang, there is an error in vduse_vq_kick() from > attempting to jump over a variable declared with the cleanup attribute > using goto: > > drivers/vdpa/vdpa_user/vduse_dev.c:566:3: error: cannot jump from this goto statement to its label > 566 | goto unlock; > | ^ > drivers/vdpa/vdpa_user/vduse_dev.c:568:2: note: jump bypasses initialization of variable with __attribute__((cleanup)) > 568 | guard(rwsem_read)(&vq->dev->rwsem); > | ^ > > Jumping over a variable declared with the cleanup attribute does not > prevent the cleanup function from running, it would just result in the > variable being passed uninitialized to the cleanup function .clang > errors instead of generating the invalid code, unlike GCC. > > The jump is only present to call spin_unlock(), so convert the > spin_lock() and spin_unlock() calls to an equivalent guard() to avoid > the jump while leaving runtime behavior unchanged, clearing up the > warning. > > Fixes: 6c141c034c1b ("vduse: Add suspend") > Signed-off-by: Nathan Chancellor Eugenio? > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index a257fdcb77b7..0500da043761 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -561,9 +561,9 @@ static int vduse_vdpa_set_vq_address(struct vdpa_device *vdpa, u16 idx, > > static void vduse_vq_kick(struct vduse_virtqueue *vq) > { > - spin_lock(&vq->kick_lock); > + guard(spinlock)(&vq->kick_lock); > if (!vq->ready) > - goto unlock; > + return; > > guard(rwsem_read)(&vq->dev->rwsem); > if (vq->dev->suspended) > @@ -573,8 +573,6 @@ static void vduse_vq_kick(struct vduse_virtqueue *vq) > eventfd_signal(vq->kickfd); > else > vq->kicked = true; > -unlock: > - spin_unlock(&vq->kick_lock); > } > > static void vduse_vq_kick_work(struct work_struct *work) > > --- > base-commit: 6c141c034c1b0b74a2ca4dd3d6fbb6d9054f6e46 > change-id: 20260610-vduse_vq_kick-fix-guard-usage-d1037c331419 > > Best regards, > -- > Cheers, > Nathan