From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B20C33A711 for ; Thu, 11 Jun 2026 03:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150002; cv=none; b=YftVLaPGyCQCYBzKWtboTRQaVIpdsO/yAbdXYS4gQwB4U4KNajpZ68PAOmImssLxJKl+ii07LT6vbR2yEYLXr0VNlSqotIZ0o93IVrVehzTqBwpyZ98MQFTcrX/CplUa4mFEWq/yN2wxZ+KOWUaCZueQRfJfZxLU9/YDs59R9K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150002; c=relaxed/simple; bh=US673kb/X8Z8RqJZ4fkrI1dtQ4jRRXybN/z0dPlMBx4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LeiC18STx+XlbVKQ2CyVrLKoUFJTyjjRusXlxoY+UGEswlaPGOe9lwKtvk4j26XylmskLQK6TQLRAi63keyTiVZnN7F0/jaaerfesAvuX1bZVY3GzLx1tEo4Z5F+PhpDg25pNQiICHGJYQbHT15BUG0TezazYNKfi9vwg0U5zGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nNsqsXQw; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nNsqsXQw" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-36c68964315so3719859a91.2 for ; Wed, 10 Jun 2026 20:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149997; x=1781754797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N3Y9CBzltffMyeyjO+tKHgWOm91RTvExE1MCtYJb7pE=; b=nNsqsXQw2sB4BttBNkvHkppf1n/3LcdquLO+YnZhAJ/S2+wBz5V1IPW3zZYUN0ww5V wwfoD3r8MjhKzfRLY7VGjDgLiKUrau2jI2UqfXQXf091WX9ZYoFWyVxWCDAfp6EzgU26 zEZ5hxrtgRisErlVPZXVnKEHGUu+Reuczdjig52NJq8Y7EeG8K5GNE1go+tH6f3gQmTX +HjD3hCC9hNAyuY0TTCTaeFdZl1uRjPDUJv2i2hF6VNOYfExX27F+mBd8Wn+PF1z27yf //GSZKXL99xFo8XFbYWgu0XQU9OrqlQocR+wLQtyfsdFDmtghjxifTRvlB7Hg9oCYktu gtsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149997; x=1781754797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N3Y9CBzltffMyeyjO+tKHgWOm91RTvExE1MCtYJb7pE=; b=dRDkvOSNrofZzsUdyHG79STCK1StdcQ7/SNzY5XklAA2LCH3R0JvnpEfjx+iaEf62k YgxiwhBuLNvjOEIZFfOsloePE+v8i2AOc0LBdu4RQTLPobcSbtrZ/Ys8Jh8iGeOGaeLz oWN9HC0GbkR+4Dfh4dBKImwT1wqjq1DjJ1l4oCoSm3hnq8jvDehd+A9HeZOXd9MXVuce EVo+iQ0eiBMKWN3w1zAr5MKX96ywuY2NPNBrhU28gJw71ioTpQHcOY3NIWCa2cIdP4AA G29QXRdfc4Jtu2kd7p4vieor+MtgBMAd++VRYMApNZZ2VsAd4AkG1MKvgqg+rdzgXUTe /15A== X-Forwarded-Encrypted: i=1; AFNElJ9DY9+aaPurRL2BjbRXBDOqXllzLRqDOUNfrpNitWsTKNYidafEmiaXU+LlDR58CHbNd2HjlNKPTlOB4gI=@vger.kernel.org X-Gm-Message-State: AOJu0YxFVHI5rpe0+JlzuCWNifrsvUVVrjpkuxhIIALJBSHPGBQISpQn yD/lXNZTSCUOVHx0ha0j31ljiNAQ5vYO1+pZ8Ri+nTyMdDKPwuzt9zCm X-Gm-Gg: Acq92OHYnLxJlbPDBRTUv+8zK0sT2zYMnHjVmNsZghK+X8w+ZLwvUsfThCei+f5jGxi cAgMrxWx0y60yNl0+SrPGT186gN8eVBS87xTFV+rd5eQWVdICotapk2TG4CaIqiQIjgabDN6Vkl 52lDqV9q8VX9KkBncnJpeG7IZI1YFOZ6baLp+V6C5/Tit2C8Dvl1u9xxkylGqM0bpCbRBdjFvGL rN6O/6xUWcfneG5/RKufXQ9dq7QTRIkGfsuQ5gWs7uXmvl5zC/Z5F74D9SqZVhhCWDqc3/yoeNv QOyYrCwzRymoGJ4+k+CDyNRHJgKRt+ZTxm3HAqM/4YDc+tVm3u30zgTAsqQWnBXFWgTDRg/6D7I VditgcThXsKfMuXo1KsATnfXot7KKDyl0xy/OPmpZRlnQe8G/ImHQJxb6McPVfIH+8aiPQeuoHP M0oAvkZMuq9aCxC4lSoPBKHa2qsWwGZvX1FKm3DYywelG7EZd2EfG0NcQIovmV02BuQonY8JQRa 9uULXjGe0abVFnfVnjzCVhvKzFgoF1uhyqbwcxnRBSbZA== X-Received: by 2002:a17:90b:5905:b0:36d:649b:ea46 with SMTP id 98e67ed59e1d1-3779beb2b77mr1242498a91.2.1781149996617; Wed, 10 Jun 2026 20:53:16 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:16 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 09/15] dmaengine: fsldma: use devm_kzalloc() to simplify code Date: Wed, 10 Jun 2026 20:52:39 -0700 Message-ID: <20260611035245.13439-10-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert fdev allocation from kzalloc_obj() to devm_kzalloc() to simplify the probe error and remove paths by dropping the explicit kfree. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index eba194d64105..c3d2b24f8f07 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1222,29 +1222,25 @@ static void fsldma_device_release(struct dma_device *dma_dev); static int fsldma_of_probe(struct platform_device *op) { + struct device *dev = &op->dev; struct fsldma_device *fdev; struct device_node *child; unsigned int i; int err; - fdev = kzalloc_obj(*fdev); - if (!fdev) { - err = -ENOMEM; - goto out_return; - } + fdev = devm_kzalloc(dev, sizeof(*fdev), GFP_KERNEL); + if (!fdev) + return -ENOMEM; - fdev->dev = &op->dev; + fdev->dev = dev; INIT_LIST_HEAD(&fdev->common.channels); /* The DMA address bits supported for this device. */ fdev->addr_bits = (long)device_get_match_data(fdev->dev); /* ioremap the registers for use */ fdev->regs = of_iomap(op->dev.of_node, 0); - if (!fdev->regs) { - dev_err(&op->dev, "unable to ioremap registers\n"); - err = -ENOMEM; - goto out_free; - } + if (!fdev->regs) + return dev_err_probe(&op->dev, -ENOMEM, "unable to ioremap registers\n"); /* map the channel IRQ if it exists, but don't hookup the handler yet */ fdev->irq = platform_get_irq_optional(op, 0); @@ -1325,9 +1321,6 @@ static int fsldma_of_probe(struct platform_device *op) } out_iounmap: iounmap(fdev->regs); -out_free: - kfree(fdev); -out_return: return err; } @@ -1361,7 +1354,6 @@ static void fsldma_of_remove(struct platform_device *op) } iounmap(fdev->regs); - kfree(fdev); } #ifdef CONFIG_PM -- 2.54.0